Received-SPF: pass (google.com: domain of linux-kernel+bounces-37881-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Content-Type: multipart/mixed; boundary="------------lQrJ9OFVI4N0V27GzGVY0R30"
Message-ID: <c0527ca3-22c3-4b92-a34f-adf0cae78146@zytor.com>
Date: Wed, 24 Jan 2024 18:00:16 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] x86/boot: Add a message about ignored early NMIs
To: =?UTF-8?B?Tk9NVVJBIEpVTklDSEko6YeO5p2RIOa3s+S4gCk=?=
 <junichi.nomura@nec.com>,
        Borislav Petkov <bp@alien8.de>
Cc: "kirill.shutemov@linux.intel.com" <kirill.shutemov@linux.intel.com>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "x86@kernel.org" <x86@kernel.org>, "ardb@kernel.org" <ardb@kernel.org>,
        "david@redhat.com" <david@redhat.com>,
        "nikunj@amd.com" <nikunj@amd.com>,
        "thomas.lendacky@amd.com" <thomas.lendacky@amd.com>,
        "debarbos@redhat.com" <debarbos@redhat.com>,
        "jlelli@redhat.com" <jlelli@redhat.com>,
        "lgoncalv@redhat.com" <lgoncalv@redhat.com>,
        "dzickus@redhat.com" <dzickus@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <ZaEe8FC767f+sxRQ@jeru.linux.bs1.fc.nec.co.jp>
 <20240112120616.5zjojjmjeqg5egb7@box>
 <ZaTziftQSSg/v5Np@jeru.linux.bs1.fc.nec.co.jp>
 <20240123112624.GBZa-iYP1l9SSYtr-V@fat_crate.local>
 <TYCPR01MB8389C46BF755C31EACE8DB37837B2@TYCPR01MB8389.jpnprd01.prod.outlook.com>
Content-Language: en-US
From: "H. Peter Anvin" <hpa@zytor.com>
In-Reply-To: <TYCPR01MB8389C46BF755C31EACE8DB37837B2@TYCPR01MB8389.jpnprd01.prod.outlook.com>

This is a multi-part message in MIME format.
--------------lQrJ9OFVI4N0V27GzGVY0R30
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


On 1/24/24 03:44, NOMURA JUNICHI(野村 淳一) wrote:
>> From: Borislav Petkov <bp@alien8.de>
>> On Mon, Jan 15, 2024 at 08:57:45AM +0000, NOMURA JUNICHI(野村 淳一) wrote:
>>> +	if (spurious_nmi_count) {
>>> +		error_putstr("Spurious early NMI ignored. Number of NMIs: 0x");
>>> +		error_puthex(spurious_nmi_count);
>>> +		error_putstr("\n");
>>
>> Uff, that's just silly:
>>
>> Spurious early NMIs ignored: 0x0000000000000017
>>
>> Would you like to add a error_putnum() or so in a prepatch which would
>> make this output
>>
>> Spurious early NMIs ignored: 23.
>>
>> ?
>>
>> So that it is human readable and doesn't make me wonder what that hex
>> value is supposed to mean?
> 
> Yes, it would be nicer to print that way.  I used the existing error_puthex() just
> to keep the patch minimal.  I will try to add error_putnum().
> 
>> Btw, please use this version when sending next time:
> 

Here is a *completely* untested patch for you...

	-hpa

--------------lQrJ9OFVI4N0V27GzGVY0R30
Content-Type: text/x-patch; charset=UTF-8; name="putnum.diff"
Content-Disposition: attachment; filename="putnum.diff"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL2FyY2gveDg2L2Jvb3QvY29tcHJlc3NlZC9taXNjLmMgYi9hcmNoL3g4
Ni9ib290L2NvbXByZXNzZWQvbWlzYy5jCmluZGV4IGI5OWUwOGU2ODE1Yi4uYmYyYWFjNGYx
OTVlIDEwMDY0NAotLS0gYS9hcmNoL3g4Ni9ib290L2NvbXByZXNzZWQvbWlzYy5jCisrKyBi
L2FyY2gveDg2L2Jvb3QvY29tcHJlc3NlZC9taXNjLmMKQEAgLTE2NCwyMSArMTY0LDM0IEBA
IHZvaWQgX19wdXRzdHIoY29uc3QgY2hhciAqcykKIAlvdXRiKDB4ZmYgJiAocG9zID4+IDEp
LCB2aWRwb3J0KzEpOwogfQogCi12b2lkIF9fcHV0aGV4KHVuc2lnbmVkIGxvbmcgdmFsdWUp
CitzdGF0aWMgbm9pbmxpbmUgdm9pZCBfX3B1dG51bSh1bnNpZ25lZCBsb25nIHZhbHVlLCB1
bnNpZ25lZCBpbnQgYmFzZSwKKwkJCSAgICAgIGludCBtaW5kaWcpCiB7Ci0JY2hhciBhbHBo
YVsyXSA9ICIwIjsKLQlpbnQgYml0czsKKwljaGFyIGJ1Zls4KnNpemVvZih2YWx1ZSkrMV07
CisJY2hhciAqcDsKIAotCWZvciAoYml0cyA9IHNpemVvZih2YWx1ZSkgKiA4IC0gNDsgYml0
cyA+PSAwOyBiaXRzIC09IDQpIHsKLQkJdW5zaWduZWQgbG9uZyBkaWdpdCA9ICh2YWx1ZSA+
PiBiaXRzKSAmIDB4ZjsKKwlwID0gYnVmICsgc2l6ZW9mKGJ1Zik7CisJKi0tcCA9ICdcMCc7
CiAKLQkJaWYgKGRpZ2l0IDwgMHhBKQotCQkJYWxwaGFbMF0gPSAnMCcgKyBkaWdpdDsKLQkJ
ZWxzZQotCQkJYWxwaGFbMF0gPSAnYScgKyAoZGlnaXQgLSAweEEpOworCXdoaWxlIChtaW5k
aWctLSA+IDAgfHwgdmFsdWUpIHsKKwkJdW5zaWduZWQgY2hhciBkaWdpdCA9IHZhbHVlICUg
YmFzZTsKKwkJZGlnaXQgKz0gKGRpZ2l0ID49IDEwKSA/ICgnYSctMTApIDogJzAnOworCQkq
LS1wID0gZGlnaXQ7CiAKLQkJX19wdXRzdHIoYWxwaGEpOworCQl2YWx1ZSAvPSBiYXNlOwog
CX0KKworCV9fcHV0c3RyKHApOworfQorCit2b2lkIF9fcHV0aGV4KHVuc2lnbmVkIGxvbmcg
dmFsdWUpCit7CisJX19wdXRudW0odmFsdWUsIDE2LCBzaXplb2YodmFsdWUpKjIpOworfQor
Cit2b2lkIF9fcHV0ZGVjKHVuc2lnbmVkIGxvbmcgdmFsdWUpCit7CisJX19wdXRudW0odmFs
dWUsIDEwLCAxKTsKIH0KIAogI2lmZGVmIENPTkZJR19YODZfTkVFRF9SRUxPQ1MKZGlmZiAt
LWdpdCBhL2FyY2gveDg2L2Jvb3QvY29tcHJlc3NlZC9taXNjLmggYi9hcmNoL3g4Ni9ib290
L2NvbXByZXNzZWQvbWlzYy5oCmluZGV4IGJjMmYwZjE3ZmI5MC4uNjUwMmJjNjlkMWI4IDEw
MDY0NAotLS0gYS9hcmNoL3g4Ni9ib290L2NvbXByZXNzZWQvbWlzYy5oCisrKyBiL2FyY2gv
eDg2L2Jvb3QvY29tcHJlc3NlZC9taXNjLmgKQEAgLTYzLDggKzYzLDEwIEBAIHZvaWQgKm1h
bGxvYyhpbnQgc2l6ZSk7CiB2b2lkIGZyZWUodm9pZCAqd2hlcmUpOwogdm9pZCBfX3B1dHN0
cihjb25zdCBjaGFyICpzKTsKIHZvaWQgX19wdXRoZXgodW5zaWduZWQgbG9uZyB2YWx1ZSk7
Cit2b2lkIF9fcHV0ZGVjKHVuc2lnbmVkIGxvbmcgdmFsdWUpOwogI2RlZmluZSBlcnJvcl9w
dXRzdHIoX194KSAgX19wdXRzdHIoX194KQogI2RlZmluZSBlcnJvcl9wdXRoZXgoX194KSAg
X19wdXRoZXgoX194KQorI2RlZmluZSBlcnJvcl9wdXRkZWMoX194KSAgX19wdXRkZWMoX194
KQogCiAjaWZkZWYgQ09ORklHX1g4Nl9WRVJCT1NFX0JPT1RVUAogCg==

--------------lQrJ9OFVI4N0V27GzGVY0R30--