Received-SPF: pass (google.com: domain of linux-kernel+bounces-37885-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <cf035125-d7fb-4423-8f64-a5be7505243d@amd.com>
Date: Wed, 24 Jan 2024 18:14:30 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net] octeontx2-af: Initialize bitmap arrays.
Content-Language: en-US
To: Ratheesh Kannoth <rkannoth@marvell.com>, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org
Cc: sgoutham@marvell.com, davem@davemloft.net, edumazet@google.com,
 kuba@kernel.org, pabeni@redhat.com, sbhatta@marvell.com, gakula@marvell.com,
 hkelam@marvell.com
References: <20240123051245.3801246-1-rkannoth@marvell.com>
From: Brett Creeley <bcreeley@amd.com>
In-Reply-To: <20240123051245.3801246-1-rkannoth@marvell.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?NWFJdWlIR1FuQk9nTnhVNTlVRi95VG43NFVwenZxVHZLZnN4UnlQQUNCL3NB?=
 =?utf-8?B?TEhHdThPRTFuUkxRTUN4V1dGRHdzSm02QjRUelgyc0Urdy9uNWtnbmc0dHRU?=
 =?utf-8?B?SUFrbkZ2YXJ0WnhpaW9EYnZ4SjZXbDExNEhCSEYxbVNJQkRrY1h6OTVPS0dL?=
 =?utf-8?B?OUVkOTRmaHhRMmd1UU9vR3ZwTzNwWE5zQ1JHRVN1TDZON0ZLK0tDelBlUmtU?=
 =?utf-8?B?S1VSdm1va0xXUEhVam55aFBNZE12cWYreitLUGdUY2lKdU1HK2lQWklBOTEr?=
 =?utf-8?B?NUM0UjZtUjJCajZ6R2NaVVRRak5BUWhrNytJcVg1dVpZeW5GWjE0TGFLZ3lr?=
 =?utf-8?B?K05PMVlCYmRzNVVrM0YrNWpZMlZoemI3ZDJPbkNiU3BpMkl1ZkFobGJXNDZN?=
 =?utf-8?B?SEdoVnVEZENGQlc5eGlOeVRJQUFJNGp1dng1OHJ0VEVUK3RhWVRvb0wvNEYz?=
 =?utf-8?B?MUtoek9rd0prRWZGaUc5eHFKR2dnb1NoZTBWUFd6VTluakdWMlpyODlkNHdk?=
 =?utf-8?B?czhXMGhoSHdXN1dzOTl4eUd3REdGVG93Y1BqT1UxWVBnN0k3UHVlbzE1TkRs?=
 =?utf-8?B?U052b2d4MUtQTXJjcEVWbWc2NHdRdG1CYkt1dExlek9IcC95T3NvZXoyeVBw?=
 =?utf-8?B?M2pMMkg4VVU0eVdtNWw0WTE0T3BVNjlaWnNBejdOc3hRdXI1MjhQaTFqcThq?=
 =?utf-8?B?dld0eWZ4RVkvZXpLajU3ZGE5SmFOMi9CSnEyTEQ1VjJxcDFIckFJa2F1bGxG?=
 =?utf-8?B?dFpqTU5sazI2LzQyR3lxVDRTcUV2R1Vkb3pma0x4a0hTbThMVDQ5T0tqTytt?=
 =?utf-8?B?dkYraHhZV2VCS0hROTZ4N0t1SkhxTG02N0VibUQzQWtTMk5jaWg4WmdUbVNz?=
 =?utf-8?B?Y1JianRTUFZVSUV1TU4xTmpBVnY2V0hEV2hEb0FYcDRSOVZDSTJiQ0Z1c0Nv?=
 =?utf-8?B?RWxIQmc0YXRBVDV6bUlyeDJQSHRjZDRaVDAwYUVnQUlpUEM5cVdTeTNrRnhB?=
 =?utf-8?B?V1M0a3FSMHJiMjNnYzM5b3ZsTjJRVDFXNGUwT1ZidE9tVEFZVmIxdjg2SVpu?=
 =?utf-8?B?WUpFWDgrclV1b1F1UnpvUUdvTjNrRFp3cldCanorN3ltWHVXSUtadDFPRHdz?=
 =?utf-8?B?b29iYThxcmFNUFNacnFxT0ZKOE1ncTA2MFl5RjhzVEZVYWxkR3RnMElhaUhM?=
 =?utf-8?B?Z1pndFB3SVRZWVgxUzdjNE9ZNkR4M2NieXhVcDlQZTFmZU5zNjhIbi8vZ0Ry?=
 =?utf-8?B?TitlODN1K09YNmFuVUNUMU1XUjJGRXplR21CenYyRkkyODRuYlpQSXM2bHU3?=
 =?utf-8?B?WitTbDF3aDNBTXVUSkpVTm1id3UyMXpzdXowZ3VVOHZTWEJsTXY3K3BSNXZw?=
 =?utf-8?B?dXBTUUtOaWozZjZDQ3ZoWXpWRXptMGRMQ25rOVpVY0hCdGtIcW5PaFNxWHBn?=
 =?utf-8?B?Rk9QMVFmUEhLYUgyQ2ZNOGw1a0NGZ3RhaUlRNVJNSklTem1WeUo2WkQ4LzVY?=
 =?utf-8?B?NWprRWJuU211dGVVeCtWWUU3VVFMMFljQm5oN1h5T3FYZGFlbjhTcDJJK3pD?=
 =?utf-8?B?T2pHVjUvRFJrYXJmRnFDSFFJMHc3S1RRYlh5ZkdSTm45c2dtUUU5VGk1QXND?=
 =?utf-8?B?cXhsUVg4OER6OGdpV1JIcUZUcXNxVUdiT1Z1MXZHZmF0QXBsSGo5RXFPMFhN?=
 =?utf-8?B?Wno0a2hIN1pxNDUrWGNLaWtlQWZBMWVNcDFvajhqN21KS1NaU3R4a2JJVnpv?=
 =?utf-8?B?VlhIa0poMlhjcTQvMzRPUHRUV0JZSnZ3ajVxVlFDWHVuaHA2QXJ3Y1puRStR?=
 =?utf-8?B?NUwvaWtTVjZ2Sy9reitUYjJaMWFvUWlUWVhpZk9QeDFDaDJhSHRKNnlmK1ZL?=
 =?utf-8?B?WlE4MUYydXVjbFI4R0E1ZzBnanQxNXdQSmxtMmIvZTl0VDlXTWlRenBWd3pr?=
 =?utf-8?B?MER4UDQ1NncwZ1ZHdDlvbGh3ZTMwNWtRSmE4UU9qeXhYMXpHZWxzTW1xUTUy?=
 =?utf-8?B?T3h0UE56SVhPSEJiczVtak51MVJWTzE0MXVNRlNNL3R6aE5BdWYvVHEraUJm?=
 =?utf-8?B?SWI4MHRwZjIyM0xVczY5ZkZGOStjWVhiKy9HQmUrcDJ1ZUI1UWttWDRzYzlC?=
 =?utf-8?Q?+va7bJlqLUVru3UtuzS5lVFCq?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ac1ea373-ee4e-48f8-e0e5-08dc1d4b5ed5
X-MS-Exchange-CrossTenant-AuthSource: PH0PR12MB7982.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2024 02:14:33.1588
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xBOKyBg/fXMMpgt6FEVaeFhaw/LaxoJpyKket2L2A3bwi05GTxNwKZj1SWDenzoMP89wVI8wJIAMOToGlCKKSw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5337

On 1/22/2024 9:12 PM, Ratheesh Kannoth wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> kmalloc_array() does not initializes memory to zero.
> This causes issues with bitmap. Use devm_kcalloc()
> to fix the issue.
> 

Is there any reason to not use:

bitmap_zalloc() and bitmap_free()?

> Fixes: dd7842878633 ("octeontx2-af: Add new devlink param to configure maximum usable NIX block LFs")
> Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com>
> ---
>   .../ethernet/marvell/octeontx2/af/rvu_npc.c   | 55 ++++++++++---------
>   1 file changed, 28 insertions(+), 27 deletions(-)
> 
> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
> index 167145bdcb75..7539e6f0290a 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_npc.c
> @@ -1850,13 +1850,13 @@ void npc_mcam_rsrcs_deinit(struct rvu *rvu)
>   {
>          struct npc_mcam *mcam = &rvu->hw->mcam;
> 
> -       kfree(mcam->bmap);
> -       kfree(mcam->bmap_reverse);
> -       kfree(mcam->entry2pfvf_map);
> -       kfree(mcam->cntr2pfvf_map);
> -       kfree(mcam->entry2cntr_map);
> -       kfree(mcam->cntr_refcnt);
> -       kfree(mcam->entry2target_pffunc);
> +       devm_kfree(rvu->dev, mcam->bmap);
> +       devm_kfree(rvu->dev, mcam->bmap_reverse);
> +       devm_kfree(rvu->dev, mcam->entry2pfvf_map);
> +       devm_kfree(rvu->dev, mcam->cntr2pfvf_map);
> +       devm_kfree(rvu->dev, mcam->entry2cntr_map);
> +       devm_kfree(rvu->dev, mcam->cntr_refcnt);
> +       devm_kfree(rvu->dev, mcam->entry2target_pffunc);
>          kfree(mcam->counters.bmap);
>   }
> 
> @@ -1904,21 +1904,22 @@ int npc_mcam_rsrcs_init(struct rvu *rvu, int blkaddr)
>          mcam->pf_offset = mcam->nixlf_offset + nixlf_count;
> 
>          /* Allocate bitmaps for managing MCAM entries */
> -       mcam->bmap = kmalloc_array(BITS_TO_LONGS(mcam->bmap_entries),
> -                                  sizeof(long), GFP_KERNEL);
> +       mcam->bmap = devm_kcalloc(rvu->dev, BITS_TO_LONGS(mcam->bmap_entries),
> +                                 sizeof(long), GFP_KERNEL);

This is pretty much bitmap_zalloc(), except with devm. As Simon is 
asking, is devm really necessary? If not bitmap_zalloc() and 
bitmap_free() seem to fit your use well if I'm not mistaken.

Thanks,

Brett
>          if (!mcam->bmap)
>                  return -ENOMEM;
> 
> -       mcam->bmap_reverse = kmalloc_array(BITS_TO_LONGS(mcam->bmap_entries),
> -                                          sizeof(long), GFP_KERNEL);
> +       mcam->bmap_reverse = devm_kcalloc(rvu->dev,
> +                                         BITS_TO_LONGS(mcam->bmap_entries),
> +                                         sizeof(long), GFP_KERNEL);
>          if (!mcam->bmap_reverse)
>                  goto free_bmap;
> 
>          mcam->bmap_fcnt = mcam->bmap_entries;
> 
>          /* Alloc memory for saving entry to RVU PFFUNC allocation mapping */
> -       mcam->entry2pfvf_map = kmalloc_array(mcam->bmap_entries,
> -                                            sizeof(u16), GFP_KERNEL);
> +       mcam->entry2pfvf_map = devm_kcalloc(rvu->dev, mcam->bmap_entries,
> +                                           sizeof(u16), GFP_KERNEL);
>          if (!mcam->entry2pfvf_map)
>                  goto free_bmap_reverse;
> 
> @@ -1941,27 +1942,27 @@ int npc_mcam_rsrcs_init(struct rvu *rvu, int blkaddr)
>          if (err)
>                  goto free_entry_map;
> 
> -       mcam->cntr2pfvf_map = kmalloc_array(mcam->counters.max,
> -                                           sizeof(u16), GFP_KERNEL);
> +       mcam->cntr2pfvf_map = devm_kcalloc(rvu->dev, mcam->counters.max,
> +                                          sizeof(u16), GFP_KERNEL);
>          if (!mcam->cntr2pfvf_map)
>                  goto free_cntr_bmap;
> 
>          /* Alloc memory for MCAM entry to counter mapping and for tracking
>           * counter's reference count.
>           */
> -       mcam->entry2cntr_map = kmalloc_array(mcam->bmap_entries,
> -                                            sizeof(u16), GFP_KERNEL);
> +       mcam->entry2cntr_map = devm_kcalloc(rvu->dev, mcam->bmap_entries,
> +                                           sizeof(u16), GFP_KERNEL);
>          if (!mcam->entry2cntr_map)
>                  goto free_cntr_map;
> 
> -       mcam->cntr_refcnt = kmalloc_array(mcam->counters.max,
> -                                         sizeof(u16), GFP_KERNEL);
> +       mcam->cntr_refcnt = devm_kcalloc(rvu->dev, mcam->counters.max,
> +                                        sizeof(u16), GFP_KERNEL);
>          if (!mcam->cntr_refcnt)
>                  goto free_entry_cntr_map;
> 
>          /* Alloc memory for saving target device of mcam rule */
> -       mcam->entry2target_pffunc = kmalloc_array(mcam->total_entries,
> -                                                 sizeof(u16), GFP_KERNEL);
> +       mcam->entry2target_pffunc = devm_kcalloc(rvu->dev, mcam->total_entries,
> +                                                sizeof(u16), GFP_KERNEL);
>          if (!mcam->entry2target_pffunc)
>                  goto free_cntr_refcnt;
> 
> @@ -1978,19 +1979,19 @@ int npc_mcam_rsrcs_init(struct rvu *rvu, int blkaddr)
>          return 0;
> 
>   free_cntr_refcnt:
> -       kfree(mcam->cntr_refcnt);
> +       devm_kfree(rvu->dev, mcam->cntr_refcnt);
>   free_entry_cntr_map:
> -       kfree(mcam->entry2cntr_map);
> +       devm_kfree(rvu->dev, mcam->entry2cntr_map);
>   free_cntr_map:
> -       kfree(mcam->cntr2pfvf_map);
> +       devm_kfree(rvu->dev, mcam->cntr2pfvf_map);
>   free_cntr_bmap:
>          kfree(mcam->counters.bmap);
>   free_entry_map:
> -       kfree(mcam->entry2pfvf_map);
> +       devm_kfree(rvu->dev, mcam->entry2pfvf_map);
>   free_bmap_reverse:
> -       kfree(mcam->bmap_reverse);
> +       devm_kfree(rvu->dev, mcam->bmap_reverse);
>   free_bmap:
> -       kfree(mcam->bmap);
> +       devm_kfree(rvu->dev, mcam->bmap);
> 
>          return -ENOMEM;
>   }
> --
> 2.25.1
> 
>