Received-SPF: pass (google.com: domain of linux-kernel+bounces-37889-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
To: Andrew Halaney <ahalaney@redhat.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio
 <konrad.dybcio@linaro.org>,
        Manivannan Sadhasivam
 <manivannan.sadhasivam@linaro.org>,
        "James E.J. Bottomley"
 <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>, echanude@redhat.com,
        linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: ufs: qcom: Clarify comments about the initial
 phy_gear
From: "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1zfwuuoo9.fsf@ca-mkp.ca.oracle.com>
References: <20240123-ufs-reinit-comments-v1-1-ff2b3532d7fe@redhat.com>
Date: Wed, 24 Jan 2024 21:34:10 -0500
In-Reply-To: <20240123-ufs-reinit-comments-v1-1-ff2b3532d7fe@redhat.com>
	(Andrew Halaney's message of "Tue, 23 Jan 2024 13:13:36 -0600")
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?qlaKxM4ArL9xNwiE/iz43Sl4rSMkYX3xHri2HGKPSdL/OAuBLZyc/v0g2sk5?=
 =?us-ascii?Q?IOJcT/N+w8G6dggEvK5CWGwOYZ6I4G9SAF6JzC3yTvSvKFcTWikEo1vAKbja?=
 =?us-ascii?Q?5jxU8bjPAvCIFwDmD49SS4FdSbs8Vp5ELvEwXYeMr+N2Q7L6/wkcbHAU1vOU?=
 =?us-ascii?Q?wBfiWjE9bwH2IFlqNPv81FMs9Cv4nM4zx0+hZpusGDITkIGT0QUyM/F2CG+c?=
 =?us-ascii?Q?E/hCRKfVCRXOpXmBs5shPDAzZDRMiHuZVKbfpNXzZsbvzWMLGxy4B8kCeLn3?=
 =?us-ascii?Q?erVln0XiVK3d3kExPEG6GnCKU06muRitxttzx+WaS80V8KFyoA1+Rso0edtB?=
 =?us-ascii?Q?ay5k/hJgI2M4bZuumUDfoqEaSh1iudvGUDEeneCpi7/q3isrMK/D/jmYcDyi?=
 =?us-ascii?Q?DWbm7wTRc34zD28E2A3wshXE17vPw84aMtdKCyor6kNEiYBA7H4YTlmjDawH?=
 =?us-ascii?Q?lkSUkBMMLzXt4zdA2hQblofzDcKU4zDBl46PJlk3ePKl2Aq3Ki2TNa36rR0F?=
 =?us-ascii?Q?0nsGqwa18/tBecbHsde1ORxIM/Ft2+IkpvB1gBfNceo6M4I1F+uMlcxOtryp?=
 =?us-ascii?Q?7JO7H9KAe1VLv7Hui9KMeDupqtOhBRx0YaYzvfBMraLyNlQmJp3PCc1TckGx?=
 =?us-ascii?Q?y5lojC94BESswNzZyGvf2feEdkEHzMsu1JviBu1uFiLcI3DUI6OS+lJqYSqy?=
 =?us-ascii?Q?k/Gc/uHNuUXoruuBnr5NMyosllet+0wGTzFCI6I9iy/dCzKDUTaWB6nd8Px7?=
 =?us-ascii?Q?dkDCDruY4nAz4dy17XFpKNA+nKfQKO7R1UR4t5+Chw1d+gRxGiTosp/TH3Pu?=
 =?us-ascii?Q?omAdNuSgQDXweygxWk8xWWq3UnODm+JyGVul7ikdofQ0GQEbvYL+69qtOT9h?=
 =?us-ascii?Q?hUAvwpuLNYzWXzQsyB3472PVCJybiNOYgwgXrNFiWAJ/ihrM5kf1A8LEwxQz?=
 =?us-ascii?Q?rnkUZzlOAV8CnL66oQRCtYeq7zTIxTemcVzwyMG2kc99qDdgB3JN0WUjhumZ?=
 =?us-ascii?Q?xsnrIrPmvGZw7PFz20BwpYIuJveHoThXwqwaN8RwVvyhUNW0SxrunmXRRc7T?=
 =?us-ascii?Q?0JRKD6LPXICiezwws1uGvc+8nZ4QNadtbCs3gbrzLY2cRyRfwl5WJFdDTYHm?=
 =?us-ascii?Q?NGurj2bWG2cqZF+l8DggT8V0pCP1WufCZdGNf71rBVKzHg0ZKG4c4w6KUFGq?=
 =?us-ascii?Q?hMPm4yzrzFqXjPHVwf6hsQh74vHuCJRfLYx21ympTmC2ULQWBQINlvIZ60nn?=
 =?us-ascii?Q?Fl2Zorcz+Z/+0TE+q6NJG+1K4uHZLL9NNSITC902nXg4DcPhNaP0IFzyXl4o?=
 =?us-ascii?Q?TrARPqL8myRjkJJ16VwXnyHyxLSmNb/IJNOPuxYF/Aun7zlyIPiOQhzqz0Jk?=
 =?us-ascii?Q?k0O4KwkHaAidRiSArTzrIrcwfjWsRMG6IPKq0HUm/HDU5CQEocZGzGCnpyDG?=
 =?us-ascii?Q?0gKNKauuBY4tJikqL9mE6F9E8GaPw5uROqdqcqyFgKvX46tBSYbPe6KOGKyL?=
 =?us-ascii?Q?M6bO/AnhWJb40ILEDCRjqfCjYi/WJiXpRH3ccK1W/tykM7RlDuvGindCze2Z?=
 =?us-ascii?Q?qdbUCYQRAkN86IBMPAIKk4ByR0fdyb8O06GgVvz3EueQmBCxMBQD8CIqH39M?=
 =?us-ascii?Q?oQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	Zxs+Th2CtuZdRoKKVi3/L3PqWmpv0Wm4IBDCDFt9Fn1xek1e7nDwGOt5aZ87bTAJPwDl5AyvjTiZPBSJ857VEaVjN542AzkFv3CViFj4gFbkWQnG28XsuY+caMdZHxf1vFUGGqmO8UiT9w15zXZGVhisxKndhNPxhyvK319vzMbub3Ga8R0JVTQ8JTgiYLc/3Lt66XV05PrzdHox6aztukMjFJYe0E/2f294fc+J9lAAqaLnt2ldw3eKWsBIYKK6FwQKGVSYct8VY0PuIGOe23AYI7QG0/LBHE62bddrNIE80fHU2VAZgHSqltecm0tIQd+Fzmex1IcPHTH3UOf1cdbWcSR2Api/iS7y/3G3OtRkML9JKQuB4KHmEzEY+AiYA7Zq3DGfNtjBguM7uI+T4kD4jVwVeEBcJgIT/Zv1BSWV4uti26ArDJZDdpH/nhSS7KF5Ff9fr7pwFYTb8NsfoqwpQPsWli3hgOvjP3gsldKiMskLyf7/Tf0KwevcCHKCF1Hje5sXXV2ahu5FKCdeao7zhj8amNjaBJyQ3IQw/zyqoOqpf2ss5BnUPhnbYxaEer9QMA/UeLT+tlbX+LKGpfVUfspODl+vDMmpUDzyfak=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d53d3a77-d2b4-4973-3b1b-08dc1d4e1f6f
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2024 02:34:15.2696
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4YRruP5jcbARvWMRSBMKfJNYa65xWsFpq5EGpar+GSn3Fa0wKndKo13vMz29kpbKutf2QGIySmLtu2uZjZvpnhNaA+ZOqE32SSjJiTTIg6I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6666
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-24_12,2024-01-24_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=814 malwarescore=0
 phishscore=0 bulkscore=0 spamscore=0 suspectscore=0 adultscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2401250017
X-Proofpoint-GUID: YWCMXgOkbXSt1D59nGzHuaInw0g3LwXy
X-Proofpoint-ORIG-GUID: YWCMXgOkbXSt1D59nGzHuaInw0g3LwXy


Andrew,

> The comments that currently are within the hw_ver < 4 conditional are
> misleading. They really apply to various branches of the conditionals
> there and incorrectly state that the phy_gear value can increase.

Applied to 6.9/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering