Received-SPF: pass (google.com: domain of linux-kernel+bounces-37900-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <884eb509-a997-869a-762b-b4c24ff89c27@quicinc.com>
Date: Wed, 24 Jan 2024 18:52:59 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: [PATCH v2 1/2] arm64: dts: qcom: sm8650-mtp: add PM8010
 regulators
Content-Language: en-US
To: Konrad Dybcio <konrad.dybcio@linaro.org>, <quic_fenglinw@quicinc.com>,
        <kernel@quicinc.com>, Bjorn Andersson <andersson@kernel.org>,
        Rob Herring
	<robh+dt@kernel.org>,
        Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>
CC: <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        Neil Armstrong <neil.armstrong@linaro.org>
References: <20240123-sm8650_pm8010_support-v2-0-52f517b20a1d@quicinc.com>
 <20240123-sm8650_pm8010_support-v2-1-52f517b20a1d@quicinc.com>
 <892058db-8013-879d-6c6f-3fbbf4ed3c57@quicinc.com>
 <30e890e8-42dd-4b36-a133-95bb34c109d8@linaro.org>
From: David Collins <quic_collinsd@quicinc.com>
In-Reply-To: <30e890e8-42dd-4b36-a133-95bb34c109d8@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit

On 1/24/24 15:36, Konrad Dybcio wrote:
> On 1/24/24 20:15, David Collins wrote:
>> On 1/23/24 00:49, Fenglin Wu via B4 Relay wrote:
>>> From: Fenglin Wu <quic_fenglinw@quicinc.com>
>>>
>>> Add PM8010 regulator device nodes for sm8650-mtp board.
>>>
>>> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
>>> Signed-off-by: Fenglin Wu <quic_fenglinw@quicinc.com>
..
>>> +
>>> +        vreg_l1m_1p1: ldo1 {
>>> +            regulator-name = "vreg_l1m_1p1";
>>> +            regulator-min-microvolt = <1104000>;
>>> +            regulator-max-microvolt = <1104000>;
>>> +            regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>>
>> Optional:
>> PM8010 L1 and L2 physically support LPM vs HPM configuration.
>> Therefore, these lines could be added here to allow such configuration
>> by software at runtime:
>>
>> regulator-allow-set-load;
>> regulator-allowed-modes = <RPMH_REGULATOR_MODE_LPM
>>                RPMH_REGULATOR_MODE_HPM>;
> 
> David,
> 
> I was under the impression that *all* RPMh regulators support
> modesetting. Would that be an incorrect assumption to make?
> 
> Konrad

Hello Konrad,

That is generally true.  However, PM8010 LDOs 3-7 are a special case.
These do not support LPM configuration.  The limitation is enforced in
the driver by this change:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2544631faa7f3244c9bcb9b511ca4f1a4f5a3ba0
.

Take care,
David