Received-SPF: pass (google.com: domain of linux-kernel+bounces-37931-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 25 Jan 2024 11:43:57 +0800
From: Chao Gao <chao.gao@intel.com>
To: Yang Weijiang <weijiang.yang@intel.com>
CC: <seanjc@google.com>, <pbonzini@redhat.com>, <dave.hansen@intel.com>,
	<kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
	<yuan.yao@linux.intel.com>, <peterz@infradead.org>,
	<rick.p.edgecombe@intel.com>, <mlevitsk@redhat.com>, <john.allen@amd.com>
Subject: Re: [PATCH v9 09/27] KVM: x86: Rename kvm_{g,s}et_msr() to menifest
 emulation operations
Message-ID: <ZbHY/UVpRVRuyELV@chao-email>
References: <20240124024200.102792-1-weijiang.yang@intel.com>
 <20240124024200.102792-10-weijiang.yang@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240124024200.102792-10-weijiang.yang@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5p3i0FEUq/nHAwCHk2ZsGzR4EScSoSSlb38W4imX9r+MeI6V9JJI4zv21haH?=
 =?us-ascii?Q?9OrGxeKFQOZqew6lpKaHnsT8HUrjdPqxX4MSUsAZloWu2xGC0rh+q4W/oXSg?=
 =?us-ascii?Q?7XHql3Q26a/68tkV4RydsFLQa56G+u56dC1i9PmYMCObkNHpmge2JM3gyyle?=
 =?us-ascii?Q?xzGx33BPeNKV24qKH2BtBNAcRSkReBgzd1kpgTCruU2L17rELMzKHLjktjvt?=
 =?us-ascii?Q?SnQ7ybKDWJXbZNEEUXA4q573BSB3waIUqCIVNLMEmQBFhK8H7oeXkJ+87o6P?=
 =?us-ascii?Q?BW/lQ56GWhB7sCh9lcc6dGe45h/ucWDmeYtViYyQUGTq+6ylk2MM1CaZbxNC?=
 =?us-ascii?Q?ud8y6uLea47QpFugOS/MTxmR/iLXBhJWbuLZw0ou41nxdjWsdz7cxV95hDgr?=
 =?us-ascii?Q?DVqU/njOlETT3H1D11tw/6z2qp75U/AlYbtDDRe/xf3qz9ccypVhKaSx8Cdt?=
 =?us-ascii?Q?9OVHD0eOs8W6x+SkR+ORVRc3T6dlc5EDD3+CGbEDnBwF4j1VTtkwFwj+PU8w?=
 =?us-ascii?Q?9nP9yoFbN46OHinDjANG6cOuh1CRnP9Rw7oIP7OksAZ3ICWflkQMHDk/P2pK?=
 =?us-ascii?Q?aMR3rFPS4Fuy6jYlsFgNhUbHu0oMgZKDeDxfioizMfnuY9Yikw98qDFwo8Eg?=
 =?us-ascii?Q?1XygT9XPZB++wZq1cWXbJuUEep9bnU1P37P8HuIGlq1NrPnFzVSZc/WXKDsv?=
 =?us-ascii?Q?ftp/wcrMbVcIKORfjqPovJNDeMXeNYLg2BKhwlPC9jcLZH6X3rcyTre60hzh?=
 =?us-ascii?Q?elWjtIp++iB9LNZSd4LKXx/gvkcDNlzhWWz53RNSKMytgp/YTFe6/UaWYiA5?=
 =?us-ascii?Q?64wM6oRb/EsI73LBNt8RFakWcleETnV5xPfG9SioFH3jU88RTklS6FU7+KTi?=
 =?us-ascii?Q?sIziJLzNPc5grl79w/c0k0qKP8DXnxKBk7puy4M4z6Gco/MSzxMI3iriAlK3?=
 =?us-ascii?Q?y8Y0+vLarxhUWQSpqu4SVjhQdjWzMnel2aF9srtaYEr3ryTFTtw0vUgA86Wv?=
 =?us-ascii?Q?tZDWNXIWqyATrbcqUUYwFDDcQRj9msnv7Tm/w9ExZY25K/VjrtVYAKXw5LbP?=
 =?us-ascii?Q?hZIdcvOuetsoAO5IilLrAuqYCKZty5cNyDJZWRfBUDz7jeoqwDoqs0CQVtCF?=
 =?us-ascii?Q?Frp0sLmjSRqVlS32DDuATq8htm9kYS9ze4iXFkoj7IBc+Tr075m71hv9dpYV?=
 =?us-ascii?Q?NyDVRi01PvNWVkVvSo+hnAyzAMuBZh8C6JUIyc7acic7AmxHsB8kcih6YTgN?=
 =?us-ascii?Q?Lh5dC5UECRqeDADM8F504wzNE3/3K72o0j7Mm8maReLbZssTJormHy67pYr1?=
 =?us-ascii?Q?kxn99uRv+L4ioAXUm5qKLqHxvLYYWZmomDlYMAzVPOUl3TLFGohlGXEVQ3wg?=
 =?us-ascii?Q?tRGTf8Jc2Ut+UjpMZW2VHhqmpwPfuLWrfM2NOTQtEoEUAenAEdPIdMQKTvMX?=
 =?us-ascii?Q?DE5O7BL2BQl2aKIOmO5EcsPprBAIY6kMlPVYQQDeDOtyUd4pRjPLlMLo8GvK?=
 =?us-ascii?Q?75lEutDMEJgFGDuHhQ8RCJaGdJ7mSKGJlyQqL2SxcoLW+YaD+n19hbK4zArW?=
 =?us-ascii?Q?UTXwwpePqjipK6uwEYNFY+DKlyeVYfhv5GqPiHfl?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b02bd932-f302-460e-dac4-08dc1d57e27f
X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB8660.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2024 03:44:08.0695
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: P5fDaMOZJL37E3u2g07hYvRkXv16Uy1y1288jykqtOi05dD83LVDw8qGsg5IVDKQzvBCUsVhFi2RVd+B6Ff18Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5458
X-OriginatorOrg: intel.com

On Tue, Jan 23, 2024 at 06:41:42PM -0800, Yang Weijiang wrote:
>Rename kvm_{g,s}et_msr() to kvm_emulate_msr_{read,write}() to make it
>more obvious that KVM uses these helpers to emulate guest behaviors,
>i.e., host_initiated == false in these helpers.
>
>Suggested-by: Sean Christopherson <seanjc@google.com>
>Signed-off-by: Yang Weijiang <weijiang.yang@intel.com>
>Reviewed-by: Maxim Levitsky <mlevitsk@redhat.com>

I think {kvm,emulator}_{g,s}et_msr_with_filter are equally confusing.
Maybe you can rename them as well.

Anyway, this patch looks good;

Reviewed-by: Chao Gao <chao.gao@intel.com>