Received-SPF: pass (google.com: domain of linux-kernel+bounces-37964-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Ratheesh Kannoth <rkannoth@marvell.com>
To: Simon Horman <horms@kernel.org>
CC: Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com"
	<edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        Geethasowjanya Akula
	<gakula@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>,
        Suman Ghosh
	<sumang@marvell.com>
Subject: RE: [EXT] Re: [PATCH net] octeontx2-af: Initialize bitmap arrays.
Thread-Topic: [EXT] Re: [PATCH net] octeontx2-af: Initialize bitmap arrays.
Thread-Index: 
 AQHaTbrXg+zTduWcbkyHpGKMW10e/rDntVQAgACO+HCAAIMFgIAAAFawgACx4oCAAIIVYA==
Date: Thu, 25 Jan 2024 05:03:15 +0000
Message-ID: 
 <MWHPR1801MB1918AD55E5A7E2B2CE91CC98D37A2@MWHPR1801MB1918.namprd18.prod.outlook.com>
References: <20240123051245.3801246-1-rkannoth@marvell.com>
 <20240123181716.GP254773@kernel.org>
 <MWHPR1801MB1918ADCA9FD3FAFAF9CC68B3D37B2@MWHPR1801MB1918.namprd18.prod.outlook.com>
 <20240124103755.GY254773@kernel.org>
 <MWHPR1801MB191860047DEE03672DC642E3D37B2@MWHPR1801MB1918.namprd18.prod.outlook.com>
 <20240124211547.GD217708@kernel.org>
In-Reply-To: <20240124211547.GD217708@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?s9aNpuO9sWyOy7bvGZd/pY2UDU+CmOTtqKfcIbovyt9RX87qn8OUiER9/Css?=
 =?us-ascii?Q?zOATaSsUGukZyyX5yr5N1HhU/c/x0pBdU34nlR3jzX0YWy9lEDcQcQ5C5bHB?=
 =?us-ascii?Q?d14z5KC3C9L8e1L/IUPK+2zQ9I6aAarJoJ0R3ZskuNW5MMMCnF0AxkhChL1F?=
 =?us-ascii?Q?HVPEtD2PmoEI/WSYFNAbSS1c++2+vy/vJ1s9dgQ9FOfI8QSVYjjQREu7jRca?=
 =?us-ascii?Q?BxrhQ9NPEpAvwFj8Jt2ApsHNeWKOOZH/L9AK4Sv2V+UXL9/PyO55fN/drVKR?=
 =?us-ascii?Q?c9+EXl+3mRiZ3CWZw9+BvxKPferc7C3FATHIDhNNqCcwd2CVorAs1WYQZAum?=
 =?us-ascii?Q?A7qLykEdTD8JGym6Mdmbix/U6UtePI+aJZVjVXMxfeIMjg0aYTNRtyr+oioE?=
 =?us-ascii?Q?aS403+zrtze8yt+b3cwo8kPVS5vcKjD7r9p4VJQSAjUeReOsmPGPHcBK3yuH?=
 =?us-ascii?Q?5BDhOOAmw6tCH10O9ZyHWYVHCLYu3x8Pjljh6Uy1jEYYAQN0vTMTeFgvHVwf?=
 =?us-ascii?Q?KIVPmPfMVOrA14upsObGgB+e6tHFLxLDeC+bGlhJXx7D+qlQ3i5WSBXCuXh7?=
 =?us-ascii?Q?ubIKxS776xsW+4PPjzSvQpNzMRc/LDMQrJOXF3bY3BRsVsAljSIZrnna0OI4?=
 =?us-ascii?Q?l/M/pS4dHLB0L9da7MSW6erEggCfFNydoXfQPP8TdcPxETMXwhUJ667+HaY3?=
 =?us-ascii?Q?yqMTZIjQXxJ5HA1hn38jdZ/93CkWt5QIRzgxYE4EdyX4IwvklD+ElY4If8As?=
 =?us-ascii?Q?ZuSuSs0YHNas/4/5EdAC0fQg42Kx1Tb4usDlQMqaMeuNUAXS8svMSEPP2vEG?=
 =?us-ascii?Q?g3KHAFYZQpErzFeu+if2v3MVVQunoKvmKznKWZuLvGnloffyHIPqwMv3hvYj?=
 =?us-ascii?Q?Cc5Eu3QQ8GEDXCcJ1JNsk88V8boEXEw2JckIMUVNvzK8hNU48VKfGek7lpBF?=
 =?us-ascii?Q?BKXm7Zs9X1+eX3qZxhRffvtISUUeISs0uUv5orOlZX2RnzB2vEL9CG7eLCII?=
 =?us-ascii?Q?TwW4ZfiI+q2ic8/xqr8xi3+hQPUH8CTs+Ch0nYr3sdbf071PoPZT3HXI/AWJ?=
 =?us-ascii?Q?bZLh+Qg/e73luw3eLw+sd8ZG8fgLb7rwE1u9pSenlu3OHHmyIDpkzJqxmE6Z?=
 =?us-ascii?Q?HGeGUq9gAhrLVTadu+LjLZK8ssuOzJLgsSCpSfMwpfoh9I15MVSxpFVKpfv6?=
 =?us-ascii?Q?+j6pWYCyolEiUbp9OeaMgENw0/tHkfDF0JtZx80xahn97hg36gmsYjvcok6U?=
 =?us-ascii?Q?LBDUd6EW5cDSv+OwW/KNeYnnrPEA8bdnUr0R/SKDxsLWGeOYV9kDu/HEl9sk?=
 =?us-ascii?Q?nNcGGfyVFJ80kOCeIXkDGReii7P0mdfkToNGG8npRfGT8foOVEyp1+FuUv34?=
 =?us-ascii?Q?SO8h9GFIMPNLIRrYWeNWGKVmvwpHp069NpG9jtKJkod/nql97w4Xj87XmjHV?=
 =?us-ascii?Q?DCybfpfH+a6yBR7zqOEjU8x3D/tt8iZBW3nYW9DeCMfsBE60ecG8SJXXSZu0?=
 =?us-ascii?Q?9O/cl0AF1N+rT9VIJehVUzegmxRele/7bcKUjccQFQJsM1cCG92rDbvcvboV?=
 =?us-ascii?Q?vLy5DFLupiS2zHMsGWMPZpKYLs3XkxME2mwUBZG+?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1801MB1918.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b911b72-e092-401e-39b4-08dc1d62f020
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2024 05:03:15.1851
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: kcMVyiFwuxVtM1TepY+f/ohwIpU8Me7nIcJQUdtSUnZ56YnJYD/cIKPcOIQOIFqCw9mNBgFbt5zGv/fFKUngYg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR18MB5396
X-Proofpoint-ORIG-GUID: qBthnDehnY9LAWVwZ7YKUGSRghJW3rBs
X-Proofpoint-GUID: qBthnDehnY9LAWVwZ7YKUGSRghJW3rBs
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-25_02,2024-01-24_01,2023-05-22_02

> From: Simon Horman <horms@kernel.org>
> Subject: Re: [EXT] Re: [PATCH net] octeontx2-af: Initialize bitmap arrays=
.


> I do understand that devm_free() exists, and there are cases where it mak=
es
> sense. But I don't think devm_ is buying us anything here.
For graceful Error handling, this API makes sense.  =20

> 1. Use kcalloc() instead of devm_kcalloc() 2. Not change kfree() calls to
> devm_kfree()
>=20
> Then you will end up with a smaller diff than the current patch.
> And it will address the problem described in the patch description.
ACK.