Received-SPF: pass (google.com: domain of linux-kernel+bounces-37980-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <2291204f-97d5-4887-b68f-8789fe85f838@ti.com>
Date: Thu, 25 Jan 2024 11:17:12 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] arm64: dts: ti: k3-am62p-mcu/wakeup: Disable MCU and
 wakeup R5FSS nodes
Content-Language: en-US
To: Nishanth Menon <nm@ti.com>, Jayesh Choudhary <j-choudhary@ti.com>
CC: <vigneshr@ti.com>, <kristo@kernel.org>, <robh+dt@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
        <bb@ti.com>, <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <u-kumar1@ti.com>
References: <20240121134017.374992-1-vaishnav.a@ti.com>
 <0fcec921-0220-4251-afa4-44db5e80d2ef@ti.com>
 <20240124172151.ngxaq6k5tnvsx4jr@proud>
From: Vaishnav Achath <vaishnav.a@ti.com>
In-Reply-To: <20240124172151.ngxaq6k5tnvsx4jr@proud>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

Hi Nishanth,

On 24/01/24 22:51, Nishanth Menon wrote:
> On 11:26-20240124, Jayesh Choudhary wrote:
>> Hello Vaishnav,
>>
>> On 21/01/24 19:10, Vaishnav Achath wrote:
>>> K3 Remoteproc R5 driver requires reserved memory carveouts and
>>> mailbox configuration to instantiate the cores successfully.
>>> Since this is a board level dependency, keep the R5 subsytem
>>> disabled at SoC dtsi, otherwise it results in probe errors like
>>> below during AM62P SK boot:
>>>
>>> r5fss@79000000: reserved memory init failed, ret = -22
>>> r5fss@79000000: k3_r5_cluster_rproc_init failed, ret = -22
>>> r5fss@78000000: reserved memory init failed, ret = -22
>>> r5fss@78000000: k3_r5_cluster_rproc_init failed, ret = -22
>>>
>>> Fixes: b5080c7c1f7e ("arm64: dts: ti: k3-am62p: Add nodes for more IPs")
>>>
>>> Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
>>
>> Reviewed-by: Jayesh Choudhary <j-choudhary@ti.com>
>>
>>> ---
>>>    arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi    | 2 ++
>>>    arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi | 1 +
>>>    2 files changed, 3 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi
>>> index c4b0b91d70cf..14eb9ba836d3 100644
>>> --- a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi
>>> +++ b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi
>>> @@ -187,6 +187,8 @@ mcu_r5fss0: r5fss@79000000 {
>>>    		ranges = <0x79000000 0x00 0x79000000 0x8000>,
>>>    			 <0x79020000 0x00 0x79020000 0x8000>;
>>>    		power-domains = <&k3_pds 7 TI_SCI_PD_EXCLUSIVE>;
>>> +		status = "disabled";
>>> +
>>>    		mcu_r5fss0_core0: r5f@79000000 {
>>>    			compatible = "ti,am62-r5f";
>>>    			reg = <0x79000000 0x00008000>,
>>> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
>>> index 19f42b39394e..10a7059b2d9b 100644
>>> --- a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
>>> +++ b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
>>> @@ -78,6 +78,7 @@ wkup_r5fss0: r5fss@78000000 {
>>>    		ranges = <0x78000000 0x00 0x78000000 0x8000>,
>>>    			 <0x78100000 0x00 0x78100000 0x8000>;
>>>    		power-domains = <&k3_pds 119 TI_SCI_PD_EXCLUSIVE>;
>>> +		status = "disabled";
> 
> Is there a reason for difference in white space addition?
> 

For mcu_r5fss0_core0 child node there was no blank line as per the 
recommended coding style : 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst#n124

So I added a newline there and wkup_r5fss0 already had it correct, since 
the change was trivial it was not mentioned in commit message.

Thanks and Regards,
Vaishnav

>>>    		wkup_r5fss0_core0: r5f@78000000 {
>>>    			compatible = "ti,am62-r5f";
>>
>> Thanks.
>