Received-SPF: pass (google.com: domain of linux-kernel+bounces-38072-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <699a33f7-2584-8d64-3a5c-668088f0dea4@nfschina.com>
Date: Thu, 25 Jan 2024 15:30:14 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] HID: hidraw: fix a problem of memory leak in
 hidraw_release()
Content-Language: en-US
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: jikos@kernel.org, benjamin.tissoires@redhat.com, mail@karthek.com,
 linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
 kernel-janitors@vger.kernel.org
From: Su Hui <suhui@nfschina.com>
In-Reply-To: <76300deb-f532-4d74-a97a-4cd321ae8f41@moroto.mountain>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 2024/1/25 15:11, Dan Carpenter wrote:
> On Thu, Jan 25, 2024 at 02:32:26PM +0800, Su Hui wrote:
>> 'struct hidraw_list' is a circular queue whose head can be smaller than
>> tail. Using 'list->tail != list->head' to release all memory that should
>> be released.
>>
>> Fixes: a5623a203cff ("HID: hidraw: fix memory leak in hidraw_release()")
>> Signed-off-by: Su Hui <suhui@nfschina.com>
> This is very clever.  How did you find that?  Was it through static
> analysis or just review?  Perhaps using syzkaller?
Hi,

I just met this bug on a real machine and found this problem by 
reviewing the code.

>
> Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
>
> I imagine we could write a checker heuristic to identify ->tail and
> ->head struct members and then complain if they were ever used in a <
> or > comparison.

I can't agree any more, great idea!

Su Hui