Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp1595936rdb; Wed, 24 Jan 2024 23:36:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IE7jXix6Nr0IjLErb6pnGLjTB5FU4z75MEMr9qW5R/ab7CM/lGMFz5eOQAy8eOOkMkVXqTi X-Received: by 2002:a17:907:934a:b0:a2b:f7d:5b5d with SMTP id bv10-20020a170907934a00b00a2b0f7d5b5dmr878703ejc.32.1706168172301; Wed, 24 Jan 2024 23:36:12 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706168172; cv=pass; d=google.com; s=arc-20160816; b=TSGWteOhSF5LHDeZlZwpmdELLuQPIKHIQY6/Ofabc0uapO8WWkHlXkrVa/J2ZV5+Ra /TosRWotqCB7LarmqK4+Hj36h47kNzqNvWIqPV1Nc4t/SiVrM12mS1B/XvRMUR6yAMkn SzWzNL2izYAD4brIalZJWjE9KpU65ABVx3LNByew9FxANzxNF90oGzVfusQk6Jx9fIIC uybg3H/X8ActwgDFfovS1QLbYrcLQLpmH1Zm3IBzfs4Jj1Hx+L9MI1XM+Eor3rhSdTwF O1eI5H/IyZjaC7l7oOputRqUxy0KkHCMdgwDlAcBU4AWN69namN+0cYF5RQk/cyZO303 RMEw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:references:message-id:in-reply-to:subject:cc:to:from :date:dkim-signature; bh=V/aHqeJimayZGVUBr100mVo3mSSjpxleSVu4AWAQJnY=; fh=7eZKrPTx3Zc2ITTawAN/XFGnFGmc28CcvTWXoZ3OK18=; b=v8D9DI33Kpn6s574ksPQ2ChyWOLp78tftWqvVmFESwv7xJs4cxSDCCAbS1stkmcPJm USlLBOnNQBFSsqqhf8/Yaq/ded2P3vwJmNPDr488vWQgw0STupfvxhdxZSLUhbb2FSxq MmuI5CZaTzvThx11kIqlTgRIUMrflrzcD2LKCWrDjTnZ2Xy/b49D2TK7EAqV1ueGoxYO VJboGp5svHvLXRvufbcCN6swGF7er+tzTFlj13L1RdTI6gh9cQ+cJov3zXq5vD7O1/1g YRv7ERRjCEiYPBT3oQgm1l1wXSr35J31jxU/cRXTetnrUWkkvPHmDBzN1GZdPu9BlbrT aIAQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=c+a7svVH; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-38078-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38078-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id fk5-20020a056402398500b0055c24634893si4829506edb.231.2024.01.24.23.36.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 23:36:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-38078-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=c+a7svVH; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-38078-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38078-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id D48C51F22654 for ; Thu, 25 Jan 2024 07:36:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6148912B6D; Thu, 25 Jan 2024 07:35:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="c+a7svVH" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88EBD125C2; Thu, 25 Jan 2024 07:35:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706168155; cv=none; b=OTeM8BZ4WeuZ4sgILoME3E5uybSDFzRmtbfcB/Rv+6yIzVfs1s8pZj5ys8c/1sK50BobB5jZ4Z1M7RZ1dKxDR6Ztm2iUHOqjdedymfbBB5H/Uy9Lm8n9VFtc9maDeMKKYCpxdJlLHA1t9dgtBahtmY86ch+FzaYoT7emE4nAU7Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706168155; c=relaxed/simple; bh=zHVsONx4KcOBxgGm9yVtdcWnYuuQg2lDfSnAQLPVhHg=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=bPobLuKPnt9RmSy3iVmXYRVmIchDMf9RG48Qm5JkwtyyNdmzChtL7g7oYpgUSZLzIzncxNCZE0D0bnCFyIHletV4ZXCvYVsGZM8/DyEts47nG2cTP+WiiEN3f3/Ft/dAd49zACOleJPs0+pjLo5zIS1OIE6NUdOBNmMIMLNGEME= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=c+a7svVH; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4D80C433C7; Thu, 25 Jan 2024 07:35:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706168155; bh=zHVsONx4KcOBxgGm9yVtdcWnYuuQg2lDfSnAQLPVhHg=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=c+a7svVHLRMoQtYwbDDUroi+Mo/iXrsJP8O86Mh5iZhygqFCB3ORQ9OdmiCHhwq10 FMnD/5zDrEN9MiBUhEILwTZjKcI4j7lGR8KKLpGQVfTwoFk8v/afz3iJoxLAeCfOVI YlTzAMOoNur3F1xYemVnvwIwIaIOKoJRnzRcw/1ioNPXnGH2k5WEmg1Gny2O3///CA SH7WDkQvEBhowBcg+jqPsFq8fC7IqCR9VhVpZ8u/NLb3Eus1V/xagDF72bxB+0wIMV bkFb9EYohfSfFa1kg8szc/DOfSIsGjrKtRlc1F9vvPHUt+bXsXHFvbGetQvNwU/2uL oNiewCrIgF51A== Date: Thu, 25 Jan 2024 08:35:55 +0100 (CET) From: Jiri Kosina To: Su Hui cc: benjamin.tissoires@redhat.com, mail@karthek.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] HID: hidraw: fix a problem of memory leak in hidraw_release() In-Reply-To: <20240125063225.2796234-1-suhui@nfschina.com> Message-ID: References: <20240125063225.2796234-1-suhui@nfschina.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 25 Jan 2024, Su Hui wrote: > 'struct hidraw_list' is a circular queue whose head can be smaller than > tail. Using 'list->tail != list->head' to release all memory that should > be released. > > Fixes: a5623a203cff ("HID: hidraw: fix memory leak in hidraw_release()") > Signed-off-by: Su Hui Good catch, thanks. Applied. -- Jiri Kosina SUSE Labs