Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp1596761rdb; Wed, 24 Jan 2024 23:38:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IHt4uJUsiil8gggYv/h2d2pJ5LQzlOlxv8dl5JwetyuQzV9OSJVxgZtYfgduIYenFg9vCl7 X-Received: by 2002:a05:6214:b64:b0:681:972:a252 with SMTP id ey4-20020a0562140b6400b006810972a252mr834770qvb.80.1706168332833; Wed, 24 Jan 2024 23:38:52 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706168332; cv=pass; d=google.com; s=arc-20160816; b=ZMLrLuDFvCDDyy6GXmI79g8vzxzn391JvjynV2anfRo0mVNk5SbkuuNrGAVwHObrXR gIJCb2q2DSBr3Nx6CNqYXhdzVF5sdyGo6Y96+9NnfJTq1HbJNz4galJg8vae9THlSnL8 +tKQUQPCDoeNgEzhZ2+VCu+omP139BBLGKJAHlAD0L/naZdXWxEMaBVeCTaUp1Q8H0+c QtJZS0OUFg2Uk8BXgdbb8U9LcSm7RTdUHMylD3K/wk1ydenaI3ivtJMDZCfEyRh01gi4 UJ3kAf2glNBxMmL6RlA/13rBxxrFu7+2CmffXr41HMifUhdEZwYSZ5MGlS528MMwSZbo fF2w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=7LCevDc/sxasNxhfnH5r6nXM7hArveRxnxy8zo0LTcA=; fh=Us/DORbzHj5XmgnBeJW+VlCBdo2pSXKHAejHonylCvY=; b=B8B3LRnqcYT+stZqpLa4rAcsQiLvvuTkYnY0p0FxLBFzLj8oTKDa7D/yJVA0QhtUyN hQV0elExmXD1LwXqmT/M9Dn0mNVTlIuKkg4HerKp9tOXwBRG+7Uvo7WI8hFlbFwiEuMl GA2IoyQNex1rW+5eGBa9EChlujX/WjO4ISstgYKtUkU9UoC6aOasOgGDkMwpO5w4Kmk+ pdc6lio/z6W9mXN+EOAkUT9y0xvA0WnbLBvPkeJZXwU3G83C7nCQ/xmQFg/jxKOacAuc K47h7s4PfYKjRBOSZMCrS/RwL384pxVf30UpW9la2az8HFZuZW18v23NDqWoRdg6hPhm i7BQ== ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=huawei.com dmarc=pass fromdomain=huawei.com); spf=pass (google.com: domain of linux-kernel+bounces-38082-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38082-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id f2-20020a0ccc82000000b006819712c52asi12428588qvl.474.2024.01.24.23.38.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 23:38:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-38082-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=huawei.com dmarc=pass fromdomain=huawei.com); spf=pass (google.com: domain of linux-kernel+bounces-38082-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38082-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 942871C21574 for ; Thu, 25 Jan 2024 07:38:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6467A12B7F; Thu, 25 Jan 2024 07:38:49 +0000 (UTC) Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BD5C12B66; Thu, 25 Jan 2024 07:38:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.35 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706168328; cv=none; b=npt1i9MCrKQsmf8iSQ0T7PxxYzq5GL8wZ8iOegunGs+EhLEixr06rSs8exrtjO0zLCDfhlUVoyBX6FcRJEbNnG60RhCXhNZu9ZL+Zsg5Q2kt4gUOhrGHocoBRYDC6s3xJwkCLXPUpssmpmXlFTZOY9vh/Bpw4whnKHKMUcIEmXU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706168328; c=relaxed/simple; bh=M/cXM+bzz+FgkUlXZ4uVPd0XapBvnJkUwgDAbNphc/g=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=g9GM7MsXMeKJUD6trm10Rn5rDBbI+ocgFG79o6fQeNZo2dCFhtLfA1zmtxoo0E8yHYTj1/A1ZbsUjzvGm1DmO8Rj0qWHNSFXK2fPIUHV/GjrVY9UemafzO4Drw+m4c2WAW9KS3B6UHVAXE+unA8+gdFambActywtdmJ5DZL7k+o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=45.249.212.35 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.19.162.112]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4TLCMG1ZW8z1Q8Cm; Thu, 25 Jan 2024 15:36:58 +0800 (CST) Received: from canpemm500010.china.huawei.com (unknown [7.192.105.118]) by mail.maildlp.com (Postfix) with ESMTPS id 98E1D14011B; Thu, 25 Jan 2024 15:38:28 +0800 (CST) Received: from huawei.com (10.175.127.227) by canpemm500010.china.huawei.com (7.192.105.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 25 Jan 2024 15:36:50 +0800 From: Ye Bin To: , , , CC: , Subject: [PATCH v5 0/8] support '%pd' and '%pD' for print file name Date: Thu, 25 Jan 2024 15:39:15 +0800 Message-ID: <20240125073923.2252057-1-yebin10@huawei.com> X-Mailer: git-send-email 2.31.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To canpemm500010.china.huawei.com (7.192.105.118) During fault locating, the file name needs to be printed based on the dentry/file address. The offset needs to be calculated each time, which is troublesome. Similar to printk, kprobe supports printing file names for dentry/file addresses. Diff v5 vs v4: 1. Use glob_match() instead of str_has_suffix(), so remove the first patch; 2. Allocate buffer from heap for expand dentry; 3. Support "%pd/%pD" print type for fprobe; 4. Use $arg1 instead of origin register in test case; 5. Add test case for fprobe; Diff v4 vs v3: 1. Use "argv[i][idx + 3] == 'd'" instead of "argv[i][strlen(argv[i]) - 1] == 'd'" to judge print format in PATCH[4/7]; Diff v3 vs v2: 1. Return the index of where the suffix was found in str_has_suffix(); Diff v2 vs v1: 1. Use "%pd/%pD" print format instead of "pd/pD" print format; 2. Add "%pd/%pD" in README; 3. Expand "%pd/%pD" argument before parameter parsing; 4. Add more detail information in ftrace documentation; 5. Add test cases for new print format in selftests/ftrace; Ye Bin (8): tracing/probes: add traceprobe_expand_dentry_args() helper tracing/probes: support '%pd' type for print struct dentry's name tracing/probes: support '%pD' type for print struct file's name tracing/probes: support '%pd/%pD' type for fprobe tracing: add new type "%pd/%pD" in readme_msg[] Documentation: tracing: add new type '%pd' and '%pD' for kprobe selftests/ftrace: add kprobe test cases for VFS type "%pd" and "%pD" selftests/ftrace: add fprobe test cases for VFS type "%pd" and "%pD" Documentation/trace/kprobetrace.rst | 8 ++- kernel/trace/trace.c | 2 +- kernel/trace/trace_fprobe.c | 6 ++ kernel/trace/trace_kprobe.c | 6 ++ kernel/trace/trace_probe.c | 63 +++++++++++++++++++ kernel/trace/trace_probe.h | 2 + .../ftrace/test.d/dynevent/fprobe_args_vfs.tc | 40 ++++++++++++ .../ftrace/test.d/kprobe/kprobe_args_vfs.tc | 43 +++++++++++++ 8 files changed, 167 insertions(+), 3 deletions(-) create mode 100644 tools/testing/selftests/ftrace/test.d/dynevent/fprobe_args_vfs.tc create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_vfs.tc -- 2.31.1