Received-SPF: pass (google.com: domain of linux-kernel+bounces-38158-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <0cc62f04-ce60-42ed-89c9-ce8b1ce26ce7@kylinos.cn>
Date: Thu, 25 Jan 2024 16:20:59 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] powerpc/iommu: Code cleanup for cell/iommu.c
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
 "arnd@arndb.de" <arnd@arndb.de>, "mpe@ellerman.id.au" <mpe@ellerman.id.au>,
 "npiggin@gmail.com" <npiggin@gmail.com>,
 "aneesh.kumar@kernel.org" <aneesh.kumar@kernel.org>,
 "naveen.n.rao@linux.ibm.com" <naveen.n.rao@linux.ibm.com>
Cc: "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20240125024633.512513-1-chentao@kylinos.cn>
 <7cdfcfc3-fc9e-433d-8992-7782d641cb94@csgroup.eu>
Content-Language: en-US
From: Kunwu Chan <chentao@kylinos.cn>
In-Reply-To: <7cdfcfc3-fc9e-433d-8992-7782d641cb94@csgroup.eu>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 2024/1/25 14:49, Christophe Leroy wrote:
>=20
>=20
> Le 25/01/2024 =C3=A0 03:46, Kunwu Chan a =C3=A9crit=C2=A0:
>> This part was commented from commit 165785e5c0be ("[POWERPC] Cell
>> iommu support") in about 17 years before.
>>
>> If there are no plans to enable this part code in the future,
>> we can remove this dead code.
>>
>> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
>> ---
>>    arch/powerpc/platforms/cell/iommu.c | 16 ----------------
>>    1 file changed, 16 deletions(-)
>>
>> diff --git a/arch/powerpc/platforms/cell/iommu.c b/arch/powerpc/platfo=
rms/cell/iommu.c
>> index 1202a69b0a20..afce9e64a443 100644
>> --- a/arch/powerpc/platforms/cell/iommu.c
>> +++ b/arch/powerpc/platforms/cell/iommu.c
>> @@ -424,22 +424,6 @@ static void __init cell_iommu_setup_hardware(stru=
ct cbe_iommu *iommu,
>>    	cell_iommu_enable_hardware(iommu);
>>    }
>>   =20
>> -#if 0/* Unused for now */
>> -static struct iommu_window *find_window(struct cbe_iommu *iommu,
>> -		unsigned long offset, unsigned long size)
>> -{
>> -	struct iommu_window *window;
>> -
>> -	/* todo: check for overlapping (but not equal) windows) */
>> -
>> -	list_for_each_entry(window, &(iommu->windows), list) {
>> -		if (window->offset =3D=3D offset && window->size =3D=3D size)
>> -			return window;
>> -	}
>> -
>> -	return NULL;
>> -}
>> -#endif
>=20
> Same as the other one, please remove the second blank line, don't leave
> two blank lines between the remaining functions.
Thanks for your reply.

I'll check my patches and update in v2.

>=20
>>   =20
>>    static inline u32 cell_iommu_get_ioid(struct device_node *np)
>>    {
--=20
Thanks,
   Kunwu