Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp1618855rdb; Thu, 25 Jan 2024 00:36:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IFv0GffIx7LywdvV8k1Vpw1mgWdVAu67oKgn9w2qm3xg/bMwTskBzbVbjvRILCGV1ArfPJp X-Received: by 2002:a05:620a:4481:b0:783:7924:296d with SMTP id x1-20020a05620a448100b007837924296dmr1049645qkp.90.1706171797331; Thu, 25 Jan 2024 00:36:37 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706171797; cv=pass; d=google.com; s=arc-20160816; b=1HErNjHh6yk6oni+5XL06v/231/z3gz2NDvYr3ppwHOGBkKzWGyxLKlRvcMpHaqHou lDwAFvwfBX3NNMOK8L287emJ/gSwwunYRfOAxFnApXtezuzJufzAIIuKtYn1AnTFol1a d7iTxvKHLGkYmmtAK2yrTqTFj/KKN/1sdSo3OS7nuLnKnbg5/sEXLONQwACPFrPLkvzZ 9BA6SAJWwQ2aaI0fcLGbhbGk/2maWa/XD+AVSMZ+FOVY+84UPIOhLWtce5sWp/jsid/S EdigTyzx7wapJq9NpBqo4oc6k/0vd8vY/8hJGZa5Zr2sJrbIQCMPpDg7LaX1Vtemeu2c sMZg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id; bh=hBzmADRTWsMDykqHddaELyHZLER6oyf5g/1GSx10dic=; fh=MsDrVyrYwpgYSBsy1G8b1U5Aaf8Y69X0y1bhZSp5CrA=; b=rpsdjJWKZOrmUH5ml6P2qU76Fl2CDCJKH1vcYF/2XJPXWC9YczyV+CeAr7RDcfM7U5 XxJS5m2IcjWeEaV404yxgha9i2uevhprqNmxljBYtQhb1ZrWJcF1uerfG3aW1juWYRC1 LsyQdyWXEh/GAwWuMC8U3B529qFgC9u9rlkAv0wfsNrlxWlKxXc5iU3NGUfCXslAmx1V Ah9MbP/CuSnoyjvhLwkyrf85U/5m5UFRsXBDuS80ixdPVm6+kIVikUCE+LHGB8qKOh0P C/Ck9vYORdBYnEfuZE9yNEiT6+bthQu+4E+8AKz8xnjRPTuAgQGpM2MiZJED0N1aJW+i Kl6Q== ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=kylinos.cn); spf=pass (google.com: domain of linux-kernel+bounces-38183-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38183-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id p7-20020a05620a22a700b007837e9e6f93si11789094qkh.612.2024.01.25.00.36.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 00:36:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-38183-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=kylinos.cn); spf=pass (google.com: domain of linux-kernel+bounces-38183-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38183-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 1B3E01C23D36 for ; Thu, 25 Jan 2024 08:36:37 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E3ED41B959; Thu, 25 Jan 2024 08:36:26 +0000 (UTC) Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 414AA12E4A; Thu, 25 Jan 2024 08:36:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706171786; cv=none; b=B40SPXY2rNUqRMC8QClxFtI6x/M7ci1yhVCUxq1d4uUlNOYTsb1DYfma+tXZSl7kSD/qlWNUPDRmNk+B+XGwLDhQHZRQ9NpYsFtUVGAH7HcyJEraBezRtPT9HNfYg99YsLbAB4F+qw5ON8A95bW1ieX6C7aeWn1GYbJadMoccCA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706171786; c=relaxed/simple; bh=OBgQP1LWDaesd2nRxTRT92PCCumz7hyFXJpJ6nvMyMg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=j24VFFBOXL7BPyBMAzRHWpYHY8d9ywk1nP4skjv1ZAmK9H2QJP2/1Ht6B+o8t/Kzr3RuFD3bEEZE/EbKR86Gb/wRz6wk4/p4WIzQFL3gVcKrFoJAD86UFHJyZq+n4aWakg6kCJLlIKO8dnIVQrPt1gnDQdtXlMTpakAfUsiLhqE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 0b9114c47c944f3395e17bb8743a5543-20240125 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.35,REQID:70a3d77d-bc90-44e0-b09b-26ae8d961c29,IP:10, URL:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTI ON:release,TS:-5 X-CID-INFO: VERSION:1.1.35,REQID:70a3d77d-bc90-44e0-b09b-26ae8d961c29,IP:10,UR L:0,TC:0,Content:0,EDM:0,RT:0,SF:-15,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:-5 X-CID-META: VersionHash:5d391d7,CLOUDID:f443a58e-e2c0-40b0-a8fe-7c7e47299109,B ulkID:240124210134Y4FPAFV7,BulkQuantity:5,Recheck:0,SF:66|38|24|17|19|44|6 4|102,TC:nil,Content:0,EDM:-3,IP:-2,URL:1,File:nil,Bulk:40,QS:nil,BEC:nil, COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0,NGT X-CID-BAS: 0,NGT,0,_ X-CID-FACTOR: TF_CID_SPAM_FSI,TF_CID_SPAM_ULS,TF_CID_SPAM_SNR,TF_CID_SPAM_FAS, TF_CID_SPAM_FSD X-UUID: 0b9114c47c944f3395e17bb8743a5543-20240125 Received: from mail.kylinos.cn [(39.156.73.10)] by mailgw (envelope-from ) (Generic MTA) with ESMTP id 392365939; Thu, 25 Jan 2024 16:36:17 +0800 Received: from mail.kylinos.cn (localhost [127.0.0.1]) by mail.kylinos.cn (NSMail) with SMTP id 96B42E000EB9; Thu, 25 Jan 2024 16:36:17 +0800 (CST) X-ns-mid: postfix-65B21D81-548321494 Received: from [172.20.15.234] (unknown [172.20.15.234]) by mail.kylinos.cn (NSMail) with ESMTPA id 080AFE000EBA; Thu, 25 Jan 2024 16:36:16 +0800 (CST) Message-ID: Date: Thu, 25 Jan 2024 16:36:16 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] KVM: PPC: code cleanup for kvmppc_book3s_irqprio_deliver Content-Language: en-US To: Christophe Leroy , "mpe@ellerman.id.au" , "npiggin@gmail.com" , "aneesh.kumar@kernel.org" , "naveen.n.rao@linux.ibm.com" Cc: "linuxppc-dev@lists.ozlabs.org" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20240124093647.479176-1-chentao@kylinos.cn> <91bfb613-222b-41ea-a049-d4252b655176@csgroup.eu> From: Kunwu Chan In-Reply-To: <91bfb613-222b-41ea-a049-d4252b655176@csgroup.eu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 2024/1/24 21:01, Christophe Leroy wrote: >=20 >=20 > Le 24/01/2024 =C3=A0 10:36, Kunwu Chan a =C3=A9crit=C2=A0: >> This part was commented from commit 2f4cf5e42d13 ("Add book3s.c") >> in about 14 years before. >> If there are no plans to enable this part code in the future, >> we can remove this dead code. >> >> Signed-off-by: Kunwu Chan >> --- >> arch/powerpc/kvm/book3s.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/arch/powerpc/kvm/book3s.c b/arch/powerpc/kvm/book3s.c >> index 8acec144120e..c2f50e04eec8 100644 >> --- a/arch/powerpc/kvm/book3s.c >> +++ b/arch/powerpc/kvm/book3s.c >> @@ -360,9 +360,6 @@ static int kvmppc_book3s_irqprio_deliver(struct kv= m_vcpu *vcpu, >> break; >> } >> =20 >> -#if 0 >> - printk(KERN_INFO "Deliver interrupt 0x%x? %x\n", vec, deliver); >> -#endif >=20 > Please also remove one of the two blank lines. Thanks for your reply. I've send the v2 patch: https://lore.kernel.org/all/20240125082637.532826-1-chentao@kylinos.cn/ https://lore.kernel.org/all/20240125083348.533883-1-chentao@kylinos.cn/ >> =20 >> if (deliver) >> kvmppc_inject_interrupt(vcpu, vec, 0); --=20 Thanks, Kunwu