Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp1620533rdb; Thu, 25 Jan 2024 00:41:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IFMablz5TWYcj8Q7fajGJVbrlDdbZ/4gcVI1XjoWZTEv0iIENHxv+4I9+ulUnlqd9hr3U+V X-Received: by 2002:a05:6214:2602:b0:681:77a6:59ed with SMTP id gu2-20020a056214260200b0068177a659edmr687310qvb.37.1706172086118; Thu, 25 Jan 2024 00:41:26 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706172086; cv=pass; d=google.com; s=arc-20160816; b=wRsPUB1pzn8Z4tyq6OpM+yDhrpXcpKAUVpIPJdhepwMAq/XGLlw7rHRA3WHzyjDVTh 8vaRaBeZwx1lxe1xobV9lD36LRgl/qvv5xGPU6Rlys0xYYUnqhZogaZkhc9Dl2bi24du c4FXpQb1OfVwUMpX5aiJSxLqKA/ibzDEjmUV0P8X7mwAez3sQnGOgf9NbxfaZ5tdQchU JiMRczMYGqhdWc/GhvPnY8vtxJ2xUDN6YtCTn5cI505+vT3SFxmtynON9Gl5IbR4C46X wmj9SA+svndB1fz28XEcVpt0FbJHhepltyHhCGHaPiWXUXWGbqZTcFFdxfH/kAqrQKw9 W3yQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:content-transfer-encoding:autocrypt:references :in-reply-to:date:to:from:subject:message-id:dkim-signature; bh=uaw2OQxOj/iJ0FDVCczkm669hzJBFI58+e9xoVccMms=; fh=c5cy9fecVnbnwO3i7T0jyqSWdVc86RiI922smP4GWMk=; b=D8PZJpGgi29OaO1uZFo4lNeY9RsdgKI22jVx3zymJWiK855W1UgFtMuO8tO1EMY7jR 7w7SUYDQnvBC+2n28fBpZtNunQmXXdBGmWtaoGSX4KRndnUZHSiaXHmMnzSPIGu9KOsA Qk4b03oBg2VlRV7/zd1YCIJpajEiO+yVP6tCi8b+F4UhK/B+KLMB99C4rIQED1J8/22U 94S/I8MoTCfdLBj/FU3dmiGu19j5LRL430Ae1ME00xpj/d/zqUgBH8co570DMn83sEvv 0SASdDPpa/DfxUl0Vs2ieE5CQtXlffGLRTSeOltsvtDXTaKlMTl6ErbGFTGi8N6AtUTP Qnjw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="JuvXD19/"; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-38186-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38186-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id j12-20020a0c9ccc000000b006869f9ae55fsi4275373qvf.146.2024.01.25.00.41.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 00:41:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-38186-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="JuvXD19/"; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-38186-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38186-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id B7F091C21B10 for ; Thu, 25 Jan 2024 08:41:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 33AA21B95B; Thu, 25 Jan 2024 08:41:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JuvXD19/" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9813B17BCB for ; Thu, 25 Jan 2024 08:41:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706172073; cv=none; b=TjGrhlDMxbTsXVqXrgUMa80kpo2u771IIliUxfkPUqRFA1DKtRhzrKKm+jCoRRkbIkya9WvlChbBtr7tcaHwJF+tRb8ccW5W1zgKUIG3es/eTzI2qDqJ6Ugyb2N8AvXNEagOuqNoHSYVQ/tjwTol9m8Eje9OfFT7mUQolF8rGOI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706172073; c=relaxed/simple; bh=uaw2OQxOj/iJ0FDVCczkm669hzJBFI58+e9xoVccMms=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References: Content-Type:MIME-Version; b=gv1BYbbBFqo53P7bzQjJSphxlKsXUMywx2pYR7AN78acr8vtzh7G047vEc89xvhgpJGs764GS73Wd4x9eX7szoclQug4YW3k8ddR4MtFYU7PxNr6ecPv4s23/BicnIFF4kkkJZhHRAuaT5diK18r5SnytVV5O881Jxx+BbLEzWc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JuvXD19/; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706172069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=uaw2OQxOj/iJ0FDVCczkm669hzJBFI58+e9xoVccMms=; b=JuvXD19/IzER7z2WT7ZySt0KmFha5XKjHOLWJDw4H2bvSgJJrA1XgIovkedMtkC/GkEKud jv8lmp+y1fG8CrFrzI6QqyYAudHSVcHBODNy1eUtgH3MxQ4Z0AJ9UbPJc8g+GYDgur/gJ5 htDYegcsRxbbYwBgH0UhW43/Piz8Jwg= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-329--hERTBWMP5SrYqyFQMDMog-1; Thu, 25 Jan 2024 03:41:08 -0500 X-MC-Unique: -hERTBWMP5SrYqyFQMDMog-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3393b54f33aso77517f8f.1 for ; Thu, 25 Jan 2024 00:41:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706172067; x=1706776867; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uaw2OQxOj/iJ0FDVCczkm669hzJBFI58+e9xoVccMms=; b=CPyps/K5BoFK9EbRgGAKqMfHlFjAI1xX7hGNwLvrFBWJi66xcuxhlf9jL1sWs23lSk dfW6/z+MvHyD4WL7D7X1TlzkF8Q1Xq4KTgxD6s6A7UXNMvGb98G/fHd66MTTb0XiRQq4 xh8vhYMatp27vkcSovrYXxML5jg0s9dCQa3AwmfeI5BlNEQPHYzaK6tD0Hsgt7XRvViX l8ZCyurT9cWpRMLvM3qHxiUHkbWVloTWkoilKjaIkousGu3UbSShzc+h0QszoVhzzjRd eeVZZsh1wkkEhrnnDyscftGhA/0ooC7wdyW9qrAvTaBLTbSnez7gsaYSTIiWOg2k5IRn YKCw== X-Forwarded-Encrypted: i=0; AJvYcCUs308tBrGEe2oylTAroTi01tf1dm4kN8CUfF5q6bZ3tpn5Tk57HL8Wkd+0ezBv/5AztiN5VbcRvfn3AQXzCfCzUDwBkBEaDxd5DK9x X-Gm-Message-State: AOJu0Yw/NE/tB0oWvcOYQ796dU/BqzXzwLY/h3f/2b4zA/QVpv+W+E27 +WU2cO+XaMh9yerfGBmP+29cQSOZjC16VkuwsWFuU61JywvLFUYPXoQrfgzzW9oKHAaFyCGQqOV OCGuef6rOd7g4Xd5g+aVDFzvXeuAXjDjtK+AXY4QaqMu0v7euiEgty1V48qDWDeNwCyMzzw== X-Received: by 2002:adf:a1dd:0:b0:337:cf8c:af59 with SMTP id v29-20020adfa1dd000000b00337cf8caf59mr661355wrv.1.1706172066742; Thu, 25 Jan 2024 00:41:06 -0800 (PST) X-Received: by 2002:adf:a1dd:0:b0:337:cf8c:af59 with SMTP id v29-20020adfa1dd000000b00337cf8caf59mr661340wrv.1.1706172066350; Thu, 25 Jan 2024 00:41:06 -0800 (PST) Received: from gerbillo.redhat.com (146-241-244-75.dyn.eolo.it. [146.241.244.75]) by smtp.gmail.com with ESMTPSA id d21-20020adfa355000000b003392a486758sm12793418wrb.99.2024.01.25.00.41.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 00:41:05 -0800 (PST) Message-ID: Subject: Re: [PATCH] ipv6: Ensure natural alignment of const ipv6 loopback and router addresses From: Paolo Abeni To: Helge Deller , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org Date: Thu, 25 Jan 2024 09:41:04 +0100 In-Reply-To: References: Autocrypt: addr=pabeni@redhat.com; prefer-encrypt=mutual; keydata=mQINBGISiDUBEAC5uMdJicjm3ZlWQJG4u2EU1EhWUSx8IZLUTmEE8zmjPJFSYDcjtfGcbzLPb63BvX7FADmTOkO7gwtDgm501XnQaZgBUnCOUT8qv5MkKsFH20h1XJyqjPeGM55YFAXc+a4WD0YyO5M0+KhDeRLoildeRna1ey944VlZ6Inf67zMYw9vfE5XozBtytFIrRyGEWkQwkjaYhr1cGM8ia24QQVQid3P7SPkR78kJmrT32sGk+TdR4YnZzBvVaojX4AroZrrAQVdOLQWR+w4w1mONfJvahNdjq73tKv51nIpu4SAC1Zmnm3x4u9r22mbMDr0uWqDqwhsvkanYmn4umDKc1ZkBnDIbbumd40x9CKgG6ogVlLYeJa9WyfVMOHDF6f0wRjFjxVoPO6p/ZDkuEa67KCpJnXNYipLJ3MYhdKWBZw0xc3LKiKc+nMfQlo76T/qHMDfRMaMhk+L8gWc3ZlRQFG0/Pd1pdQEiRuvfM5DUXDo/YOZLV0NfRFU9SmtIPhbdm9cV8Hf8mUwubihiJB/9zPvVq8xfiVbdT0sPzBtxW0fXwrbFxYAOFvT0UC2MjlIsukjmXOUJtdZqBE3v3Jf7VnjNVj9P58+MOx9iYo8jl3fNd7biyQWdPDfYk9ncK8km4skfZQIoUVqrWqGDJjHO1W9CQLAxkfOeHrmG29PK9tHIwARAQABtB9QYW9sbyBBYmVuaSA8cGFiZW5pQHJlZGhhdC5jb20+iQJSBBMBCAA8FiEEg1AjqC77wbdLX2LbKSR5jcyPE6QFAmISiDUCGwMFCwkIBwIDIgIBBhUKCQgLAgQWAgMBAh4HAheAAAoJECkkeY3MjxOkJSYQAJcc6MTsuFxYdYZkeWjW//zbD3ApRHzpNlHLVSuJqHr9/aDS+tyszgS8jj9MiqALzgq4iZbg 7ZxN9ZsDL38qVIuFkSpgMZCiUHdxBC11J8nbBSLlpnc924UAyr5XrGA99 6Wl5I4Km3128GY6iAkH54pZpOmpoUyBjcxbJWHstzmvyiXrjA2sMzYjt3Xkqp0cJfIEekOi75wnNPofEEJg28XPcFrpkMUFFvB4Aqrdc2yyR8Y36rbw18sIX3dJdomIP3dL7LoJi9mfUKOnr86Z0xltgcLPGYoCiUZMlXyWgB2IPmmcMP2jLJrusICjZxLYJJLofEjznAJSUEwB/3rlvFrSYvkKkVmfnfro5XEr5nStVTECxfy7RTtltwih85LlZEHP8eJWMUDj3P4Q9CWNgz2pWr1t68QuPHWaA+PrXyasDlcRpRXHZCOcvsKhAaCOG8TzCrutOZ5NxdfXTe3f1jVIEab7lNgr+7HiNVS+UPRzmvBc73DAyToKQBn9kC4jh9HoWyYTepjdcxnio0crmara+/HEyRZDQeOzSexf85I4dwxcdPKXv0fmLtxrN57Ae82bHuRlfeTuDG3x3vl/Bjx4O7Lb+oN2BLTmgpYq7V1WJPUwikZg8M+nvDNcsOoWGbU417PbHHn3N7yS0lLGoCCWyrK1OY0QM4EVsL3TjOfUtCNQYW9sbyBBYmVuaSA8cGFvbG8uYWJlbmlAZ21haWwuY29tPokCUgQTAQgAPBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEoitAhsDBQsJCAcCAyICAQYVCgkICwIEFgIDAQIeBwIXgAAKCRApJHmNzI8TpBzHD/45pUctaCnhee1vkQnmStAYvHmwrWwIEH1lzDMDCpJQHTUQOOJWDAZOFnE/67bxSS81Wie0OKW2jvg1ylmpBA0gPpnzIExQmfP72cQ1TBoeVColVT6Io35BINn+ymM7c0Bn8RvngSEpr3jBtqvvWXjvtnJ5/HbOVQCg62NC6ewosoKJPWpGXMJ9SKsVIOUHsmoWK60spzeiJoSmAwm3zTJQnM5kRh2q iWjoCy8L35zPqR5TV+f5WR5hTVCqmLHSgm1jxwKhPg9L+GfuE4d0SWd84y GeOB3sSxlhWsuTj1K6K3MO9srD9hr0puqjO9sAizd0BJP8ucf/AACfrgmzIqZXCfVS7jJ/M+0ic+j1Si3yY8wYPEi3dvbVC0zsoGj9n1R7B7L9c3g1pZ4L9ui428vnPiMnDN3jh9OsdaXeWLvSvTylYvw9q0DEXVQTv4/OkcoMrfEkfbXbtZ3PRlAiddSZA5BDEkkm6P9KA2YAuooi1OD9d4MW8LFAeEicvHG+TPO6jtKTacdXDRe611EfRwTjBs19HmabSUfFcumL6BlVyceIoSqXFe5jOfGpbBevTZtg4kTSHqymGb6ra6sKs+/9aJiONs5NXY7iacZ55qG3Ib1cpQTps9bQILnqpwL2VTaH9TPGWwMY3Nc2VEc08zsLrXnA/yZKqZ1YzSY9MGXWYLkCDQRiEog1ARAAyXMKL+x1lDvLZVQjSUIVlaWswc0nV5y2EzBdbdZZCP3ysGC+s+n7xtq0o1wOvSvaG9h5q7sYZs+AKbuUbeZPu0bPWKoO02i00yVoSgWnEqDbyNeiSW+vI+VdiXITV83lG6pS+pAoTZlRROkpb5xo0gQ5ZeYok8MrkEmJbsPjdoKUJDBFTwrRnaDOfb+Qx1D22PlAZpdKiNtwbNZWiwEQFm6mHkIVSTUe2zSemoqYX4QQRvbmuMyPIbwbdNWlItukjHsffuPivLF/XsI1gDV67S1cVnQbBgrpFDxN62USwewXkNl+ndwa+15wgJFyq4Sd+RSMTPDzDQPFovyDfA/jxN2SK1Lizam6o+LBmvhIxwZOfdYH8bdYCoSpqcKLJVG3qVcTwbhGJr3kpRcBRz39Ml6iZhJyI3pEoX3bJTlR5Pr1Kjpx13qGydSMos94CIYWAKhegI06aTdvvuiigBwjngo/Rk5S+iEGR5KmTqGyp27o6YxZy6D4NIc6PKUzhIUxfvuHNvfu sD2W1U7eyLdm/jCgticGDsRtweytsgCSYfbz0gdgUuL3EBYN3JLbAU+UZpy v/fyD4cHDWaizNy/KmOI6FFjvVh4LRCpGTGDVPHsQXaqvzUybaMb7HSfmBBzZqqfVbq9n5FqPjAgD2lJ0rkzb9XnVXHgr6bmMRlaTlBMAEQEAAYkCNgQYAQgAIBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEog1AhsMAAoJECkkeY3MjxOkY1YQAKdGjHyIdOWSjM8DPLdGJaPgJdugHZowaoyCxffilMGXqc8axBtmYjUIoXurpl+f+a7S0tQhXjGUt09zKlNXxGcebL5TEPFqgJTHN/77ayLslMTtZVYHE2FiIxkvW48yDjZUlefmphGpfpoXe4nRBNto1mMB9Pb9vR47EjNBZCtWWbwJTIEUwHP2Z5fV9nMx9Zw2BhwrfnODnzI8xRWVqk7/5R+FJvl7s3nY4F+svKGD9QHYmxfd8Gx42PZc/qkeCjUORaOf1fsYyChTtJI4iNm6iWbD9HK5LTMzwl0n0lL7CEsBsCJ97i2swm1DQiY1ZJ95G2Nz5PjNRSiymIw9/neTvUT8VJJhzRl3Nb/EmO/qeahfiG7zTpqSn2dEl+AwbcwQrbAhTPzuHIcoLZYV0xDWzAibUnn7pSrQKja+b8kHD9WF+m7dPlRVY7soqEYXylyCOXr5516upH8vVBmqweCIxXSWqPAhQq8d3hB/Ww2A0H0PBTN1REVw8pRLNApEA7C2nX6RW0XmA53PIQvAP0EAakWsqHoKZ5WdpeOcH9iVlUQhRgemQSkhfNaP9LqR1XKujlTuUTpoyT3xwAzkmSxN1nABoutHEO/N87fpIbpbZaIdinF7b9srwUvDOKsywfs5HMiUZhLKoZzCcU/AEFjQsPTATACGsWf3JYPnWxL9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.3 (3.50.3-1.fc39) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2024-01-22 at 22:27 +0100, Helge Deller wrote: > On a parisc64 kernel I notice sometimes this kernel warning: > Kernel unaligned access to 0x40ff8814 at ndisc_send_skb+0xc0/0x4d8 >=20 > The address 0x40ff8814 points to the in6addr_linklocal_allrouters > variable and the warning simply means that some ipv6 function tries to > read a 64-bit word directly from the not-64-bit aligned > in6addr_linklocal_allrouters variable. >=20 > The patch below ensures that those ipv6 loopback and router addresses > always will be naturally aligned and as such prevents unaligned accesses > for all architectures. >=20 > Signed-off-by: Helge Deller The patch LGTM, but the above looks like material for the 'net' tree, would you mind sending a v2 including a relevant fixes tag, the target tree in the subject prefix and possibly the stacktrace you observe? Feel free to include my acked-by tag in v2. Thanks, Paolo