Received-SPF: pass (google.com: domain of linux-kernel+bounces-38188-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 25 Jan 2024 09:43:02 +0100
From: Michael Tretter <m.tretter@pengutronix.de>
To: Bo Liu <liubo03@inspur.com>
Cc: kernel@pengutronix.de, mchehab@kernel.org, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: i2c: isl7998x: convert to use maple tree register
 cache
Message-ID: <20240125084302.GA383229@pengutronix.de>
Mail-Followup-To: Michael Tretter <m.tretter@pengutronix.de>,
	Bo Liu <liubo03@inspur.com>, kernel@pengutronix.de,
	mchehab@kernel.org, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org
References: <20240117030910.2790-1-liubo03@inspur.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20240117030910.2790-1-liubo03@inspur.com>
User-Agent: Mutt/1.10.1 (2018-07-13)

On Tue, 16 Jan 2024 22:09:10 -0500, Bo Liu wrote:
> The maple tree register cache is based on a much more modern data structure
> than the rbtree cache and makes optimisation choices which are probably
> more appropriate for modern systems than those made by the rbtree cache.
> 
> Signed-off-by: Bo Liu <liubo03@inspur.com>

Reviewed-by: Michael Tretter <m.tretter@pengutronix.de>

> ---
>  drivers/media/i2c/isl7998x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/isl7998x.c b/drivers/media/i2c/isl7998x.c
> index 89e13ebbce0c..c7089035bbc1 100644
> --- a/drivers/media/i2c/isl7998x.c
> +++ b/drivers/media/i2c/isl7998x.c
> @@ -1337,7 +1337,7 @@ static const struct regmap_config isl7998x_regmap = {
>  	.rd_table	= &isl7998x_readable_table,
>  	.wr_table	= &isl7998x_writeable_table,
>  	.volatile_table	= &isl7998x_volatile_table,
> -	.cache_type	= REGCACHE_RBTREE,
> +	.cache_type	= REGCACHE_MAPLE,
>  };
>  
>  static int isl7998x_mc_init(struct isl7998x *isl7998x)
> -- 
> 2.31.1
> 
>