Received-SPF: pass (google.com: domain of linux-kernel+bounces-38285-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 25 Jan 2024 17:37:15 +0800
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Qi Tao <taoqi10@huawei.com>
Cc: davem@davemloft.net, liulongfang@huawei.com,
	linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org
Subject: Re: [PATCH 3/4] crypto: hisilicon/sec2 - fix some cleanup issues
Message-ID: <ZbIry8M6yFUAr5oL@gondor.apana.org.au>
References: <20231229064421.16981-1-taoqi10@huawei.com>
 <20231229064421.16981-4-taoqi10@huawei.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231229064421.16981-4-taoqi10@huawei.com>

On Fri, Dec 29, 2023 at 02:44:20PM +0800, Qi Tao wrote:
>
> @@ -1371,7 +1371,7 @@ static int sec_skcipher_bd_fill_v3(struct sec_ctx *ctx, struct sec_req *req)
>  	sec_sqe3->bd_param = cpu_to_le32(bd_param);
>  
>  	sec_sqe3->c_len_ivin |= cpu_to_le32(c_req->c_len);
> -	sec_sqe3->tag = cpu_to_le64(req);
> +	sec_sqe3->tag = cpu_to_le64((unsigned long)(uintptr_t)req);

Please explain why you're casting twice.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt