Received-SPF: pass (google.com: domain of linux-kernel+bounces-38267-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 25 Jan 2024 11:29:09 +0200
From: Vladimir Oltean <olteanv@gmail.com>
To: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= <arinc.unal@arinc9.com>
Cc: Andrew Lunn <andrew@lunn.ch>, Florian Fainelli <f.fainelli@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	mithat.guner@xeront.com, erkin.bozoglu@xeront.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: dsa: mt7530: select MEDIATEK_GE_PHY for
 NET_DSA_MT7530_MDIO
Message-ID: <20240125092909.exaisdjkkgmc5fue@skbuf>
References: <20240122053451.8004-1-arinc.unal@arinc9.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240122053451.8004-1-arinc.unal@arinc9.com>

On Mon, Jan 22, 2024 at 08:34:51AM +0300, Arınç ÜNAL wrote:
> Quoting from commit 4223f8651287 ("net: dsa: mt7530: make NET_DSA_MT7530
> select MEDIATEK_GE_PHY"):
> 
> Make MediaTek MT753x DSA driver enable MediaTek Gigabit PHYs driver to
> properly control MT7530 and MT7531 switch PHYs.
> 
> A noticeable change is that the behaviour of switchport interfaces going
> up-down-up-down is no longer there.
> 
> Now, the switch can be used without the PHYs but, at the moment, every
> hardware design out there that I have seen uses them. For that, it would
> make the most sense to force the selection of MEDIATEK_GE_PHY for the MDIO
> interface which currently controls the MT7530 and MT7531 switches.
> 
> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
> ---

I see MEDIATEK_GE_PHY only depends on NETDEVICES && PHYLIB, so it should
have no problem being directly selected by a driver without breaking the
build by causing unmet dependencies.

I also see there is precedent with CONFIG_TXGBE selecting
MARVELL_10G_PHY, CONFIG_R8169 selecting REALTEK_PHY, and others.

Reviewed-by: Vladimir Oltean <olteanv@gmail.com>