Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp1644786rdb; Thu, 25 Jan 2024 01:42:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IEYSlgbL+Q0+fR6nptt/nw2KdOhKl0Rh23Nxr4k5z049Bj04hWMsNQBgqACK0v2Xh6E2P/M X-Received: by 2002:a05:6358:92a:b0:176:3715:3c32 with SMTP id r42-20020a056358092a00b0017637153c32mr355832rwi.3.1706175763374; Thu, 25 Jan 2024 01:42:43 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706175763; cv=pass; d=google.com; s=arc-20160816; b=sTZdy96YqCfH4n84BKJu82syQGqXwZNAEZZJ7ICFAnEoCquhfN00Wd5l7rBM4fsQVM 2XfPHOk372iuOcJErFQTTOFVTFbDvIg8+PCGYHbtyjaU26PY44AxsS7gLde3e1qMwzYN /0p1W8H9VMcFzB1zIgmtJy5aQyaedvN5OF6iGgCXu8VfjPkmo2DKV7J3qGJqPIYvSBLI UnXstVuzfLn4OKyK8lGhMAw6ldjbc2f7TVOUhP9TjfMJV/ToT+ufyfiO3lIw1bfG3+b6 DCJK/w4sRKIQt1j2IlJpF6ydSSR/owZ69GzWMeLE1jj0gF8a4dNETFKhXBFlRSkfkYp4 NuHg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:references:in-reply-to:subject:cc:to:from:message-id :date:dkim-signature:dkim-signature:dkim-signature:dkim-signature; bh=LqO3/k5my85BZMbKqkCA9egmBjk9aaibA3LxQHowLFY=; fh=Hub2meEn5jQ5S3DoZhW1x8+KYo8B7kASzCAmgk+Rlmw=; b=blKpKqp1u91CJ43XQGeyukpvYljX0KuGNE3EXiH7yl2HRh+JCieTuochTg6Zxx9N22 J4JMfTXxwTmPelKaxSDHfjY/L7ACAt0METUUDn4uFrWvQXMaI6WwQFK0+s+kkqDiM6qB sMom+6tz+ulZUctRUOlW2lgkrs5zWkCUQKC+FcL8M6QSWjcY4D/N5erwSlWdSKFLkv9d vlc7bYRcHQG64wh+oVCNSkf6WBtlw6KLbD7/OqobQT7tsYEu3iO0xq6Guxl6uEUNqpJg OuiMjxh6t6xJvFCrUtdCiO7hWPgF9vPSBAKURNlaR15hA/txezt2cHagfByd0KAtgprK V9PQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=QTabPfsN; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=QTabPfsN; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-38234-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38234-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id w70-20020a638249000000b005d68962e1a5si612200pgd.488.2024.01.25.01.42.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 01:42:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-38234-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=QTabPfsN; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=QTabPfsN; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; arc=pass (i=1 spf=pass spfdomain=suse.de dkim=pass dkdomain=suse.de dkim=pass dkdomain=suse.de dmarc=pass fromdomain=suse.de); spf=pass (google.com: domain of linux-kernel+bounces-38234-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38234-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 54A91B2A140 for ; Thu, 25 Jan 2024 09:09:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 26BC21BC2D; Thu, 25 Jan 2024 09:05:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="QTabPfsN"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="uhZpULmk"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="QTabPfsN"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="uhZpULmk" Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BD5A1BC23; Thu, 25 Jan 2024 09:05:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706173547; cv=none; b=Bzw8CSKLe5Ay7i0RbTae8qPpDYZga78kZ40crSqx08NN0UqLgP/a4JIa23N1eGijEiQ0wHXQVgsLECFUvB0BBK8oSFIuBlLEKvURy+cR/rF9tLfSLEDDrx9cU6qiC5nfPVyr77113eSEvYbmSgZeIVH5A2yfhME/yKlwcktuJ/g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706173547; c=relaxed/simple; bh=/Awd5Rpw/LP0WK2bkwYJVJu10+RpEs5ehXlnYOdjEfU=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=EQS9DSBM+aMbzANYpZeKQ1JjuN5ApZ8oriC2j/KAOOaWAd4AsII1aJQDd8CN2yts3vrZLoK+U+Uvnig56vjc7CjEUbc18pE9peaAv3apXF9tRJNkuoVA7PALM5bV6fPSyevHp+wH6JfGX1Eu1MkE6Gb6zZxVN7kPvCHmG0/rj9s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=QTabPfsN; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=uhZpULmk; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=QTabPfsN; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=uhZpULmk; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id BFF051F84C; Thu, 25 Jan 2024 09:05:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706173540; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LqO3/k5my85BZMbKqkCA9egmBjk9aaibA3LxQHowLFY=; b=QTabPfsNk0guURroVYzz+FmbtUAVMvVU+U/QVhvxpghjL64cTAe/0I1kGdF0ojvHfePUmw s4oFAktLUZBiHr2rd9e1PZBxZ0LQ1bKVXxHPhpuT452T7xqLhHyeLx/fwWygoPXKWU0nzX c7IA9xoYQdLvCLMHICIJnbAprtUNTKQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706173540; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LqO3/k5my85BZMbKqkCA9egmBjk9aaibA3LxQHowLFY=; b=uhZpULmkXrNFMbMhGHbbHVJvzLH5vasozTg6RYgYPoAkQm2k2iXlytkmDzl2tz++C8ujhK z7qGV0VQdTzKWYAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1706173540; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LqO3/k5my85BZMbKqkCA9egmBjk9aaibA3LxQHowLFY=; b=QTabPfsNk0guURroVYzz+FmbtUAVMvVU+U/QVhvxpghjL64cTAe/0I1kGdF0ojvHfePUmw s4oFAktLUZBiHr2rd9e1PZBxZ0LQ1bKVXxHPhpuT452T7xqLhHyeLx/fwWygoPXKWU0nzX c7IA9xoYQdLvCLMHICIJnbAprtUNTKQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1706173540; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LqO3/k5my85BZMbKqkCA9egmBjk9aaibA3LxQHowLFY=; b=uhZpULmkXrNFMbMhGHbbHVJvzLH5vasozTg6RYgYPoAkQm2k2iXlytkmDzl2tz++C8ujhK z7qGV0VQdTzKWYAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 76A90134C3; Thu, 25 Jan 2024 09:05:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id PI+MG2QksmUcPwAAD6G6ig (envelope-from ); Thu, 25 Jan 2024 09:05:40 +0000 Date: Thu, 25 Jan 2024 10:05:40 +0100 Message-ID: <87o7d9kckb.wl-tiwai@suse.de> From: Takashi Iwai To: Richard Fitzgerald Cc: , , , , , , , Subject: Re: [PATCH 0/2] ALSA: hda: Move component binding support into separate library In-Reply-To: <87plxqlucs.wl-tiwai@suse.de> References: <20240124112607.77614-1-rf@opensource.cirrus.com> <87plxqlucs.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=QTabPfsN; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=uhZpULmk X-Spamd-Result: default: False [-1.18 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+]; MX_GOOD(-0.01)[]; RCPT_COUNT_SEVEN(0.00)[9]; MID_CONTAINS_FROM(1.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-1.87)[94.27%] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: BFF051F84C X-Spam-Level: X-Spam-Score: -1.18 X-Spam-Flag: NO On Wed, 24 Jan 2024 14:43:47 +0100, Takashi Iwai wrote: > > On Wed, 24 Jan 2024 12:26:05 +0100, > Richard Fitzgerald wrote: > > > > The Cirrus Logic amplifiers are currently paired with Realtek HDA codecs. > > But they could be used with other codecs. To prepare for this, these two > > patches move the manager side of the component binding out of the Realtek > > driver into a library module. > > > > The first patch tweaks the CS35L41 code so that it is not hardcoded to > > CS35L41, and changes the TAS2781 handling so that it re-uses that code > > instead of having a near-identical copy of it. > > > > Can someone please test that these two patches don't break TAS2781? > > I have checked that they should work in theory but I don't have hardware > > to test on. > > > > Richard Fitzgerald (2): > > ALSA: hda: realtek: Re-work CS35L41 fixups to re-use for other amps > > ALSA: hda: realtek: Move hda_component implementation to module > > Through a quick glance, it looks good. > I'll wait for the verification for TAS codec for a while. Now applied to for-next branch. thanks, Takashi