Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp1646316rdb; Thu, 25 Jan 2024 01:46:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IHO61CzTamLBaYZ6EXiQjLOKJIYxLxw+Hi3ElUzlu8m/WV/WEQV2gePG9OgMPfQi/xbRfX5 X-Received: by 2002:a05:6358:7e56:b0:176:6e9a:e79 with SMTP id p22-20020a0563587e5600b001766e9a0e79mr671225rwm.62.1706176000246; Thu, 25 Jan 2024 01:46:40 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706176000; cv=pass; d=google.com; s=arc-20160816; b=gtPXrm2i/SMyJxOM5jwVGs93JUFebLVxIiSO9smKwUdntPwsQ9EUJRTHyuhgWl3Pej uhFvi8GBki+w+xPcTjR3Yk41jICkJhm3FZ++gHs7IICmwu6lsaUHFdYlIPglRFSNpHYI FiItSiA9za7bEpzVPJXq5588iR5MefJP+B4Ms4g3nFfByZ8upfkUFUWbeIOVHbMd3sdv 8SHcRODbODY5JcBS2oFOsmNTY+bsPeW7aMiAtiy64xGVkCtxf2F6UOvHu6hMHkMAGiUz CXPrPfts41mohZow44eAcGvYnP2YcjqCychbBPmh9F/QFAykivAliY3EIQm+ZNX9f5dI 3mZg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:date:references:in-reply-to:subject:cc:to:dkim-signature :dkim-signature:from; bh=prZOw6tKpFn/6JU4veL7w0WW1S6fKNMT/YrEaAwZZM4=; fh=ArO5S2f1rvOnBmBk4qnXzbNnl1G0evdbqv5Z8pM5RrA=; b=emmSCAWH0bzCs6kj4wwm5u5s3NHqZzejnJywgb4uWzqpi60E0K9CbDkLTKoNJtbRc1 mhas9uJoWMqCsBvBjFcCOOQN9nPwhd+dxdWyGnOpAtE7wg5Hvzvty3ahI6ZrDfREcXOY xKF5umDSzbXO0z/QmKt1NcKh/W45m13tGhCfInxZBvIeGGuSXcZEYts+Y9qBXOokqIMq bjtBrGgD1gxVh0QjeE8MeSXUnsijpRJBuHIYfmSMKiXgKeMPzoeGIGKdZjOgumpw+pB+ llg6CecaH1auMUOVmtr1k6MaWfBhHQsOgk252i136MofsS8NTc0LtlAAb/tIgACM6IIw ZD/w== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=gg5hIz7m; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-38293-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38293-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id m12-20020a656a0c000000b005cee03d1803si13412563pgu.750.2024.01.25.01.46.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 01:46:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-38293-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=gg5hIz7m; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-38293-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38293-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 0BD07287C7F for ; Thu, 25 Jan 2024 09:40:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DC7DE1BF3A; Thu, 25 Jan 2024 09:39:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="gg5hIz7m"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="Lvpdltox" Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1BF61BF28 for ; Thu, 25 Jan 2024 09:39:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706175572; cv=none; b=b1P1VyLfbIaw9M6MMjZs1sInbd0c35tCVScn+XpmFzq0lsQOqtt/T/vTdd/Tie3AowoIrzLFKaOCL9G2J3RRdpZNhJkyLjytvYC0DglLIPAnZRQAwcrbtYQvFpvh3Uhye41WacKJ6heCnWTfjkWXTP2ZOKTVxBtipv2xpeCePm4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706175572; c=relaxed/simple; bh=prZOw6tKpFn/6JU4veL7w0WW1S6fKNMT/YrEaAwZZM4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=Dvoju0k4bntOHjLFlXc1lyzhjdJAM+aF8H6KbBIunkXgmKtkeylPd9oVxhMKMWDm78rYSLwV5EQvxFxDFHearxG1LxeZFKEG5lHWiF9BKHjJYXZPJ6+gbbanKFWgaVIVXef39Ta+idOsPXOz7QSfgHR7N1oO7UgVKxlcRMEdmfo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=gg5hIz7m; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=Lvpdltox; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1706175568; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=prZOw6tKpFn/6JU4veL7w0WW1S6fKNMT/YrEaAwZZM4=; b=gg5hIz7mtx30q1cjK9rRUqiaH0ZuTmvcU7chA38OHY+pYCNMVMLzrze2CMgpysKkQ9kAwT nfbzIyhZ0N2t4qXGSY0B+EgHvoz68DaGQish9eDxb0L4a8eRXsvCqSFOIwB1HgYoAWg3Vc 3SwpMmrK0K8VdX8M8bcRIeSLMlgG3tkiVXVzB8T1WTPGXu08AysxlAXfc3moMLBFepNCJK 3XdiG1yO/XEunuhJMZ0DtO0a5nlpAClgnd4AldL5NPdU60wnhkoWIzL9oh0s3Q5rCw+Oaj OUFJAyMkeFbgmkKjpbVU4Td2egGXE+DsL+Ux8zrFSN4y/hHGpjEVQKQ1+Zj8Dw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1706175568; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=prZOw6tKpFn/6JU4veL7w0WW1S6fKNMT/YrEaAwZZM4=; b=LvpdltoxW9NZZxeXyLhJEMpPiGi2j/7Wl4KyuhVozaCrvtzCrSZ6gDhCmmRb/XQCjEY8LB h07ujrJGqhDmkODg== To: Frederic Weisbecker , LKML Cc: Frederic Weisbecker , Ingo Molnar , Anna-Maria Behnsen , Peng Liu , Joel Fernandes Subject: Re: [PATCH 10/15] tick: Assume the tick can't be stopped in NOHZ_MODE_INACTIVE mode In-Reply-To: <20240124170459.24850-11-frederic@kernel.org> References: <20240124170459.24850-1-frederic@kernel.org> <20240124170459.24850-11-frederic@kernel.org> Date: Thu, 25 Jan 2024 10:39:28 +0100 Message-ID: <87r0i5iwfj.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Wed, Jan 24 2024 at 18:04, Frederic Weisbecker wrote: > The full-nohz update function checks if the nohz mode is active before > proceeding. It considers one exception though: if the tick is already > stopped even though the nohz mode is inactive, it still moves on in > order to update/restart the tick if needed. > > However in order for the tick to be stopped, the nohz_mode has to be > either NOHZ_MODE_LOWRES or NOHZ_MODE_HIGHRES. Therefore it doesn't make > sense to test if the tick is stopped before verifying NOHZ_MODE_INACTIVE > mode. > > Remove the needless related condition. > > Signed-off-by: Frederic Weisbecker Reviewed-by: Thomas Gleixner