Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp1655543rdb; Thu, 25 Jan 2024 02:07:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IESPhe2kerFnea4jiBIHhQkX04V2VDHfwVD8dCfPJA9k6p7KecPW6ewL3dEN8S6N1GbrWJS X-Received: by 2002:a17:903:2689:b0:1d7:78ed:4b7e with SMTP id jf9-20020a170903268900b001d778ed4b7emr692654plb.35.1706177262257; Thu, 25 Jan 2024 02:07:42 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706177262; cv=pass; d=google.com; s=arc-20160816; b=rtbJpLerPv8/7M9KeoyVj44m65Sxc0jzynY8nrbAAH/9gk/p42ftVX61GOp3bPgEcM fkNx8pkhzppzbW29GZN7fS0nGawAHfsunB+P8nNMPphmlTM6qIz+0uMJKJRCSvC6fh3A IS3/Yk0EVqzFo/kTFp3XbO8frEqxXFDSkZX9GxDNjSCJnvBLIFk86qhtPi1YSiM0zloa c0uhiqjgC2O3GAs9ath5vPkZbh0KwXnVif2UmUzm4zXLkM0CregTVCTOBLFfxBq501xF pa+AAD0Oe1e9I4/nRbradU7dFhCszgh8zLm5qHwirwO8AIsVi3R3RG0hmErjuU73bBrL JG5A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:date:references:in-reply-to:subject:cc:to:dkim-signature :dkim-signature:from; bh=CNAktRCwF+AEmF8BsY9r7SYP1FMPZxLbGHZDZj2YVP4=; fh=ArO5S2f1rvOnBmBk4qnXzbNnl1G0evdbqv5Z8pM5RrA=; b=WZRdISoHMnkKsEPOA8rSRzO/3VJzr4JfZiXe5s4ye1Vbuu/f/QbyjJppwMl2gdam5B 6ErLzCYmE9kDUO1wUMiD9mYn3UQyxjaqWoVgvC+/k2MQe03e7VfKnLq/d9w5ZKEhUz2R yMsiqvBqBeOyANrkq/IbxtZDoY7Uj9APyzEYpmi6LqecBquoTzXfoxXaujnhaT9Q6kgz QxSLbGVoL+rG3lvYbCWenLwC24X6jUADO87NTHlqd9IsL3TkUa1Yx3/ezVeQ9xEp6Hbw sxTBD0kzwcXvA+a5eMG2beks3V1O2GduZ7TQxryfJGiqKUoPlzv6B995eriNi8lcKjQq jD6g== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=vzv10JHx; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-38292-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38292-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id u7-20020a170902e80700b001d5af6a0736si2147563plg.451.2024.01.25.02.07.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 02:07:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-38292-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=vzv10JHx; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-38292-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38292-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 3AD27B31D9B for ; Thu, 25 Jan 2024 09:39:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F1DDF1CD36; Thu, 25 Jan 2024 09:38:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="vzv10JHx"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="PLgm1Xgl" Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0D381CD2C for ; Thu, 25 Jan 2024 09:38:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706175520; cv=none; b=TnWgHX7lriRPd054Smjy08xcoSAELde1B/uJf8J6ANMQfx+6eM8FOzwRWA87wJg+UKkEpRiu10tDUiSFg1eCF1qSgkkZJPBtmRCpdkzumg1DIWgdLtrmXq6b6EhPIiRH8tX7CnxG0yCBrpbu9i5sKz7T0pl/3ykE/HVYja8WwQk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706175520; c=relaxed/simple; bh=CNAktRCwF+AEmF8BsY9r7SYP1FMPZxLbGHZDZj2YVP4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=s3/IjFu5WC088OQUKZTD3vFUyjtjUj8qFjWS4YkyFjSHANdCsrrVJWyhD3vdAuAbkXNUnJNbUqmlSOGObVLat9OYG8/Ie68cm/kQraC1ZvJR57VmMJQ8a/9RNN2m1vhzCUH3J0/ALUW1IMT4FooaFmJ2N0KBqhWAOYKOe7zcXdI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=vzv10JHx; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=PLgm1Xgl; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1706175517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CNAktRCwF+AEmF8BsY9r7SYP1FMPZxLbGHZDZj2YVP4=; b=vzv10JHxZJn6Mo9BMsSOzQxJzM6rEYCRW3mqD20GSTagTN7CFG5hqhowfRxPDaAq4JrXlr OJwSzROo3wwblrdJ5N+L1/6XV1hDDoPjoBtdxtUtl0rEgu5lilj1V3K+mL2xWXA/dubp4c nOyW6oXGDvVn0mjmVFS9DcNJlQjRBOPVUT7bkK+c5iNQ7jfFpLmNIvNrObKEcQ9ajJJBmH ydnvWWi3C53xsOhuG55pn0r/ro9hKpm37T0aDiMqOc2hmTdI4GdsGBv7HSnnWk0arBFu1I Vb3cmcR1D/qCenC39W2w4mfwyd8H71bia6OJu1RzR5GCe0BbE1mzrM4hu2EpYQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1706175517; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CNAktRCwF+AEmF8BsY9r7SYP1FMPZxLbGHZDZj2YVP4=; b=PLgm1XglALdZA1GwOkIDa69R3p/xQnb0mDl42YVfVT+Db3wZRlfNe8QpHRwYUzp2SUCW16 8G3YbnyWdmXiheCw== To: Frederic Weisbecker , LKML Cc: Frederic Weisbecker , Ingo Molnar , Anna-Maria Behnsen , Peng Liu , Joel Fernandes Subject: Re: [PATCH 09/15] tick: Move broadcast cancellation up to CPUHP_AP_TICK_DYING In-Reply-To: <20240124170459.24850-10-frederic@kernel.org> References: <20240124170459.24850-1-frederic@kernel.org> <20240124170459.24850-10-frederic@kernel.org> Date: Thu, 25 Jan 2024 10:38:36 +0100 Message-ID: <87ttn1iwgz.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Wed, Jan 24 2024 at 18:04, Frederic Weisbecker wrote: > The broadcast shutdown code is executed through a random explicit call > within stop machine from the outgoing CPU. > > However The tick broadcast is a midware between the tick callback and s/The/the/ > the clocksource, therefore it makes more sense to shut it down after the > tick callback and before the clocksource drivers. > > Move it instead to the common tick shutdown CPU hotplug state where > related operations can be ordered from highest to lowest level. > > Signed-off-by: Frederic Weisbecker Reviewed-by: Thomas Gleixner