Received-SPF: pass (google.com: domain of linux-kernel+bounces-38274-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Thomas Gleixner <tglx@linutronix.de>
To: Frederic Weisbecker <frederic@kernel.org>, LKML
 <linux-kernel@vger.kernel.org>
Cc: Peng Liu <liupeng17@lenovo.com>, Ingo Molnar <mingo@kernel.org>,
 Anna-Maria Behnsen <anna-maria@linutronix.de>, Joel Fernandes
 <joel@joelfernandes.org>, Frederic Weisbecker <frederic@kernel.org>
Subject: Re: [PATCH 02/15] tick/nohz: Remove duplicate between lowres and
 highres handlers
In-Reply-To: <20240124170459.24850-3-frederic@kernel.org>
References: <20240124170459.24850-1-frederic@kernel.org>
 <20240124170459.24850-3-frederic@kernel.org>
Date: Thu, 25 Jan 2024 10:32:09 +0100
Message-ID: <87ede5kbc6.ffs@tglx>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

On Wed, Jan 24 2024 at 18:04, Frederic Weisbecker wrote:
> +/*
> + * We rearm the timer until we get disabled by the idle code.
> + * Called with interrupts disabled.
> + */
> +static enum hrtimer_restart tick_nohz_highres_handler(struct hrtimer *timer)

Isn't that a misnomer now?

> +{
> +	struct tick_sched *ts =
> +		container_of(timer, struct tick_sched, sched_timer);

Let it stick out please.

> +	struct pt_regs *regs = get_irq_regs();
> +	ktime_t now = ktime_get();
> +	if (likely(tick_nohz_highres_handler(&ts->sched_timer) == HRTIMER_RESTART))
>  		tick_program_event(hrtimer_get_expires(&ts->sched_timer), 1);

Thanks,

        tglx