Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp1662887rdb; Thu, 25 Jan 2024 02:25:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IHhogOcZOB5BqepJvvi/niFt7o90/UQL7LYd5T/K25m8K/AfORxdjH4X0sszb0RflpcBrd+ X-Received: by 2002:a17:903:41c9:b0:1d7:3eef:2f66 with SMTP id u9-20020a17090341c900b001d73eef2f66mr673717ple.46.1706178316864; Thu, 25 Jan 2024 02:25:16 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706178316; cv=pass; d=google.com; s=arc-20160816; b=doBdqnjs3yirn/70nbe4D2VzoNaFvWPhNPBprlJakQFuO9Yuj5jcJgj7HzxS1cHwDT +HJDiVNKr2KtcsBOLwrWAExrBOVsnp8s44oyqevJ3ulHgH+NVPnbmsOl0qeaxD/7wZ5o ylfR5YegKEXQJkd56GbBNVw6QM85bOzPINKmGku2ssZD3cj/F+m0jrEDaR5gLOhZpk+f +g+KGC6HTVd769vcTOW0J50cEnutMo2M4yPMTIygof3Rb+54At9Hw0kLPqnZ8bDIdKUZ gF6v6euxsNNupbpF0RPFJttkTCx0wt1PYgLGCGq3hradprDdFvi8+GCvCipkKZ7VcnQw wW9A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :message-id:date:references:in-reply-to:subject:cc:to:dkim-signature :dkim-signature:from; bh=aVKIZDXyohVuLgWytwkihjnuLVIZehHyrbXga6PEsN8=; fh=ArO5S2f1rvOnBmBk4qnXzbNnl1G0evdbqv5Z8pM5RrA=; b=cEizwt2+nvw/vqoGs0vBsapoqIwxKdkSrHYouLFJr8az3ZXw+z8zwod/PdlP4owJ5X MCEeKymB7PWteGvgbAVE3UAet+9PpXHaYIHMasrxvoa+JacwEDnfhgPltK0UPqcjFrQs ZQUSeUo0Eno/Bz3Dn7YAs530IuARyKHungiRF3ngO2D1P7NHtAsm+MOM9PaqSbCDQnZN /IlNAbT35Mi8JwHhP3Mqib5UAfI3RiylocphJZaslDd/gT1Ibrat0ZvaB4lmGMHvM5ol Zli13irZt0t/tBN6vpFA/EBPU/BSIxTZN+79qswplhDvVtfzXelizNJbceAlEeCEAqxF c2Pw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=oRweHhD2; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-38313-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38313-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id jj18-20020a170903049200b001d51f3acb68si1101366plb.280.2024.01.25.02.25.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 02:25:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-38313-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=oRweHhD2; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e; arc=pass (i=1 spf=pass spfdomain=linutronix.de dkim=pass dkdomain=linutronix.de dmarc=pass fromdomain=linutronix.de); spf=pass (google.com: domain of linux-kernel+bounces-38313-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38313-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 2A851B2DFE9 for ; Thu, 25 Jan 2024 09:45:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 815981CD0B; Thu, 25 Jan 2024 09:43:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="oRweHhD2"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="GjeCDBB+" Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B0FD1CD03 for ; Thu, 25 Jan 2024 09:43:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706175825; cv=none; b=LpZpUPtt2IZxFdTetdNNxTKruGQxoJas8F6t1CZ68GxEpXjUKUTgq07X1jNhFHhV2FMgD5Rw+ka9L73JqG0Ir+SHPm1jr82Fr8KbZm9R0UBPN0ArdIXW/h894avgVJDUz/pZKuyRB97NFR0E9cf9m2HEcfjxiKZ2WxWKW8z90pc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706175825; c=relaxed/simple; bh=Yr9dAi+HF3e8xeG38C7Z8bramYoSGYC5W2XMpzSL6QQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=FmpUs5BnSEiX9X1+JQNwhexwIKJQgXWPXModEJ7sabDiHmI+hTG+lllQ2Dte7LfVcg++TBsljd08D8p1QA2NQTtJHDbdndZiIia3Ke5aK8ytAL8o8Ni71C0aq607J/kW9Y2WpXBwccIQRyBj44crxn5NTEBT65y/7yp62yvJLrw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=oRweHhD2; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=GjeCDBB+; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1706175822; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aVKIZDXyohVuLgWytwkihjnuLVIZehHyrbXga6PEsN8=; b=oRweHhD2DsD2ynBsTuWLLrL2xnsEgDv0/zU4UH1V0fH7P9/2BF+nJap/vC1ja3WVNEyOFp 4jESfd63bWktIYJHnZ3ydOsyUyDa0zhk4lKCvzTub/eUmOHJj8HJ9zbiHIGx2lbfWfl8aD QOnHtnpt8zIg8QEsqnAdvHU44qb/nxJaGgjs7nOIQf255Dj+FF9CbvJajvISyRXG2FLKhQ Hgjai+YV2nqvOA/x3gaUpz2b1TIS1EsDuH3MlIX3aYdUc2TrZVejYr9EPUJGykSpYyod8j Ll6wI85D57jxP7n1MCIeEivtcQfINMxfUNqQg+W20MEg8ODlAJ2BnHFnrR8liA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1706175822; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aVKIZDXyohVuLgWytwkihjnuLVIZehHyrbXga6PEsN8=; b=GjeCDBB+jvltyKsxEDLAtPdFUaPcck6KzY43OGZnHe3aJf4P94Qp4OescV04qgjna1QINo MdSMcgc4Am05T4Cw== To: Frederic Weisbecker , LKML Cc: Frederic Weisbecker , Ingo Molnar , Anna-Maria Behnsen , Peng Liu , Joel Fernandes Subject: Re: [PATCH 15/15] tick: Assume timekeeping is correctly handed over upon last offline idle call In-Reply-To: <20240124170459.24850-16-frederic@kernel.org> References: <20240124170459.24850-1-frederic@kernel.org> <20240124170459.24850-16-frederic@kernel.org> Date: Thu, 25 Jan 2024 10:43:42 +0100 Message-ID: <87bk99iw8h.ffs@tglx> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Wed, Jan 24 2024 at 18:04, Frederic Weisbecker wrote: > The timekeeping duty is handed over from the outgoing CPU on stop > machine, then the oneshot tick is stopped right after. Therefore it's > guaranteed that the current CPU isn't the timekeeper upon its last call > to idle. > > Besides, calling tick_nohz_idle_stop_tick() while the dying CPU goes > into idle suggests that the tick is going to be stopped while it is > actually stopped already from the appropriate CPU hotplug state. > > Remove the confusing call and the obsolete case handling and convert it > to a sanity check that verifies the above assumption. > > Signed-off-by: Frederic Weisbecker Reviewed-by: Thomas Gleixner