Received-SPF: pass (google.com: domain of linux-kernel+bounces-38484-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Peng Fan <peng.fan@nxp.com>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>, "rafael@kernel.org"
	<rafael@kernel.org>, "daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>
CC: "rui.zhang@intel.com" <rui.zhang@intel.com>, "linux-pm@vger.kernel.org"
	<linux-pm@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>
Subject: RE: [PATCH] thermal/drivers/qoriq: fix getting tmu range
Thread-Topic: [PATCH] thermal/drivers/qoriq: fix getting tmu range
Thread-Index: AQHaAyyxm4iPh0Sv7U243t/NmfenWrDq9qpQ
Date: Thu, 25 Jan 2024 11:07:15 +0000
Message-ID:
 <DU0PR04MB9417004E7A877D306DD561A1887A2@DU0PR04MB9417.eurprd04.prod.outlook.com>
References: <20231020081337.3141488-1-peng.fan@oss.nxp.com>
In-Reply-To: <20231020081337.3141488-1-peng.fan@oss.nxp.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?4rNRvGbJCrf5aylXsEPCtbEltxm5O89APQ8KcsGSKjH/o6coyPBVv+XZc6NB?=
 =?us-ascii?Q?Yka6tNzAex/b/Du4rAZGegWU3wdur/oz2nZ7b/Haw3MFw84wL+cxtQhdwOSl?=
 =?us-ascii?Q?wTvUsYUZsnp2pXTPp4rtdV7XBzr2ymRpS9rPvqTXhF96rIKoykmNRNu9taor?=
 =?us-ascii?Q?OTIX+V8N+DFZQz2RS5CiP3++019vDStJ05DN/5IlxJsZLALkhKzUZqpA3gQK?=
 =?us-ascii?Q?Gc4ErGozdWlsqLFpvFw8g9s7JSMluC5UYwwtm9GHixKPyNlDcpq+D/VG9EYL?=
 =?us-ascii?Q?/AWzqxnoj31TDIm2xOy9OyZhzof+jYOm4cg6YqNkRAEp2a+whhupvt6xap2a?=
 =?us-ascii?Q?nvSaWtHXHa8ZEnS/c+zlCBkNzXqvOzhG0KLwWqTNhKpfKRBefQNzKC8R9Pes?=
 =?us-ascii?Q?89mPQP4Nx21TkOb5WNeP0ggBbYLnYmbLyuncMzSvvEycW6uW9rfuaHKSmec8?=
 =?us-ascii?Q?fRefHb4u9D1YW/fyQfadqahn5UUPGx8idY05/z5auBHn2KszkKNo+JOaTkb9?=
 =?us-ascii?Q?tyNSfXGG+FYpKckOOfm7gO9PkQSOAWPm7S/vMU/mdcth5KZsINxM/V9IN4i7?=
 =?us-ascii?Q?J9TPP5szIPcpYu7VaQhM2vwVBzN0e+Xk7NTchaNiN/1DaUUFcdWYLipCQxZJ?=
 =?us-ascii?Q?4JFv48HZlhlreMY3dWW0LKdJeHSR/sADT8YDhgDKFhMptEU2jW/J2lyVLay+?=
 =?us-ascii?Q?DL1/0fyIr9sNs6so47WOQh9kP+zcGMvoBKVZXuUv5BuqFthVS/BUmsarblgm?=
 =?us-ascii?Q?aLWt3krX7bR/9zQ8adiBK/1xtYMtz1ai22Csc9ozXTTKApJvMhBWfWhdAunn?=
 =?us-ascii?Q?BSWuVNaj0/gC9XUfeiBdVELh8btV14Wf/MiXLH6xFYPvkjmPtem9Mcdg02j7?=
 =?us-ascii?Q?M5R8GrNZMGazBK5tT9/KmGRZ4hq26tfp9eRhNkITO1SKqV85oHyds8soni+l?=
 =?us-ascii?Q?PyxEq1EIp79/mdIvUsLmS13EIoEbsbUUiCRHWNUEF6NA2zm44uUGlzabNCWD?=
 =?us-ascii?Q?i88EVlIhZvLTg5rs3WgWHtPFdBB+vVX95mYU0EkMOFUW2j3Ye5c44DkbGJG1?=
 =?us-ascii?Q?gbuhg287rbMrSO1lGG5mdwDQZs+XibZxAxmwtupY7qj7KnSXRlv118T+PuD6?=
 =?us-ascii?Q?M9YpCnR3dM4ykLKZYZoK0AJTP3FyTNLzKa4VQTEtBw5RP5uFl4oeI6veNmLv?=
 =?us-ascii?Q?aEJGnT5zRxWAd3ffSaVGLSjx2rz5U2QwbeFdBkQcPZ+rFM6gR5jV4iJoyXPC?=
 =?us-ascii?Q?DH5tAvXEagOVHgwzbGmlZCEhF1J/T+WdhOL7fmlibD11KTR7ArFdhs61mgLQ?=
 =?us-ascii?Q?ZpgcGRHOtTlar0+Lvnv5Oho7O/2bbkyW/W9xjDrA3NhDthw2grUmS7KCvjgD?=
 =?us-ascii?Q?yhbXbKl5SKWfn7PL61zoZPJuEsqZZspuI5GLFCpSvG/o1vA2aFrDZdpzm6c8?=
 =?us-ascii?Q?/912B8BqENTS6tit9J+Ng0D43FO5816vUOV2FmWdoTTUMB5QqAEtcIYdRiIg?=
 =?us-ascii?Q?NJerSTB9j7tRdwnQGq6eSdtuVddJWySgHF6gsXdBAOvyMWrY6PMWKHoiXe3B?=
 =?us-ascii?Q?mtHVpAOft7zOLt8JWfs=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d2e1195d-a357-4464-22d2-08dc1d95ca2f
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2024 11:07:15.8713
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZHHjiNlYbUz0mUMR8lWt41WugN7r+mFhGokgj10QZ1mFb0OWjpKephWBmdVkq5aukn+1AxXQquMt+8sJd8s5wQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7710

Hi Daniel,

> Subject: [PATCH] thermal/drivers/qoriq: fix getting tmu range
>=20

Would you pick up this patch?

Thanks,
Peng.

> From: Peng Fan <peng.fan@nxp.com>
>=20
> TMU Version 1 has 4 TTRCRs, while TMU Version >=3D2 has 16 TTRCRs.
> So limit the len to 4 will report "invalid range data" for i.MX93.
>=20
> This patch drop the local array with allocated ttrcr array and able to su=
pport
> larger tmu ranges.
>=20
> Fixes: f12d60c81fce ("thermal/drivers/qoriq: Support version 2.1")
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  drivers/thermal/qoriq_thermal.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/thermal/qoriq_thermal.c
> b/drivers/thermal/qoriq_thermal.c index ccc2eea7f9f5..404f01cca4da
> 100644
> --- a/drivers/thermal/qoriq_thermal.c
> +++ b/drivers/thermal/qoriq_thermal.c
> @@ -57,6 +57,9 @@
>  #define REGS_TTRnCR(n)	(0xf10 + 4 * (n)) /* Temperature Range n
>  					   * Control Register
>  					   */
> +#define NUM_TTRCR_V1	4
> +#define NUM_TTRCR_MAX	16
> +
>  #define REGS_IPBRR(n)		(0xbf8 + 4 * (n)) /* IP Block Revision
>  						   * Register n
>  						   */
> @@ -71,6 +74,7 @@ struct qoriq_sensor {
>=20
>  struct qoriq_tmu_data {
>  	int ver;
> +	u32 ttrcr[NUM_TTRCR_MAX];
>  	struct regmap *regmap;
>  	struct clk *clk;
>  	struct qoriq_sensor	sensor[SITES_MAX];
> @@ -182,17 +186,17 @@ static int qoriq_tmu_calibration(struct device *dev=
,
>  				 struct qoriq_tmu_data *data)
>  {
>  	int i, val, len;
> -	u32 range[4];
>  	const u32 *calibration;
>  	struct device_node *np =3D dev->of_node;
>=20
>  	len =3D of_property_count_u32_elems(np, "fsl,tmu-range");
> -	if (len < 0 || len > 4) {
> +	if (len < 0 || (data->ver =3D=3D TMU_VER1 && len > NUM_TTRCR_V1) ||
> +	    (data->ver > TMU_VER1 && len > NUM_TTRCR_MAX)) {
>  		dev_err(dev, "invalid range data.\n");
>  		return len;
>  	}
>=20
> -	val =3D of_property_read_u32_array(np, "fsl,tmu-range", range, len);
> +	val =3D of_property_read_u32_array(np, "fsl,tmu-range", data->ttrcr,
> +len);
>  	if (val !=3D 0) {
>  		dev_err(dev, "failed to read range data.\n");
>  		return val;
> @@ -200,7 +204,7 @@ static int qoriq_tmu_calibration(struct device *dev,
>=20
>  	/* Init temperature range registers */
>  	for (i =3D 0; i < len; i++)
> -		regmap_write(data->regmap, REGS_TTRnCR(i), range[i]);
> +		regmap_write(data->regmap, REGS_TTRnCR(i), data->ttrcr[i]);
>=20
>  	calibration =3D of_get_property(np, "fsl,tmu-calibration", &len);
>  	if (calibration =3D=3D NULL || len % 8) {
> --
> 2.37.1