Received-SPF: pass (google.com: domain of linux-kernel+bounces-38486-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 25 Jan 2024 12:08:53 +0100
From: Dimitri Fedrau <dima.fedrau@gmail.com>
To: Nuno =?utf-8?B?U8Oh?= <noname.nuno@gmail.com>
Cc: Javier Carrasco <javier.carrasco.cruz@gmail.com>,
	Li peiyu <579lpy@gmail.com>, Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: humidity: hdc3020: fix temperature offset
Message-ID: <20240125110853.GA3857099@debian>
References: <20240125102641.3850938-1-dima.fedrau@gmail.com>
 <0a98e54735cc2a97f393eef6b1cdaf27c946d10e.camel@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <0a98e54735cc2a97f393eef6b1cdaf27c946d10e.camel@gmail.com>

Am Thu, Jan 25, 2024 at 11:49:25AM +0100 schrieb Nuno Sá:
> Hi Dimitri,
>
Hi Nuno,

> On Thu, 2024-01-25 at 11:26 +0100, Dimitri Fedrau wrote:
> > The temperature offset should be negative according to the datasheet.
> > Adding a minus to the existing offset results in correct temperature
> > calculations.
> > 
> > Signed-off-by: Dimitri Fedrau <dima.fedrau@gmail.com>
> > ---
> 
> This is a fix. You're missing a Fixes: tag in your commit message.
> git log --grep="Fixes:" should give you some examples...
>
Will fix this and resend the patch. Thanks for your help.

Best regards,
Dimitri
> With that, feel free to add:
> 
> Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> 
> >  drivers/iio/humidity/hdc3020.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iio/humidity/hdc3020.c b/drivers/iio/humidity/hdc3020.c
> > index 4e3311170725..ed70415512f6 100644
> > --- a/drivers/iio/humidity/hdc3020.c
> > +++ b/drivers/iio/humidity/hdc3020.c
> > @@ -322,7 +322,7 @@ static int hdc3020_read_raw(struct iio_dev *indio_dev,
> >  		if (chan->type != IIO_TEMP)
> >  			return -EINVAL;
> >  
> > -		*val = 16852;
> > +		*val = -16852;
> >  		return IIO_VAL_INT;
> >  
> >  	default:
>