Received-SPF: pass (google.com: domain of linux-kernel+bounces-38550-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <7f87bfec-8369-4aa7-abdb-da3593f33051@quicinc.com>
Date: Thu, 25 Jan 2024 17:26:13 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH RESEND] arm64: dts: qcom: qcm6490-idp: Add support for
 PM7250B PMIC
Content-Language: en-US
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
        Dmitry Baryshkov
	<dmitry.baryshkov@linaro.org>
CC: Bjorn Andersson <andersson@kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley
	<conor+dt@kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Kamal Wadhwa
	<quic_kamalw@quicinc.com>
References: <20240123102817.2414155-1-quic_uchheda@quicinc.com>
 <CAA8EJppwboaEbKFFACr3LO0OHg4iOJPapKRqoH2EGEYcjV6HfA@mail.gmail.com>
 <735575f5-ee46-4c91-b0bd-e9c6fb97361c@quicinc.com>
 <CAA8EJpr6XrhNp2gdbqmCow7ShXLNXEwGZ-a_Yxr08bcxtORg6A@mail.gmail.com>
 <b4a9ad3e-392f-42ff-8fed-dd86b013176b@linaro.org>
From: Umang Chheda <quic_uchheda@quicinc.com>
In-Reply-To: <b4a9ad3e-392f-42ff-8fed-dd86b013176b@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit

Hi Konrad,

On 1/25/2024 3:15 PM, Konrad Dybcio wrote:
> 
> 
> On 1/25/24 09:26, Dmitry Baryshkov wrote:
>> On Thu, 25 Jan 2024 at 10:10, Umang Chheda <quic_uchheda@quicinc.com> wrote:
>>>
>>> Hi Dmitry,
>>>
>>> On 1/23/2024 5:48 PM, Dmitry Baryshkov wrote:
>>>> On Tue, 23 Jan 2024 at 12:28, Umang Chheda <quic_uchheda@quicinc.com> wrote:
>>>>>
>>>>> qcm6490-idp platform supports PM7250B PMIC as well.
>>>>> Add support for the same.
>>>>
>>>> The platform can not "support" PMIC. Please fix the commit message.
>>> Shall I change the commit message as below in the next patch ?
>>> "Add PM7250B PMIC support for qcm6490-idp"
>>
>> This is also not accurate. You are not adding support for the PMIC.
>> You are describing PMICs present on the board.
> 
> Umang, consider one of:
> 
> arm64: dts: qcom: qcm6490-idp:
> 
> "Include PM7250B"
> 
> "Enable PM7250B"
> 
> "Configure PM7250B"
> 
Ack, I have sent new version of my patch which addresses the feedback.

> Konrad

Thanks,
Umang