Received-SPF: pass (google.com: domain of linux-kernel+bounces-38554-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 25 Jan 2024 12:58:38 +0100
From: Frederic Weisbecker <frederic@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Peng Liu <liupeng17@lenovo.com>,
	Ingo Molnar <mingo@kernel.org>,
	Anna-Maria Behnsen <anna-maria@linutronix.de>,
	Joel Fernandes <joel@joelfernandes.org>
Subject: Re: [PATCH 02/15] tick/nohz: Remove duplicate between lowres and
 highres handlers
Message-ID: <ZbJM7uP2tWJrqbk/@lothringen>
References: <20240124170459.24850-1-frederic@kernel.org>
 <20240124170459.24850-3-frederic@kernel.org>
 <87ede5kbc6.ffs@tglx>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87ede5kbc6.ffs@tglx>

On Thu, Jan 25, 2024 at 10:32:09AM +0100, Thomas Gleixner wrote:
> On Wed, Jan 24 2024 at 18:04, Frederic Weisbecker wrote:
> > +/*
> > + * We rearm the timer until we get disabled by the idle code.
> > + * Called with interrupts disabled.
> > + */
> > +static enum hrtimer_restart tick_nohz_highres_handler(struct hrtimer *timer)
> 
> Isn't that a misnomer now?

Would tick_nohz_hrtimer_handler() make more sense then? Because it's clearly
an hrtimer handler, just emulated in low-res mode.

> 
> > +{
> > +	struct tick_sched *ts =
> > +		container_of(timer, struct tick_sched, sched_timer);
> 
> Let it stick out please.

Ok.

Thanks.
> 
> > +	struct pt_regs *regs = get_irq_regs();
> > +	ktime_t now = ktime_get();
> > +	if (likely(tick_nohz_highres_handler(&ts->sched_timer) == HRTIMER_RESTART))
> >  		tick_program_event(hrtimer_get_expires(&ts->sched_timer), 1);
> 
> Thanks,
> 
>         tglx