Received-SPF: pass (google.com: domain of linux-kernel+bounces-38563-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID:
 <MA0P287MB28226D07A5DC0200132358C4FE7A2@MA0P287MB2822.INDP287.PROD.OUTLOOK.COM>
Date: Thu, 25 Jan 2024 20:07:43 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 2/4] reset: sophgo: add SG2042 reset generator driver
To: Philipp Zabel <p.zabel@pengutronix.de>, Chen Wang <unicornxw@gmail.com>,
 aou@eecs.berkeley.edu, chao.wei@sophgo.com, conor@kernel.org,
 krzysztof.kozlowski+dt@linaro.org, palmer@dabbelt.com,
 paul.walmsley@sifive.com, robh+dt@kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
 haijiao.liu@sophgo.com, xiaoguang.xing@sophgo.com, guoren@kernel.org,
 jszhang@kernel.org, inochiama@outlook.com
References: <cover.1706161530.git.unicorn_wang@outlook.com>
 <34650036ea5f1c500da54c67c3a67b91c4419399.1706161530.git.unicorn_wang@outlook.com>
 <bf30a97b4c39e5c606583783058ea12520c1146b.camel@pengutronix.de>
From: Chen Wang <unicorn_wang@outlook.com>
In-Reply-To: <bf30a97b4c39e5c606583783058ea12520c1146b.camel@pengutronix.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: MA0P287MB2822:EE_|MA0P287MB0714:EE_
X-MS-Office365-Filtering-Correlation-Id: eadf1b71-e15d-4a7a-904a-08dc1d9e3f55
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	gmtzmgpjUqD5H9U0c2GWO3FQS7AM6iFhPtRHiZ+ycZ2IvrsciHq5ivREfNdfE1MDdxmD4CY/OfF+bo9GRX7lqrD5XdTlMA/V8J85rPGA2m9G0LUl+/0SW802M0/SXJNaj8M81v66i4MFz3SYIihDS1r0qUj2xrNQCG6cobczQO7pGxiQLxilDKz1aczca5GfSIvS9zgZGKn8x8/Pc9zWp9bs6FGFHLT/yoM40ib8R0OMUEbXYfpQHBublIxRb+wQDOY3/z26brnH250ajcmb15IX6YISrKwMj5Q1IDuyHO10WC0uPLyXNfnnL1kgRasFpgwvlDFxRamMDktO2XRHQpH2kqo+dzOYYM4uMfYV6p+/AFYA8ecKWzAhHqZJlHyU3dvGPsO/idL/Viic47ikhmmvYM47zMbSgXFyAicAFkzMI89Je70yIXqYs9AmJj8ZV0brA+JxBne3K2/yX57/4cIRX5Ym/XF8uC6btfgjG1MN8OcwpPq4VzSMKqjimfXweStjFWL5rWJJnL8oTXSGw+c2FkCNaIGD5PPMGwOXpbKvAJqUHoxcEq49P2UaIl4B
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?R0dkQjVMbkFNc1E2aE5qY1dFK25yWk9IK3dBeVBHQi9WbWd6dHhvV2toRVBy?=
 =?utf-8?B?RlFNL0ZMU2FXU1BMUklUeDk0Vm1CWDU5N09HU2RoeUdtcU0zWmdCNWJyU3RE?=
 =?utf-8?B?Q1JBZHg0TzhWQkRWUURjVjFoV29xdnhET0owdHRIYmdKN3NEdlVOYmNlT1Az?=
 =?utf-8?B?SDc0MEF0bkFNdlY5TUN5cnRLVStJeHVEdnVTMG5WSVJwY29JcmtoenI5TVF1?=
 =?utf-8?B?cW8yVHhRQm1VVmF3ZmhFR1Q2Rkh6eDV3SDVGQ1U4RU9xNWdiaTJRaUZVa0JC?=
 =?utf-8?B?TER4YlYyYk1FUWR2QVlHT3JFdUlDUjBkdnJvL0hrdyt1UG9ZRXNmR012MzQ4?=
 =?utf-8?B?SE1hVzBvVlVjYk1KOSt4RW1YNGNTS1grZzZFOUF0dVUxV2tnODFWL2hZRVBT?=
 =?utf-8?B?eWR1OG0rYzd3U2xLelhBM1I2RWMvRkpTa2hDRUw2cHZkcDFra0YxMGhVbE9q?=
 =?utf-8?B?ck9VUUh6V0pzUEdlblNZUElHcElvMGk0T2FTUzBjSkg1OTlTVktVcC96cmtV?=
 =?utf-8?B?dndtMThHc29Lc2hUSFFHMS85dENLRWpwSkQzWTk3QWhiQUpTQW51bEV5bFZD?=
 =?utf-8?B?Mi9HdFQrMUlxWmxDT0RVL3ZoSGM5SGFXdjZhU2lGVEFlT3NCREJMNkpWVjdv?=
 =?utf-8?B?Qlc0Si9BNmZrMnBqY2I4dXB4b0pnRGU1NlJlQUh4RVp1OWdRSzZnVk53dGxG?=
 =?utf-8?B?R1BMTDBWc3VraEVXcTQ5L2lvWGc1K2pPdmhIcnNJb2NqRk1BaWV1MjhzK2p1?=
 =?utf-8?B?VE0xQWQ2M05ybEZFeFhYOElLOFc0SjNKOVVrd1Vac2pIcUw0eDJkOUV3ajU1?=
 =?utf-8?B?cmpnYzIva0JITDdKcmhTSm14ckltczNzQjlKZ2Z4KzM3V0FHdGkvMXByZGJp?=
 =?utf-8?B?ZG1TMTJyTzlDSXNXRXlEN2V4SlJlaVl0Ym16VElRMTcrdnI4ZGp3RERVa1J3?=
 =?utf-8?B?cDZ1b2ZZQ2R1aGI4R0FEb3g4SmZhaFZJdDZjT29JTGVNYjhFZWZybmp2cWZD?=
 =?utf-8?B?Qnl3SXdianROempsZUdHdUJBSytVWmtkM1J2Qnl0ai9HcmRadmhqN0F4NUNa?=
 =?utf-8?B?UktoYjZNZFdjN2pPbEdydVZwY05Uc3lQcG0rRWN0QXRtdVRWZEJ1eFRGbHE1?=
 =?utf-8?B?clhnQzlEeWxmaSsydjhMdUVvVVJlRDYxaDljTUtveVBPUkc3Mmw2SnY2b3Ns?=
 =?utf-8?B?UmZpVTlOSEc4RDBqb2hZR1VTM0habzRneGl6aEdXK3FzWlZraUJaMHZXdHpp?=
 =?utf-8?B?WEJYVzlHYnRMdGxIUnZtRjJrS01DbTMzZmVUSEpZYnZtd3JMcEprdE9meFlL?=
 =?utf-8?B?ODRjK2I0bk15cHRjL0w4YUZ1UzN0VXpRNzg1eGd0eXhkY3BYQWg2WHhhL2NT?=
 =?utf-8?B?SFF6NitlejJEWVZiNzZxZTlCUkVuQ0ttMVpEekU5akJTdmRwTE4rcGdrVkYv?=
 =?utf-8?B?TXpYbFRIb0FvTy9pRmJzTGRVRWxGRjFyMHJFV1g0WEVlTzRHVkZvc2w0UXdL?=
 =?utf-8?B?L0pCQVhYREFheldYKzV2T0d0bHVKbWN6OFlISENqekh3MFFtOXhHWXhyOW1v?=
 =?utf-8?B?blhNcjFHNU9yUERoY0N2WUVsSHZRdmJXLzFOTVNyTjg5OFNPbkJMZkNWRnJ6?=
 =?utf-8?Q?oK2F0wP4z8d+vNRBRDvSZjQ0uuGbnABryJVfxhOiZ8jo=3D?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eadf1b71-e15d-4a7a-904a-08dc1d9e3f55
X-MS-Exchange-CrossTenant-AuthSource: MA0P287MB2822.INDP287.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2024 12:07:48.6267
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MA0P287MB0714


On 2024/1/25 18:43, Philipp Zabel wrote:
> On Do, 2024-01-25 at 14:11 +0800, Chen Wang wrote:
>> From: Chen Wang <unicorn_wang@outlook.com>
>>
>> Reuse reset-simple driver for the Sophgo SG2042 reset generator.
> Subject prefix should be "reset: simple: "
Ok.
>
>> Signed-off-by: Chen Wang <unicorn_wang@outlook.com>
>> ---
>>   drivers/reset/Kconfig        |  1 +
>>   drivers/reset/reset-simple.c |  2 ++
>>   drivers/reset/sophgo/Kconfig | 10 ++++++++++
>>   3 files changed, 13 insertions(+)
>>   create mode 100644 drivers/reset/sophgo/Kconfig
>>
> [...]
>> diff --git a/drivers/reset/sophgo/Kconfig b/drivers/reset/sophgo/Kconfig
>> new file mode 100644
>> index 000000000000..9ad96e49e1dd
>> --- /dev/null
>> +++ b/drivers/reset/sophgo/Kconfig
>> @@ -0,0 +1,10 @@
>> +# SPDX-License-Identifier: GPL-2.0-only
>> +
>> +config RESET_SOPHGO_SG2042
>> +	bool "Sophgo SG2042 Reset Driver"
>> +	depends on ARCH_SOPHGO || COMPILE_TEST
>> +	select RESET_SIMPLE
>> +	default ARCH_SOPHGO
>> +	help
>> +	  This enables the reset controller driver for the Sophgo SG2042 SoC.
>> +
> Drop the Kconfig, just add a default y if ARCH_SOPHGO to RESET_SIMPLE.

hi，Philipp,

The purpose of my adding Kconfig is to consider that other socs under 
sophgo may not use RESET_SIMPLE. I'm worried that the coverage is too 
large when default y if ARCH_SOPHGO? What do you think?

Thanks,

Chen

>
> regards
> Philipp