Received-SPF: pass (google.com: domain of linux-kernel+bounces-38571-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID:
 <MA0P287MB2822D37F523A075320BDA99AFE7A2@MA0P287MB2822.INDP287.PROD.OUTLOOK.COM>
Date: Thu, 25 Jan 2024 20:15:32 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] riscv: dts: sophgo: add watchdog dt node for CV1800
To: AnnanLiu <annan.liu.xdu@outlook.com>, chao.wei@sophgo.com,
 robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu,
 devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
 linux-kernel@vger.kernel.org
References: <DM6PR20MB2316366FC9ADCBC7B6E9C289AB7A2@DM6PR20MB2316.namprd20.prod.outlook.com>
From: Chen Wang <unicorn_wang@outlook.com>
In-Reply-To: <DM6PR20MB2316366FC9ADCBC7B6E9C289AB7A2@DM6PR20MB2316.namprd20.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: MA0P287MB2822:EE_|PN3P287MB2619:EE_
X-MS-Office365-Filtering-Correlation-Id: fd729d1e-4d84-4eed-37b3-08dc1d9f55eb
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	xaYJmZW6CzWr8DIh2dclVn1oncV2AI2EgjIxq38ljQku61c/MMYwjY9zNTq9tMCAIB/a2R83/SDYSXhTtpGbTu7i2Ja3rZYIGu1VpUSZpCSN0b1m6BQ0VPV626gJwAQfvjcY80Huj1SJuIn1XhoFiVH3GU87fvnDo+a24XIRz34rvPm3xKNemjBPoHTwW4jiAdg7MJBWloX/OKnjTvRtSTNolx1edviVTQHexdSU19w1Y8ttp++0tP98+n1DLf3dwlBceGqIkQxzy9NGivNTMcnVPvAehUdtwHLflgkl94iyeuvQZcRdl9NKGj0E5uyIBNgtjPnna15k2Hg01uqtYEMy1gkTkDvIr3A7YZnBZhCWvb582jqbRP8DU+QMYp0UZH1ycR4ifJbdDVJY9/iDkltv7x33V5swzx6UIUuHC+7WNf9oLLCy0IudOa7CtYLLaJSsOTEhWylMaufMhdMJ9zHZPUZIkDnS8FujfBblydkkiHmP9qy5LrhwakD1w6mkmZluS24ALNLG/Q/epKgQiCi6Sa/aL9sndVK5MDV774Cu6KA6m3E125FlmPB5Czu5+3GOIdazNSyy7FNZZgIcjQumW4Sr/3rVtCVhR7oDBeT+haX14Au7ot+3nCtDEpedcDMaFRnyDyGKFCYjfLHfuA==
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Q3gwOEcxRGROKzBSU3MrM0V1TDZuSkRCREJUekZISC93c2tmQzVqcXNTa2RQ?=
 =?utf-8?B?MUtzbGVxeWhnTUhXazk0OUo4bWI5YlFianZlWGxqVzNNNjVpdjhBSU9lWHQ3?=
 =?utf-8?B?R2EwbVBsclF0Z0ZQOWVuZWw2N0VGbmJGSUZKczYxeElxOWMvL2FOODd0amRL?=
 =?utf-8?B?ZXUxK1BqQ0lKb1RFSW5tMkF0dTgwdGR5V2hsYzh3N29McnMxR20vcnR5NDE1?=
 =?utf-8?B?ZDNmbk5PWVprNDh3MzBhMlZrcXpmQzVkUTFtdEc0Tm5nRTVvK2YydkhxakEy?=
 =?utf-8?B?Mm5PQzNaNm4zdTl5d3JKVk5oYWNOSUY4QzQ2SHdmYWQrbkZuOTJlU1pMa1po?=
 =?utf-8?B?RUhNd0JZc1U2Z2oxMm5tT1g2VDV6UXlWSWdwYnBENXZGaE1VQkVCR3dLOUY2?=
 =?utf-8?B?aFdSMWo1WXVzVUdhckQ3dHM2cU8ydGVaZWV5bXpQU2x3TjEvOEJTemVQSS92?=
 =?utf-8?B?U3NyT2s3emRyUVE0MXFsUUZtRzBpSTN5T1pGd2V6bnpXcEt5YkR0VG14ZU9W?=
 =?utf-8?B?WUtzZHBmOGdEc2liRGh4c3ZRd0Y3MTM2Z0lqN2hUL1FBUVVBdGVoOXNhd05v?=
 =?utf-8?B?VFh0bEkwNXVxT2VHL1ZOUGluUjUwMXVwQmgzT0ppbXFzMkQ4SGNST0t4RVRa?=
 =?utf-8?B?dnlMTUVXYWxVWVJkb0lmRGtzb09rYVppOXdwVW1VL0VWRzFnVjRjRk1LemhW?=
 =?utf-8?B?ZG5tK1lFUTlGS240NW4yMEhCcHNhNVAyZkM2WnBHZ1Y4TUcxK09uK0x3NGx3?=
 =?utf-8?B?a2hxSDI5TkNSemhZS1pJbWFILzg0a21GYnZyM2V1SkpWbU9BSyt5ZGd0dDNV?=
 =?utf-8?B?c3lib1RnZVdZV3RtcnVHdTErT0YwUlFGWEFnaFF5TlNEdmZPaStoRmp1NFJI?=
 =?utf-8?B?ZkJEcnVoSnJWWHJORk91RjIxK3RCMlNDSS9iTmNlMEZiTTRucGxCQUx6aDI5?=
 =?utf-8?B?cjdMWEFGdE1zYWJQUDVOaWNMaFhVR081emNYTjdqRlpKVzBSTkpqZU1TdGxx?=
 =?utf-8?B?VVpVUXhoK2tpNnY2NFdneSt4TUo5VUo5NkU3Q0xQY0Fhb0tsS1pkME4rb2oy?=
 =?utf-8?B?cFVWQVVBTjlKZGhqNlk0RTBBRDk2MTc1bk4zL2QzMStON2dNalV5UGFiQXBm?=
 =?utf-8?B?RHE2S2FhdDlkUlF2U3dNVDFpM0NHbjh4ZzVtdnh2YzFXaXdDdWRCd3UvRWto?=
 =?utf-8?B?MGFDcXEwQ3U2MUtwRE0xSVRkSExleDB6a0tLWVM0eUZoRC9WMCtyZ2lVNGRa?=
 =?utf-8?B?aUY0MWlQeVBsMm8vMjRjWE92cW1ESldmelNLNHlVY0FvOUpKU2RUbUpFVkEv?=
 =?utf-8?B?TVRORm5Cd1ArODhiRjRodVFWanM3bWNEU00waVRMR20ybmFxVkRmc0RvY3lO?=
 =?utf-8?B?Yi9SYVFveThrcDM4QjdYUTBpZnRPUGFseDlmaEYzQnJ6eGJQVVNFKzczOVFK?=
 =?utf-8?B?MHY4b01tNk8xbnVEOTNXK3JMTkdpY01MZnQreDdxVnZSbjB6SG03T09FS1VZ?=
 =?utf-8?B?ek83RVltakdSVytvUmxLQU5GV3ZGNGN3a1NSbnBMOWlZVVVsZUVHdHRvM0J6?=
 =?utf-8?B?R3hTRHVLOVZON3FRTEgvMHdaTTQ2YjdubzBQY1ZhQjZPbUdrTkJzak4xRksv?=
 =?utf-8?Q?nxSQ9N6Znt4UwtPPpi5k+m1CiB+fQ7cLSd9juEzJKcyk=3D?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fd729d1e-4d84-4eed-37b3-08dc1d9f55eb
X-MS-Exchange-CrossTenant-AuthSource: MA0P287MB2822.INDP287.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2024 12:15:36.0400
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PN3P287MB2619

hi, Annan, I see another email with same title, any difference between 
them two? Which one you want us to review? Maybe you should void one of 
them.

On 2024/1/25 17:46, AnnanLiu wrote:
> Add the watchdog device tree node to cv1800 SoC.
>
> Signed-off-by: AnnanLiu <annan.liu.xdu@outlook.com>
> ---
> This patch depends on the clk driver and reset driver.
> Clk driver link:
> https://lore.kernel.org/all/IA1PR20MB49539CDAD9A268CBF6CA184BBB9FA@IA1PR20MB4953.namprd20.prod.outlook.com/
> Reset driver link:
> https://lore.kernel.org/all/20231113005503.2423-1-jszhang@kernel.org/
>
> Changes since v1:
> - Change the name of the watchdog from watchdog0 to watchdog.
> - Change the status of watchdog.
> v1 link:
> https://lore.kernel.org/all/DM6PR20MB23160B8499CC2BFDAE6FCACDAB9EA@DM6PR20MB2316.namprd20.prod.outlook.com/
>
>
>   arch/riscv/boot/dts/sophgo/cv1800b-milkv-duo.dts |  4 ++++
>   arch/riscv/boot/dts/sophgo/cv1800b.dtsi          | 16 ++++++++++++++++
>   2 files changed, 20 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/sophgo/cv1800b-milkv-duo.dts b/arch/riscv/boot/dts/sophgo/cv1800b-milkv-duo.dts
> index 3af9e34b3bc7..75469161bfff 100644
> --- a/arch/riscv/boot/dts/sophgo/cv1800b-milkv-duo.dts
> +++ b/arch/riscv/boot/dts/sophgo/cv1800b-milkv-duo.dts
> @@ -36,3 +36,7 @@ &osc {
>   &uart0 {
>   	status = "okay";
>   };
> +
> +&watchdog {
> +	status = "okay";
> +};
> diff --git a/arch/riscv/boot/dts/sophgo/cv1800b.dtsi b/arch/riscv/boot/dts/sophgo/cv1800b.dtsi
> index aec6401a467b..03ca32cd37b6 100644
> --- a/arch/riscv/boot/dts/sophgo/cv1800b.dtsi
> +++ b/arch/riscv/boot/dts/sophgo/cv1800b.dtsi
> @@ -1,6 +1,7 @@
>   // SPDX-License-Identifier: (GPL-2.0 OR MIT)
>   /*
>    * Copyright (C) 2023 Jisheng Zhang <jszhang@kernel.org>
> + * Copyright (C) 2024 Annan Liu <annan.liu.xdu@outlook.com>
>    */
>   
>   #include <dt-bindings/interrupt-controller/irq.h>
> @@ -103,6 +104,21 @@ uart4: serial@41c0000 {
>   			status = "disabled";
>   		};
>   
> +		watchdog: watchdog@3010000{
> +			compatible = "snps,dw-wdt";
> +			reg = <0x3010000 0x100>;
> +			interrupts = <58 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&pclk>;
> +			resets = <&rst RST_WDT>;
> +			status = "disabled";
> +		};
> +
> +		pclk: pclk {
> +			#clock-cells = <0>;
> +			compatible = "fixed-clock";
> +			clock-frequency = <25000000>;
> +		};
> +
>   		plic: interrupt-controller@70000000 {
>   			compatible = "sophgo,cv1800b-plic", "thead,c900-plic";
>   			reg = <0x70000000 0x4000000>;