Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp1730689rdb; Thu, 25 Jan 2024 04:40:40 -0800 (PST) X-Google-Smtp-Source: AGHT+IEeOJjOrPS8s9cCYj8B46SupjxIT09jccfj2spqNKrDS8E5xKZSKTuBhaHl1c6cCM8BU7rV X-Received: by 2002:a05:6214:20e3:b0:686:ad1d:b93b with SMTP id 3-20020a05621420e300b00686ad1db93bmr974107qvk.108.1706186436038; Thu, 25 Jan 2024 04:40:36 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706186436; cv=pass; d=google.com; s=arc-20160816; b=h8bFtQMm8yXZswRVdGUce90ufIOej8bh0jy6PI5AMjw73HKA2DY2tZ2H58pQ5NxtcE SP8fz52mFu2esCMWd9p2s92xxlEM9ZaRtTuxO9v8Ngm/YXApFzTO6zQEcbkT23DEw7nU ydFUaXxu24pikPzCSPBHu2HClykwBtHmGqDRW7ktQ1P7046I5UdXIkq6R1UX9dMmmcPn SnYtWf379U4eO367UziibpOpDnVreDtz/llyMgRZzHmaqylFzqSDD70m15B3YNc6G46x TvhWdBAYAaiYGLiZExMN8Lzfq0xmD+VkrrRB+a08Y2bs3N8Sr9hVVdRIheN/pB0HXZK6 cHCA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=aI26vRplbW/GhCDXdm3Ni3HuWgNba2vGputrnlHeaAI=; fh=KZb2efZKdFRKMebIgHmTrtqFQo5g6F6RT9JQ9ML9QLs=; b=sR6IZLvUf/yU8v/C9KsIOdPH+bF0mXYsXeXwMvAPGC1ptSSdxYAwBQFDJSWGgUuHq/ 2t+EkmK7R2lHa5Yfg7J5MM2JY/0BIfi+MY0Dw79DsWchq/tdxTyuKjWSbrapJZUa6FW3 6stvxb1/8zhqz8NTK3vLPCFkvAvgKpCTddvBLpQ6ikH8HSu8I2uO+FWePeLIH510jXBu arlnPvmYEGHn7m05LnzQ5VxnTu9gFXljVtcvjf7Ki8h3JN5Vj66PwlCV/154YV+5G1yj nZFKAWqS8OwD5+OkEAWJE9fO61CKssOGhOpeowuMwd3eGbAl0mDkiXxST5cxnxhZtFfG XMvQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=n+6cKDfQ; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-38588-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38588-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id f20-20020a0cf3d4000000b006819af3d21asi12483614qvm.225.2024.01.25.04.40.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 04:40:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-38588-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=n+6cKDfQ; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-38588-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38588-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 129F81C2264C for ; Thu, 25 Jan 2024 12:40:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 53CB0481B9; Thu, 25 Jan 2024 12:40:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="n+6cKDfQ" Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEE2D37156 for ; Thu, 25 Jan 2024 12:39:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706186399; cv=none; b=Zr+aQ8T+iItwG7EW5d8Hn5u2V9KkKf4oaiPplHAqodUXe253lyiM2okzjHZc4dZe0kuyVUY1mrkSAcPy0VEZynWMI/vI4VE64IwYX60LJRau6VQ0Fj/k1Bn3LVadOyHf9kwP27h4j4T3qddN9vwYFjRuYnq38JXwqY1pK+8gwDw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706186399; c=relaxed/simple; bh=3ZuFOmti85kuqvIz9g1ji4HzpXornAinhau/HWMF6mM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=s1WB5FvVgq1wtBAf1+/uRvSo2An1xURAE3iDsOLpKBPEULMwSX4RKaFb/MpX0UViPasvgYp9crXBhxvSvwWBrhgSGr8z5wJ1BA7CjR75RiKDp2ng2Ym6W73cbjPLShXJOclKtv3IqpGDfHKGFRiJ5FeMSMl+MDuW0J8VhYjGwGk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=n+6cKDfQ; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-5100c3f7df1so3467523e87.0 for ; Thu, 25 Jan 2024 04:39:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706186396; x=1706791196; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aI26vRplbW/GhCDXdm3Ni3HuWgNba2vGputrnlHeaAI=; b=n+6cKDfQh73UBSwCOW/4Ic3z0CNvfGr49V9TYw3atazwaTpILOtoNWk2UqZRiAaROD iruiZpECBVnZkKhKd8iFmonTr/KAvzrLoN622qblwjxFMKgJtVY+ZOfInJVHe+Gr1Y9C dZqlGe1nCOSBQx3e36u3QwSQ7XjOQQx8t6k12ZCIL1CWyCekXSSXfmF91Yu5TNlzE1pV 3IrvnQ7GGwBsMumn8vs9RZO8AMDUPXsH9A4h6jw5yAc5yARNLDYQuaful2J6nx+rUIHY L/efMGzP2FOj3XSAxIcipBY4fTcqVQ9EJz39Hj1IdmOJAuQqaMMxwWrKh19gwr2w3AD+ Xdrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706186396; x=1706791196; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aI26vRplbW/GhCDXdm3Ni3HuWgNba2vGputrnlHeaAI=; b=Z2p/38K33FYgxp8GuEiPNY0ZwwE9PtbCsspXdHwUntG3XvF5E4pWu3nfQCCfqw9zJV pKJnLW10autcqlo9Sl1gKjw3EiiAWmit0pxD20XawhhdOHhOAEX4LxEjGhlz3HhNdzcH a5fRyu/1pVHDHMaVVRibV59/QAipLslSkPoq/8YRnjIsHhVmBv/n1nWJJldfpSjoGxaw ZnqyrAMUNtXxVlzmcH6NLbSksDzy7NP8PCNoZHYarY6FT1b9dFqXMbu4YAOcSbhk+VyB o+xhSpoLgG2gD1RHghB0VkcYC624iIqYlpu5G9J4sPdImA2McSNr3CrlCwEZPScyxG4Z vLyg== X-Gm-Message-State: AOJu0Yyx5fC5qVWxQk6jj4MB6edPgFA3jNxKnqcj/GttNk9XWeHjDO2L Wfvu7mD6+6SlwEeHUbMtRJvBEwz490HKwFH8Ae64LYat5kD485b4j4wGiLiCjrw= X-Received: by 2002:a05:6512:3a8f:b0:50e:7dd5:e5f0 with SMTP id q15-20020a0565123a8f00b0050e7dd5e5f0mr1035333lfu.12.1706186395866; Thu, 25 Jan 2024 04:39:55 -0800 (PST) Received: from [192.168.1.20] ([178.197.215.66]) by smtp.gmail.com with ESMTPSA id t16-20020a192d50000000b0050ea9654654sm2930763lft.176.2024.01.25.04.39.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jan 2024 04:39:55 -0800 (PST) Message-ID: <9f9a1f5f-2104-4a5c-a837-cd8d18e173d6@linaro.org> Date: Thu, 25 Jan 2024 13:39:51 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] riscv: dts: sophgo: add watchdog dt node for CV1800 Content-Language: en-US To: AnnanLiu , chao.wei@sophgo.com, unicorn_wang@outlook.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org Cc: paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org References: From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 25/01/2024 10:46, AnnanLiu wrote: > + > + pclk: pclk { > + #clock-cells = <0>; > + compatible = "fixed-clock"; > + clock-frequency = <25000000>; It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ for instructions). Also, why do you describe internal clock as stub? Best regards, Krzysztof