Received-SPF: pass (google.com: domain of linux-kernel+bounces-38344-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 25 Jan 2024 01:53:14 -0800
From: Ashok Raj <ashok_raj@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, x86@kernel.org,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Arjan van de Ven <arjan@linux.intel.com>,
	Huang Rui <ray.huang@amd.com>, Juergen Gross <jgross@suse.com>,
	Dimitri Sivanich <dimitri.sivanich@hpe.com>,
	Sohil Mehta <sohil.mehta@intel.com>,
	K Prateek Nayak <kprateek.nayak@amd.com>,
	Kan Liang <kan.liang@linux.intel.com>,
	Zhang Rui <rui.zhang@intel.com>,
	"Paul E. McKenney" <paulmck@kernel.org>,
	Feng Tang <feng.tang@intel.com>,
	Andy Shevchenko <andy@infradead.org>,
	Michael Kelley <mhklinux@outlook.com>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Wei Liu <wei.liu@kernel.org>, Ashok Raj <ashok.raj@intel.com>
Subject: Re: [patch V2 01/22] x86/cpu/topology: Make the APIC mismatch
 warnings complete
Message-ID: <ZbIvis3zHeQLZerL@araj-dh-work.jf.intel.com>
References: <20240117124704.044462658@linutronix.de>
 <20240117124902.403342409@linutronix.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240117124902.403342409@linutronix.de>

On Tue, Jan 23, 2024 at 02:10:04PM +0100, Thomas Gleixner wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
> 
> Detect all possible combinations of mismatch right in the CPUID evaluation
> code.
> 
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> 
> ---
>  arch/x86/include/asm/apic.h           |    5 ++---
>  arch/x86/kernel/cpu/common.c          |   15 ++-------------
>  arch/x86/kernel/cpu/topology_common.c |   12 ++++++++++++
>  3 files changed, 16 insertions(+), 16 deletions(-)

[snip]

> --- a/arch/x86/kernel/cpu/topology_common.c
> +++ b/arch/x86/kernel/cpu/topology_common.c
> @@ -177,6 +177,18 @@ void cpu_parse_topology(struct cpuinfo_x
>  
>  	parse_topology(&tscan, false);
>  
> +	if (IS_ENABLED(CONFIG_X86_LOCAL_APIC)) {
> +		if (c->topo.initial_apicid != c->topo.apicid) {
> +			pr_err(FW_BUG "CPU%4u: APIC ID mismatch. CPUID: 0x%04x APIC: 0x%04x\n",
> +			       cpu, c->topo.initial_apicid, c->topo.apicid);
> +		}
> +
> +		if (c->topo.apicid != cpuid_to_apicid[cpu]) {
> +			pr_err(FW_BUG "CPU%4u: APIC ID mismatch. Firmware: 0x%04x APIC: 0x%04x\n",
> +			       cpu, cpuid_to_apicid[cpu], c->topo.apicid);
> +		}

Should we consider tainting the kernel when there is any mismatch?