Received-SPF: pass (google.com: domain of linux-kernel+bounces-38602-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <CAK1f24mZcxdxKA5hyNaMy-jX=dGtEoZEY8imXKrTnZ0EC61_gw@mail.gmail.com>
 <c9b4dfc0-19b9-4e19-b681-e2fab63f41e8@redhat.com>
In-Reply-To: <c9b4dfc0-19b9-4e19-b681-e2fab63f41e8@redhat.com>
From: Lance Yang <ioworker0@gmail.com>
Date: Thu, 25 Jan 2024 21:03:12 +0800
Message-ID: <CAK1f24kg+c9XQruTjask+2LLXE6A3OHsRKdVq6-gVbNVV0jS9g@mail.gmail.com>
Subject: Re: [Issue] mprotect+madvise may be better than mmap for permission
 changes and page zeroing
To: David Hildenbrand <david@redhat.com>
Cc: linux-kernel@vger.kernel.org, Michal Hocko <mhocko@suse.com>, linux-mm@kvack.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Thanks!

On Thu, Jan 25, 2024 at 8:44=E2=80=AFPM David Hildenbrand <david@redhat.com=
> wrote:
>
> On 25.01.24 13:28, Lance Yang wrote:
> > Hello Everyone,
> >
> > I've noticed that using mprotect(PROT_NONE) with
> > madvise(MADV_DONTNEED) is much faster than
> > mmap(PROT_NONE, MAP_FIXED) alone for changing
> > permissions and zeroing pages.
> >
> > I have maintained a chunk-allocator internally at the
> > company. It allocates a chunk using
> > mmap(PROT_READ|PROT_WRITE, MAP_ANON|MAP_PRIVATE, -1, 0),
> > releases a chunk using mmap(PROT_NONE, MAP_ANON|MAP_FIXED|MAP_PRIVATE, =
-1, 0),
> > and reuses a chunk using mprotect(PROT_READ|PROT_WRITE).
> > Recently, I replaced mmap(PROT_NONE, MAP_FIXED) with
> > mprotect(PROT_NONE) + madvise(MADV_DONTNEED) to
> > reduce the latency of releasing chunks.
> >
> > Test code:
> > https://github.com/ioworker0/mmapvsmprotect/blob/main/test2.c
> >
> > Here are the test results on my machine:
> > CPU: AMD EPYC 7R13 Processor
> > Kernel: 6.2.0
> > Elapsed Time for mprotect+madvise: 3670 nanoseconds
> > Elapsed Time for mmap: 5520 nanoseconds
>
> mprotect+madvise won't free page tables, mmap will. That's the biggest
> difference.
>
> --
> Cheers,
>
> David / dhildenb
>