Received-SPF: pass (google.com: domain of linux-kernel+bounces-38611-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Thu, 25 Jan 2024 15:04:01 +0200 (EET)
To: Ashok Raj <ashok.raj@intel.com>
cc: Hans de Goede <hdegoede@redhat.com>, markgross@kernel.org, 
    Jithu Joseph <jithu.joseph@intel.com>, rostedt@goodmis.org, 
    tony.luck@intel.com, LKML <linux-kernel@vger.kernel.org>, 
    platform-driver-x86@vger.kernel.org, patches@lists.linux.dev, 
    pengfei.xu@intel.com
Subject: Re: [PATCH 1/5] platform/x86/intel/ifs: Call release_firmware() when
 handling errors.
In-Reply-To: <20240125082254.424859-2-ashok.raj@intel.com>
Message-ID: <497dbb51-e583-374f-b31a-e14f1253c93f@linux.intel.com>
References: <20240125082254.424859-1-ashok.raj@intel.com> <20240125082254.424859-2-ashok.raj@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323328-1915214704-1706187841=:1444"

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-1915214704-1706187841=:1444
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE

On Thu, 25 Jan 2024, Ashok Raj wrote:

> From: Jithu Joseph <jithu.joseph@intel.com>
>=20
> Missing release_firmware() due to error handling blocked any future image
> loading.
>=20
> Fix the return code and release_fiwmare() to release the bad image.
>=20
> Fixes: 25a76dbb36dd ("platform/x86/intel/ifs: Validate image size")
> Reported-by: Pengfei Xu <pengfei.xu@intel.com>
> Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>
> Signed-off-by: Ashok Raj <ashok.raj@intel.com>
> Tested-by: Pengfei Xu <pengfei.xu@intel.com>
> Reviewed-by: Tony Luck <tony.luck@intel.com>
> ---
>  drivers/platform/x86/intel/ifs/load.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/platform/x86/intel/ifs/load.c b/drivers/platform/x86=
/intel/ifs/load.c
> index a1ee1a74fc3c..2cf3b4a8813f 100644
> --- a/drivers/platform/x86/intel/ifs/load.c
> +++ b/drivers/platform/x86/intel/ifs/load.c
> @@ -399,7 +399,8 @@ int ifs_load_firmware(struct device *dev)
>  =09if (fw->size !=3D expected_size) {
>  =09=09dev_err(dev, "File size mismatch (expected %u, actual %zu). Corrup=
ted IFS image.\n",
>  =09=09=09expected_size, fw->size);
> -=09=09return -EINVAL;
> +=09=09ret =3D -EINVAL;
> +=09=09goto release;
>  =09}
> =20
>  =09ret =3D image_sanity_check(dev, (struct microcode_header_intel *)fw->=
data);
>=20

Reviewed-by: Ilpo J=E4rvinen <ilpo.jarvinen@linux.intel.com>

--=20
 i.

--8323328-1915214704-1706187841=:1444--