Received-SPF: pass (google.com: domain of linux-kernel+bounces-38654-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 25 Jan 2024 13:32:33 +0000
From: Mark Brown <broonie@kernel.org>
To: Sam Protsenko <semen.protsenko@linaro.org>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>, andi.shyti@kernel.org,
	arnd@arndb.de, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	alim.akhtar@samsung.com, linux-spi@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-arch@vger.kernel.org, andre.draszik@linaro.org,
	peter.griffin@linaro.org, kernel-team@android.com,
	willmcvicker@google.com
Subject: Re: [PATCH 19/21] spi: s3c64xx: add support for google,gs101-spi
Message-ID: <35ba5720-5629-49f1-b00c-af9620941136@sirena.org.uk>
References: <20240123153421.715951-1-tudor.ambarus@linaro.org>
 <20240123153421.715951-20-tudor.ambarus@linaro.org>
 <CAPLW+4=5ra6rBRwYYckzutawJoGw_kJahLaYmDzct2Dyuw0qQg@mail.gmail.com>
 <ab53dbc6-dad5-4278-a1d2-9f963d08eedc@linaro.org>
 <CAPLW+4njDgYO6bxVAL6hc-b_bVxjKcJnYpNGcNGpFsFg1LMc-Q@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="AcxqL1s+K3PbRcVC"
Content-Disposition: inline
In-Reply-To: <CAPLW+4njDgYO6bxVAL6hc-b_bVxjKcJnYpNGcNGpFsFg1LMc-Q@mail.gmail.com>


--AcxqL1s+K3PbRcVC
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jan 24, 2024 at 01:43:55PM -0600, Sam Protsenko wrote:
> On Wed, Jan 24, 2024 at 4:40=E2=80=AFAM Tudor Ambarus <tudor.ambarus@lina=
ro.org> wrote:

> > Using fifo_lvl_mask works but is wrong on multiple levels.
> > As the code is now, the device tree spi alias is used as an index in the
> > fifo_lvl_mask to determine the FIFO depth. I find it unacceptable to
> > have a dependency on an alias in a driver. Not specifying an alias will
> > make the probe fail, which is even worse. Also, the fifo_lvl_mask value

> Ok, I think that's a valid point. I probably missed the alias part
> when reading the patch description. I also understand we can't just
> remove .fifo_lvl_mask right now, as we have to keep the compatibility
> with older/existing out-of-tree device trees, so that the user can
> update the kernel image separately.

I don't really agree here, for a given compatible the FIFO depth is
known so it's redundant to specify and it's much simpler to correct
issues if we're not overspecifying things in the DT.

--AcxqL1s+K3PbRcVC
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmWyYvAACgkQJNaLcl1U
h9BlgQf/Xdw28Bk0fuzTPm7i+VBHJsXK9DXdWVOFi8ljHWjtPGlXeC4cZW2qkurt
Fe/famGMO9Iqn8cYs4yhUSxzSHyw89fa8LvDQ0CMc/cTknazpwVkhYTnLk/nfzfL
WnkW9ckkW5iYVRZllulIqEt/k//15OspS8RdqHjffQ7QliWo8LdbUVvOMwco7rf2
bngAQX/PZ6Q5RohNBaPxQa1sVfGf8HZ+ESdqYNS/cAr2Ogjv19cli3pDE3YtIXU9
bmImCIB4NttsvLu2gtrGb8zLLRzCN7ECwKxW+QBsBbCasi8uxgq0s7ytxhb4r93R
SN/VwfnJQJRWIDRrggTwPJErBlxbSw==
=+29v
-----END PGP SIGNATURE-----

--AcxqL1s+K3PbRcVC--