Received-SPF: pass (google.com: domain of linux-kernel+bounces-38672-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Thu, 25 Jan 2024 09:43:37 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: Joel Granados <j.granados@samsung.com>
Cc: Lu Baolu <baolu.lu@linux.intel.com>, Joerg Roedel <joro@8bytes.org>,
	Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>,
	Kevin Tian <kevin.tian@intel.com>,
	Jean-Philippe Brucker <jean-philippe@linaro.org>,
	Nicolin Chen <nicolinc@nvidia.com>, Yi Liu <yi.l.liu@intel.com>,
	Jacob Pan <jacob.jun.pan@linux.intel.com>,
	Longfang Liu <liulongfang@huawei.com>,
	Yan Zhao <yan.y.zhao@intel.com>, iommu@lists.linux.dev,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v10 01/16] iommu: Move iommu fault data to linux/iommu.h
Message-ID: <20240125134337.GN1455070@nvidia.com>
References: <20240122054308.23901-1-baolu.lu@linux.intel.com>
 <20240122054308.23901-2-baolu.lu@linux.intel.com>
 <CGME20240125091737eucas1p2091d853e27e669b3b12cea8ee3bbe34e@eucas1p2.samsung.com>
 <20240125091734.chekvxgof2d5zpcg@localhost>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240125091734.chekvxgof2d5zpcg@localhost>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?FQtehZrnP5OxHGZ1Bo3KEO09bSlp89vcwEMXKNCWCWeNa9yrVujrQehkJzqx?=
 =?us-ascii?Q?789sMy7aYgg2qlNzQOSokMwpL8ugBEfJs8TCFNWLleTQuBH1Y30WsUhtb/1A?=
 =?us-ascii?Q?Wiuv//W15VC4MXcT9jjh/Hhnmb9rWp2Q85KLb+/m72R9SbYyJ+ni3ANHOGXd?=
 =?us-ascii?Q?YJl0llHDmdPDASezMzQ9X6oaomOOCLD7KTHMKTffMmhHj7+rBFZytQNrze1n?=
 =?us-ascii?Q?EqKmX6/6D+Fnqn9v/flHxmdYhpuw3GBN8+EDr8M08fn3jBzwVVTE/WzuedK/?=
 =?us-ascii?Q?GAJomQVR9vq6AwI/SwInexuVI0tf3AHgTSNbaalNo37yEeMTm7lTHQ5FHiTt?=
 =?us-ascii?Q?E7dj+IPLdL6X1031ClbR0crozyGukumHib59Gu1XADOpnOPrsSEu6Cz+kxNw?=
 =?us-ascii?Q?OJdCFe4HpHoCyb/seYnO25PqPTVZdwuO5IUFGApX9T6Al8sZPLXmFdoF/jBi?=
 =?us-ascii?Q?oCOORH2Bi93dSJ707xFhDpRXP52FuEaZgLgwDr6YZZUXulZ2aiLovq41bGW7?=
 =?us-ascii?Q?3pfGMdMasjCXroF3xaLo8FI7ZQ91ENi3W+VMq+4YP/y1IjubaG2SeYF0ZjrZ?=
 =?us-ascii?Q?1UDC0RHRRPJrr+ZXi+PadV45CzZJWmP/aZkmN8U18hGl2/qpm6SLcFGThfi2?=
 =?us-ascii?Q?dIHhU8FShpmbPlJRhBIfjrX/aaORiKEqED6GgwPXjxFyCtKXX0vq0XKP64yK?=
 =?us-ascii?Q?bv1yeAaqmQ0OgOcRH9XhKjEsPN0mx6jdh2YPOAmDUnfuFg/iPlpCRc/QaCkh?=
 =?us-ascii?Q?6olQpYVkbMFwA7qOe4UnXUm4UnQ7xmwYTE1WCNxTT3inNzKWyiWiAA1ZyiSN?=
 =?us-ascii?Q?IDf5m/b3jgBeunzJJTM6KyjRVCbP0ON44OrzdpTf0j1LvQVGZKgWeUcpVFLj?=
 =?us-ascii?Q?w03SYBz+E263b1vjvs7jgEdYZBf88W8aMmhqEkPYvGucMRgVb5jLkWgkHA9o?=
 =?us-ascii?Q?rzRe9lrPhGV239doKYFKgmSkT/Mm7BDfEFMIoZV6O84wq8jXJop5ESGniACN?=
 =?us-ascii?Q?fbOjYdO2DBQaHwrNQ7Y6+9V6tSJH0hi9zU3l4ilq3dQtEaeO6rdfUe+P7Poc?=
 =?us-ascii?Q?FIu2j0LGJHxmcw5U9no3A02310q5DYDAdgXwWtKNuTgWiEAUFOs0geHtI1YD?=
 =?us-ascii?Q?x4BQSPj8/9E4McfvigVmlFhye04IbIgqBUflnHlHJzlYFiCBlDEiJLxIPeMY?=
 =?us-ascii?Q?NYEn5336vZVaMu8IV2y+dDaVhBl4uMgYKlmilZRfPmefoqrKyUCOQt+/6hwQ?=
 =?us-ascii?Q?Y91QSh36CmXvG2Kr0plljlAfm1e7+rz6ya+ICF3+w9mwdhqLtDkUnMbDVAhd?=
 =?us-ascii?Q?iuBnMhc4E98WetUBILvDBUMi7a4/vMZsClRext7364fG1ruBTjnDVC6KxiXu?=
 =?us-ascii?Q?l5IE5kzG2v4tCGPIadbiJKKy28OSunQYTi9J4yE3VtfA+gnQ0/m1gTlEWYVu?=
 =?us-ascii?Q?p5V6vs+fQnbV9dqM5k8cbkyPjCd8tpHdl4mrOx/MwlabvrtXLv0bXANqaiIN?=
 =?us-ascii?Q?jXjvHILfAz750ujrs1C3rlpy5Cz82KsSjnDfbJLEwvpug85p34euxeI8rvtS?=
 =?us-ascii?Q?kRsFIcQsmbPofW0HA7YGusYwfUqQr8pjWEkfKyUp?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 44fdaf58-2950-449a-1b9f-08dc1daba20f
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2024 13:43:37.6195
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yIKvQZp9k1Ars97fJ84b7MXLz4270aYc/XsQGSinTtd2EDwSHvxgS2TFN3sGPxfz
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6304

On Thu, Jan 25, 2024 at 10:17:34AM +0100, Joel Granados wrote:
> On Mon, Jan 22, 2024 at 01:42:53PM +0800, Lu Baolu wrote:
> > The iommu fault data is currently defined in uapi/linux/iommu.h, but is
> > only used inside the iommu subsystem. Move it to linux/iommu.h, where it
> > will be more accessible to kernel drivers.
> > 
> > With this done, uapi/linux/iommu.h becomes empty and can be removed from
> > the tree.
> 
> The reason for removing this [1] is that it is only being used by
> internal code in the kernel. What happens with usespace code that have
> used these definitions? Should we deprecate instead of just removing?

There was never an in-tree kernel implementation. Any userspace that
implemented this needs to decide on its own if it will continue to
support the non-mainline kernel and provide a copy of the definitions
itself..

(it was a process mistake to merge a uapi header without a
corresponding uapi implementation, sorry)

Jason