Received-SPF: pass (google.com: domain of linux-kernel+bounces-38674-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Thu, 25 Jan 2024 07:44:11 -0600
From: Nishanth Menon <nm@ti.com>
To: Chintan Vankar <c-vankar@ti.com>
CC: Conor Dooley <conor+dt@kernel.org>,
        Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>, Tero
 Kristo <kristo@kernel.org>,
        Vignesh Raghavendra <vigneshr@ti.com>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
        <afd@ti.com>, <srk@ti.com>, <s-vadapalli@ti.com>,
        <r-gunasekaran@ti.com>, <danishanwar@ti.com>, <tony@atomide.com>,
        Jayesh Choudhary <j-choudhary@ti.com>
Subject: Re: [PATCH v2 2/5] arm64: dts: ti: k3-j784s4: Add Main CPSW2G node
Message-ID: <20240125134411.nzw7mou7cth7hh4m@postage>
References: <20240118094454.2656734-1-c-vankar@ti.com>
 <20240118094454.2656734-3-c-vankar@ti.com>
 <20240119131810.2qg2zkb3xi4km74q@irritable>
 <51317410-ae05-45ab-a0d3-3bcb5e925122@ti.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <51317410-ae05-45ab-a0d3-3bcb5e925122@ti.com>

On 15:02-20240125, Chintan Vankar wrote:
> 
> On 19/01/24 18:48, Nishanth Menon wrote:
> > On 15:14-20240118, Chintan Vankar wrote:
> > > From: Siddharth Vadapalli<s-vadapalli@ti.com>
> > > 
> > > J784S4 SoC has a Main CPSW2G instance of the CPSW Ethernet Switch.
> > > 
> > > Add the device-tree nodes for the Main CPSW2G instance and enable it.
> > > 
> > > Signed-off-by: Siddharth Vadapalli<s-vadapalli@ti.com>
> > > Signed-off-by: Jayesh Choudhary<j-choudhary@ti.com>
> > > Signed-off-by: Chintan Vankar<c-vankar@ti.com>
> > > ---
> > >   arch/arm64/boot/dts/ti/k3-j784s4-evm.dts   | 47 +++++++++++++++
> > >   arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 68 ++++++++++++++++++++++
> > >   2 files changed, 115 insertions(+)
> > Please do not mix the SoC and evm changes in the same patch.
> Okay. I will separate them in the v3 series
> > Also, any benefits of giving the second instance an alias?
> 
> Yes, there are benefits of adding an alias,
> 
> I will add aliases for both Main and MCU cpsw2g,
> 
> and post it in a future series.

If there is benefit, squash to current patch.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D