Received: by 2002:a05:7412:5112:b0:fa:6e18:a558 with SMTP id fm18csp1770031rdb; Thu, 25 Jan 2024 05:51:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IHrYSAdzp6Op4Otkhq1KQZ/Dx2Bu91WePb0pd9Ol+kNYm/9T4TVaxAzM0SDN8pg4vIKlt7G X-Received: by 2002:a05:6808:2e88:b0:3bd:36fc:1c1e with SMTP id gt8-20020a0568082e8800b003bd36fc1c1emr994989oib.44.1706190682963; Thu, 25 Jan 2024 05:51:22 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706190682; cv=pass; d=google.com; s=arc-20160816; b=QmyXWc2fxqhkr5uBhrXUNc/JF7XNjQRFtJ3k3Ay0QTTIuZtL1v1gwpaP81GksmDS4b /vMDw+ZfCkiYzQ8336sPsklwi4NX7MLT8Qtw4Jm05wspq9i7pQmHeSsz8TzajDdmBeu4 Jf+EtFAFh0mpSp2uAr26etzMQs/VFeyWRdfcebtRNboRlrijY/jFvyWkJkbYh3kiBbgI 0TnUl/lKhkuUdzgBf3y+uvIx3aqNvjfRsjcyzmHI2TMXcfLNToUMEmUh+gtqk6bTVRmN 15oX3PHODXXw3/3B6CzFB3cRx1niwHHkVg74VYVbdS1FmARBymb7hFxXf0iLbPlUT6C6 0unw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from:dkim-signature; bh=daYCUmpqd4Q3haosIu+v28dKOrWmqRN0vLagWZC1/38=; fh=zrmuO8f7+hsK9HkQo8YCJVpZSEkb0oY++2GmbgOp12o=; b=BBW+IhlDtkqpJJKiejoK2v/7/zdIkRaCX6xrjwRY6GSNAx2cVSbtSfhP1zq01AKbO+ wYDRKbkZ9j5AmVWIlqzZO9wM5ZTm0eRikGLoqqzyxo8V+VCrgxg70tSb/tfOQfLu+quw 1gHEKHonWryKvatgp84icHrdzdIozvr3+yrw253cCbMddxultGj8t16uo4lNMPIY93Yq 8QDySWJjcpjhfYElVYxtNHG9PGazc0hkzUolJ2YC086tVoW5SvKMk5yIHcZLKPOJYFjE 5mNwzpr2GVgcb6e0GH+AbmM/BdjBH4pBiwUJCtI7eS7/sqYKqaj0u9pGBCkch7PtZTf8 4dSw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="fzyt2/gs"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-38688-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38688-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id j14-20020a05620a410e00b0078393bf21e9si13003251qko.62.2024.01.25.05.51.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 05:51:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-38688-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="fzyt2/gs"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-38688-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38688-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id B20951C221E6 for ; Thu, 25 Jan 2024 13:51:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EAB1F5B214; Thu, 25 Jan 2024 13:51:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fzyt2/gs" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1886A5B204; Thu, 25 Jan 2024 13:51:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706190675; cv=none; b=KSIsmad6SXCiT1i0pMoJehadZ76vkipm6pgwHXW+6S1XmeNXlrphsr920iSVuiQK0DB3vVmCfWqKeM/TLeDRPbFlj6qPLzE/FOstdrVGOdmLzJ3ORCLohyJL6I07B9qO1FSh+a6oakernCIEWHF+VJLPSFr5ztBtv2DDIV8UoeE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706190675; c=relaxed/simple; bh=wH81iS855opiUGjOXv2S6FTtpKNofrQv2CSZAxYC3/k=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=XuS9yd/it7VNNy7wFnUy15ZpQKrLQCXg9jD0o4okLSdW10qskDXyH+aqApGQT8EWKIZe8++/DVPjtjY4n6qnxuvDmAoeubRoZGbLrVq2sEd0lf0rlpZ7SVvnqHiaE0zoq6nD8XT6gSTttzezd6Bp8yXqNuUJu5gRKecrqIFZZEY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fzyt2/gs; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9FC8DC433F1; Thu, 25 Jan 2024 13:51:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706190674; bh=wH81iS855opiUGjOXv2S6FTtpKNofrQv2CSZAxYC3/k=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=fzyt2/gsNccB/ZCejD01UTKlKnbJ/DDRyMh4JuscNZPSrX0Bgt8TItGfPX6z4Qmis MeE60VNLb/zQcqOlYLpSxGqC+4YSfUMpEp1zbVHpfYIba/LwaNoFR0Y49Y2d1ba/4f aa+o1kQjtomqLMHgdPAOdiyAmmnrGMwGVwm6PpHplc8V05zSNJvIvg9C+0V2Es6ty3 EWy/62av6nWIFq5f6caMPyYFUtNmChzhuxwq49D3zJYKwcWTB/WB2YlmKUFjUzul5V I4OiuXKvHow9jE3ajDGgGCibe28VgIgA3t4h4mk7VrD7QLRg0mx5qkPgYV8uvhTsZm M5sdhjzkxIyFQ== From: Lee Jones To: Pavel Machek , Lee Jones , Arnd Bergmann Cc: Andrew Lunn , Arnd Bergmann , Heiner Kallweit , Hans de Goede , Jean-Jacques Hiblot , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20240109090715.982332-1-arnd@kernel.org> References: <20240109090715.982332-1-arnd@kernel.org> Subject: Re: [PATCH 1/2] leds: remove led_init_default_state_get() and devm_led_classdev_register_ext() stubs Message-Id: <170619067236.1476369.7542248214179652574.b4-ty@kernel.org> Date: Thu, 25 Jan 2024 13:51:12 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Mailer: b4 0.12.3 On Tue, 09 Jan 2024 10:06:39 +0100, Arnd Bergmann wrote: > These two functions have stub implementations that are called when > NEW_LEDS and/or LEDS_CLASS are disabled, theorerically allowing drivers > to optionally use the LED subsystem. > > However, this has never really worked because a built-in driver is > unable to link against these functions if the LED class is in a loadable > module. Heiner ran into this problem with a driver that newly gained > a LEDS_CLASS dependency and suggested using an IS_REACHABLE() check. > > [...] Applied, thanks! [1/2] leds: remove led_init_default_state_get() and devm_led_classdev_register_ext() stubs commit: c0b64609dada48907b04b48873ba052efa8f121d [2/2] leds: make flash and multicolor dependencies unconditional commit: 54602f38551e89b520611ffb9df05232d1bf73f8 -- Lee Jones [李琼斯]