Received-SPF: pass (google.com: domain of linux-kernel+bounces-38689-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 25 Jan 2024 13:55:09 +0000
From: Lee Jones <lee@kernel.org>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: broonie@kernel.org, andy.shevchenko@gmail.com,
	patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
	linux-spi@vger.kernel.org
Subject: Re: [PATCH v3 2/6] mfd: cs42l43: Tidy up header includes
Message-ID: <20240125135509.GL74950@google.com>
References: <20240125102555.2621736-1-ckeepax@opensource.cirrus.com>
 <20240125102555.2621736-2-ckeepax@opensource.cirrus.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240125102555.2621736-2-ckeepax@opensource.cirrus.com>

On Thu, 25 Jan 2024, Charles Keepax wrote:

> Use more forward declarations, move header guards to cover other
> includes, and rely less on including headers through other headers.
> 
> Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>

Patches look okay to me, but seeing as Andy suggested the changes, it
would be good to get a R-by from him.

> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> ---
> 
> Changes since v2:
>  - Added pm.h and regmap.h back into mfd/cs42l43.h
> 
> Thanks,
> Charles
> 
>  drivers/mfd/cs42l43-i2c.c   |  6 +++++-
>  drivers/mfd/cs42l43-sdw.c   |  6 +++++-
>  drivers/mfd/cs42l43.c       |  8 +++++++-
>  drivers/mfd/cs42l43.h       | 10 ++++++----
>  include/linux/mfd/cs42l43.h | 13 +++++++------
>  5 files changed, 30 insertions(+), 13 deletions(-)

-- 
Lee Jones [李琼斯]