Received-SPF: pass (google.com: domain of linux-kernel+bounces-38712-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn@kernel.org>
To: Alexei Starovoitov <ast@kernel.org>, Daniel Borkmann
 <daniel@iogearbox.net>, Andrii Nakryiko <andrii@kernel.org>, Mykola
 Lysenko <mykolal@fb.com>, bpf@vger.kernel.org, netdev@vger.kernel.org
Cc: =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn@rivosinc.com>,
 linux-kselftest@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next] selftests/bpf: Include runner extras for
 install target
In-Reply-To: <20240125122715.1443022-1-bjorn@kernel.org>
References: <20240125122715.1443022-1-bjorn@kernel.org>
Date: Thu, 25 Jan 2024 15:17:57 +0100
Message-ID: <87h6j14huy.fsf@all.your.base.are.belong.to.us>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Bj=C3=B6rn T=C3=B6pel <bjorn@kernel.org> writes:

> From: Bj=C3=B6rn T=C3=B6pel <bjorn@rivosinc.com>
>
> When using the "install" or targets depending on install, e.g.
> "gen_tar", the "runner extras" weren't included for the BPF machine
> flavors.
>
> Make sure the necessary helper scripts/tools are added to
> corresponding BPF machine flavor.
>
> Signed-off-by: Bj=C3=B6rn T=C3=B6pel <bjorn@rivosinc.com>
> ---
> tools/testing/selftests/bpf/Makefile | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftes=
ts/bpf/Makefile
> index fd15017ed3b1..a5e63ef78bf1 100644
> --- a/tools/testing/selftests/bpf/Makefile
> +++ b/tools/testing/selftests/bpf/Makefile
> @@ -747,5 +747,15 @@ override define INSTALL_RULE
>  	@for DIR in $(TEST_INST_SUBDIRS); do		  \
>  		mkdir -p $(INSTALL_PATH)/$$DIR;   \
>  		rsync -a $(OUTPUT)/$$DIR/*.bpf.o $(INSTALL_PATH)/$$DIR;\
> +		rsync -a --copy-unsafe-links \
> +			$(OUTPUT)/$$DIR/bpf_testmod.ko \
> +			$(OUTPUT)/$$DIR/bpftool \
> +			$(OUTPUT)/$$DIR/ima_setup.sh \
> +			$(OUTPUT)/$$DIR/liburandom_read.so \
> +			$(OUTPUT)/$$DIR/sign-file \
> +			$(OUTPUT)/$$DIR/uprobe_multi \
> +			$(OUTPUT)/$$DIR/urandom_read \
> +			$(OUTPUT)/$$DIR/verify_sig_setup.sh \
> +			$(OUTPUT)/$$DIR/xdp_synproxy $(INSTALL_PATH)/$$DIR;\

Nevermind this patch. The btf_dump_test_case*.c files are missing. I'll
spin a v2 (and also try to avoid the name duplication from
TRUNNER_EXTRA_FILES).

Bj=C3=B6rn