Received-SPF: pass (google.com: domain of linux-kernel+bounces-38721-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Thu, 25 Jan 2024 16:26:40 +0200
From: Matti Vaittinen <mazziesaccount@gmail.com>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
	Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Matti Vaittinen <mazziesaccount@gmail.com>,
	linux-kernel@vger.kernel.org,
	David Laight <David.Laight@aculab.com>,
	Subhajit Ghosh <subhajit.ghosh@tweaklogic.com>,
	linux-iio@vger.kernel.org
Subject: [PATCH v2] iio: gts-helper: Fix division loop
Message-ID: <ZbJvoM3NJd_Uh_s6@drtxq0yyyyyyyyyyyyybt-3.rev.dnainternet.fi>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="58OujoI1kgFawucR"
Content-Disposition: inline


--58OujoI1kgFawucR
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

The loop based 64bit division may run for a long time when dividend is a
lot bigger than the divider. Replace the division loop by the
div64_u64() which implementation may be significantly faster.

Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
Fixes: 38416c28e168 ("iio: light: Add gain-time-scale helpers")

---
This change was earlier applied and reverted as it confusingly lacked of
the removal of the overflow check (which is only needed when we do
looping "while (full > scale * (u64)tmp)". As this loop got removed, the
check got also obsolete and leaving it to the code caused some
confusion.

So, I marked this as a v2, where v1 is the reverted change discussed
here:
https://lore.kernel.org/linux-iio/ZZZ7pJBGkTdFFqiY@dc78bmyyyyyyyyyyyyydt-3.=
rev.dnainternet.fi/

Revision history:
v1 =3D> v2:
 - Drop the obsolete overflow check
 - Rebased on top of the v6.8-rc1

iio: gts: loop fix fix
---
 drivers/iio/industrialio-gts-helper.c | 15 +--------------
 1 file changed, 1 insertion(+), 14 deletions(-)

diff --git a/drivers/iio/industrialio-gts-helper.c b/drivers/iio/industrial=
io-gts-helper.c
index 7653261d2dc2..b51eb6cb766f 100644
--- a/drivers/iio/industrialio-gts-helper.c
+++ b/drivers/iio/industrialio-gts-helper.c
@@ -34,24 +34,11 @@
 static int iio_gts_get_gain(const u64 max, const u64 scale)
 {
 	u64 full =3D max;
-	int tmp =3D 1;
=20
 	if (scale > full || !scale)
 		return -EINVAL;
=20
-	if (U64_MAX - full < scale) {
-		/* Risk of overflow */
-		if (full - scale < scale)
-			return 1;
-
-		full -=3D scale;
-		tmp++;
-	}
-
-	while (full > scale * (u64)tmp)
-		tmp++;
-
-	return tmp;
+	return div64_u64(full, scale);
 }
=20
 /**

base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d
--=20
2.43.0


--=20
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =3D]=20

--58OujoI1kgFawucR
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEIx+f8wZb28fLKEhTeFA3/03aocUFAmWyb5sACgkQeFA3/03a
ocVdBQf6AmGWHNraNeG7q7msDYkGPGvzuKfJ0PUE8JDxvkfGj+7kjCBWLxTGZ0xP
RuRiI6Rdus7H6qfmwOLVmzW+jGuWoTtpHU7xi4fkESyEwwUZVAzM/3p0EurevOIM
wgbHQIZLkvtQY8uYNXy5bb7QZV2MYFwFUssdHSM+iYM7kWLt8e7xR4X3ZIoQy8cn
8sTzxzz3cQG2ATlUJbFPL15Wsemt51p7C4To0x5UVRtsGNQk/av9jiKy8Rgad0Mf
5yaPvw1UgcADcsA5XuQRu5nX77NZlMPIzySlQ4p62Jvstwu64qpylKzKo25eMGp6
03tEDDohL190qLsnw0KM5q540VYLEA==
=0E+9
-----END PGP SIGNATURE-----

--58OujoI1kgFawucR--