Received-SPF: pass (google.com: domain of linux-kernel+bounces-38730-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 25 Jan 2024 15:35:46 +0100
From: Frederic Weisbecker <frederic@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Peng Liu <liupeng17@lenovo.com>,
	Ingo Molnar <mingo@kernel.org>,
	Anna-Maria Behnsen <anna-maria@linutronix.de>,
	Joel Fernandes <joel@joelfernandes.org>
Subject: Re: [PATCH 01/15] tick/nohz: Remove duplicate between
 tick_nohz_switch_to_nohz() and tick_setup_sched_timer()
Message-ID: <ZbJxwlAsFCJb4aWp@lothringen>
References: <20240124170459.24850-1-frederic@kernel.org>
 <20240124170459.24850-2-frederic@kernel.org>
 <87h6j1kc97.ffs@tglx>
 <ZbJMkautxpj1sQEJ@lothringen>
 <87zfwth701.ffs@tglx>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87zfwth701.ffs@tglx>

On Thu, Jan 25, 2024 at 02:34:06PM +0100, Thomas Gleixner wrote:
> On Thu, Jan 25 2024 at 12:57, Frederic Weisbecker wrote:
> > On Thu, Jan 25, 2024 at 10:12:20AM +0100, Thomas Gleixner wrote:
> >> Adding
> >> 
> >> #define tick_nohz_highres_handler NULL
> >> 
> >> for CONFIG_HIGH_RES_TIMERS=n somewhere allows you to write that as:
> >> 
> >> 	if (IS_ENABLED(CONFIG_HIGH_RES_TIMERS) && mode == NOHZ_MODE_HIGHRES)
> >> 		ts->sched_timer.function = tick_nohz_highres_handler;
> >
> > So the next patch does:
> >
> > if (mode == NOHZ_MODE_HIGHRES)
> >     ts->sched_timer.function = tick_nohz_highres_handler;
> >
> > Because that condition only happens in CONFIG_HIGH_RES_TIMERS anyway
> > and the function field exists in any case.
> 
> Right, but the function does not exist for HRES=n, so you need the
> #define ... NULL. The IS_ENABLED() allows the compiler to eliminate the
> code for HRES=n completely.

Ah but the next patch moves tick_nohz_highres_handler out of CONFIG_HRES
(to soon become tick_nohz_handler()). But anyway I can add the IS_ENABLED()
to remove dead code.

Thanks.

> 
> Thanks,
> 
>         tglx