Received-SPF: pass (google.com: domain of linux-kernel+bounces-38794-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240123121223.22318-1-yaoma@linux.alibaba.com>
 <20240123121223.22318-2-yaoma@linux.alibaba.com> <CAD=FV=WEEQeKX=ec3Gr-8CKs2K0MaWN3V0-0yOsuret0qcB_AA@mail.gmail.com>
 <8c7ba29d-0e12-412f-b88f-347de237d1ad@linux.alibaba.com>
In-Reply-To: <8c7ba29d-0e12-412f-b88f-347de237d1ad@linux.alibaba.com>
From: Doug Anderson <dianders@chromium.org>
Date: Thu, 25 Jan 2024 07:08:02 -0800
Message-ID: <CAD=FV=UfzLAxbKWUqhbt7iBEZzyuBqCkdaSJFnHGYAw-2mcAYA@mail.gmail.com>
Subject: Re: [PATCH 1/3] watchdog/softlockup: low-overhead detection of
 interrupt storm
To: Bitao Hu <yaoma@linux.alibaba.com>
Cc: akpm@linux-foundation.org, pmladek@suse.com, tglx@linutronix.de, 
	maz@kernel.org, liusong@linux.alibaba.com, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, Jan 25, 2024 at 12:31=E2=80=AFAM Bitao Hu <yaoma@linux.alibaba.com>=
 wrote:
>
> > 2. Sum up all 11 of the stats to get a total. This should still fit
> > into 32-bits.
>
> >
> > 3. Do the math to get the integral percentages and store those in the t=
ail slot.
> >
> I'm a bit confused, why is there a need to sum up all 11 of the stats to
> get a total? I calculate the percentage using sample_period.

Oh, you're right! I saw you looping over NR_STATS in print_cpustat()
and assumed that was because you were totaling them. Yeah, using
sample_period should work.

-Doug