Received-SPF: pass (google.com: domain of linux-kernel+bounces-38819-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 25 Jan 2024 07:21:38 -0800
From: Ashok Raj <ashok.raj@intel.com>
To: Ilpo =?iso-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
CC: Jithu Joseph <jithu.joseph@intel.com>, Tony Luck <tony.luck@intel.com>,
	Hans de Goede <hdegoede@redhat.com>, <platform-driver-x86@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, Ashok Raj <ashok.raj@intel.com>
Subject: Re: [PATCH 1/1] platform/x86/intel/ifs: Remove unnecessary ret init
Message-ID: <ZbJ8gp47CWDDqCb4@a4bf019067fa.jf.intel.com>
References: <20240125130328.11253-1-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240125130328.11253-1-ilpo.jarvinen@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?tklvVCwYNScp5/e9qSeqeTKN/ttN0UFe31XADKSvRq6PPd1fxzqUQXa8xK?=
 =?iso-8859-1?Q?3NTF+M2Ms6koX1RzBt0Qnah1NiFF3AHmuKk4ympngn86NMYy4Id9DNsITJ?=
 =?iso-8859-1?Q?oaHS6xfT8FmFI6gCUgoveKlgt7TsVma9Am4Ok7AsJ3HvZDkRxkppL3XTvs?=
 =?iso-8859-1?Q?FGV64idZ+HLOZCd4hm+Yf2+EaOmFzAdLyxwvs5t5qYsqWqzLb4WnE/LJ6j?=
 =?iso-8859-1?Q?CnSuOXN4SuHTXMZc1l3eVQG7M0srQYeiJKGDShp/OojBuvTIiwvS/B2u9O?=
 =?iso-8859-1?Q?CvvqLTm2ZJeDw2FeCqdGPaEJ5ce5LXvDEzETmtBfu18mSr6XJHPEAmSuv+?=
 =?iso-8859-1?Q?ZMkgcRPe6ceM9GQLbLuHkNjXMOZRTPZafn3p2JIJJhyERn8z9WunlrE99Q?=
 =?iso-8859-1?Q?nWKWCbj5zi8bUw3cf4t8UBFNaDqMkg3RQzZjvxKAZRmN+r23/i9Gi2NM/N?=
 =?iso-8859-1?Q?S4d2CIVnnGusnfK4y4euG3Rw6JYLHS+A2gkaeQt2l4DjWJf63W42Se+4p1?=
 =?iso-8859-1?Q?bYUmbL08M6b4392Ky4oFnr0NGtUDfV8CMtpvQbxZetiUndBvGQMP5RbsXZ?=
 =?iso-8859-1?Q?G+R2LQ1Dcorz93FqECeP77RmJf3XG9xc5A/5pOzPBl+M9eW/F9Ik1BPkSe?=
 =?iso-8859-1?Q?spx1IssR3p7sUHPEAHa8fHmqClVr/qU8CRIfVGHrhUspPzOKz8v7KKobo1?=
 =?iso-8859-1?Q?xPmDTAXPTRUnUm4Iw0EGGMqu7SRjL+ogq43/RSBCDBL3EHsmh9bokFO5I/?=
 =?iso-8859-1?Q?xdcBnohuGRFf5IKFfhNUTmB5k29Zj0SQUXU89qMLinxNHc3G5qasP+7ydC?=
 =?iso-8859-1?Q?7QX/R8PBdtLGVf10bKShjPA4hD6TlYfeZUNAEWvL0GMecDmGYC9qC7zdiU?=
 =?iso-8859-1?Q?LoIABBp3hWsu7uoxB324RK4BGRNQHn32sEaL5mO+FCXc/+NuPGyuCWdmVe?=
 =?iso-8859-1?Q?ElUw8qR7As2gpDAVXEbRXLlGYAkA/p5WnGNlnTWf2Ow8DSYFutMY3E9PaM?=
 =?iso-8859-1?Q?XeEGK77t7QaUiiwB72H9YdM2as2gNvaoeWNyffuEKgtu8KVlA3rxKqdE9u?=
 =?iso-8859-1?Q?idCApduPXaQI30cw5J+Q3DfQV6/HAoLZo5PrNtPusIoi+7DW5TkMicNEPI?=
 =?iso-8859-1?Q?K1p073xG4jGy7Ym6FmlFfmevizAHaR1HgOGTK8pbs98V7T56w2aa+rTfss?=
 =?iso-8859-1?Q?6R/pVcd0OHNq0ANnpl2+tUeTJkiiJ/dXyhpP2zmPxVHRWKIkbvclZEdVx2?=
 =?iso-8859-1?Q?hw0ZImoV53IkatawN6ItkUGY44nW/8sPAkpnmMLAFNGr0AlbtlgbT7gGFU?=
 =?iso-8859-1?Q?YRce9dQ9MeNwmBzy3KkpAF8UKRO+azKVPFWB4GTYmi7r70Tzczz50CAnKI?=
 =?iso-8859-1?Q?ysf6/1i0xd3297qp4befMFhuI6uQa6DthYSscM/epe2toTW26wPSAvE+55?=
 =?iso-8859-1?Q?LSsW5F8VkdB05PZacYfxG1Nyf0dWwEQCDTN/455wO2A9bPlBBGnKTZfF3D?=
 =?iso-8859-1?Q?z7ptA/O5gmrhJGyv/DqD3PH6gDp2VXzTrEVUwLrskc1gRg0fx9ieOgJOE5?=
 =?iso-8859-1?Q?1qYfSw8PjzRVgxdMuFxNiZIy69uAfU25vAsb8+YniVwNdWIhaOrFiJ2FPU?=
 =?iso-8859-1?Q?Rax90+636ADPlnN9p2g0jyBgSMhwRcYLzLQpCmAXRYRlYz3wvbefe0mA?=
 =?iso-8859-1?Q?=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b12a98b1-497c-4423-ee7a-08dc1db95501
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2024 15:21:41.3275
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: InEzfqcQlY8FzgRlWU73qwoMJ4alvqdM3vp9rgYS90hYAsTwHJfkKThdhvG0ldhvzXePCLeqUesvLGW/ic7VDA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5981
X-OriginatorOrg: intel.com

Hi Ilpo

thanks for looking into it.

On Thu, Jan 25, 2024 at 03:03:28PM +0200, Ilpo J?rvinen wrote:
> ret variable is assigned unconditionally in ifs_load_firmware(), thus
> remove the unnecessary initialization of it.
> 
> Signed-off-by: Ilpo J?rvinen <ilpo.jarvinen@linux.intel.com>
> ---
>  drivers/platform/x86/intel/ifs/load.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/intel/ifs/load.c b/drivers/platform/x86/intel/ifs/load.c
> index a1ee1a74fc3c..03e49b836a6b 100644
> --- a/drivers/platform/x86/intel/ifs/load.c
> +++ b/drivers/platform/x86/intel/ifs/load.c
> @@ -383,7 +383,7 @@ int ifs_load_firmware(struct device *dev)
>  	unsigned int expected_size;
>  	const struct firmware *fw;
>  	char scan_path[64];
> -	int ret = -EINVAL;
> +	int ret;
>  

Looks reasonable to me. 

I can keep this as a separate cleanup patch, or merge the change in this
patch.

What ever Hans/You prefer. 

Cheers,
Ashok