Received-SPF: pass (google.com: domain of linux-kernel+bounces-38856-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 25 Jan 2024 15:53:08 +0000
From: Mark Brown <broonie@kernel.org>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
	conor+dt@kernel.org, alim.akhtar@samsung.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-spi@vger.kernel.org, andre.draszik@linaro.org,
	peter.griffin@linaro.org, semen.protsenko@linaro.org,
	kernel-team@android.com, willmcvicker@google.com
Subject: Re: [PATCH 0/7] ARM: dts: samsung: specify the SPI fifosize
Message-ID: <eaa04bac-91dc-40e2-981d-e5f04f6ca19e@sirena.org.uk>
References: <20240125151630.753318-1-tudor.ambarus@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="foFfTHRHUmaAcrJ3"
Content-Disposition: inline
In-Reply-To: <20240125151630.753318-1-tudor.ambarus@linaro.org>


--foFfTHRHUmaAcrJ3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Jan 25, 2024 at 03:16:23PM +0000, Tudor Ambarus wrote:

> These patches close the circle and break the dependency between the SPI
> of_alias ID and the SPI driver. The SPI of_alias ID was used as an index
> into the fifo_lvl_mask to determine the FIFO depth of the SPI node.
> Changing the alias ID into the device tree would make the driver choose
> a wrong FIFO size configuration, if not accessing past the fifo_lvl_mask
> array boundaries. Not specifying an SPI alias would make the driver fail
> to probe, which was wrong too. Thus I updated the driver and I provided

Specifying a specific compatible is just good practice, it makes the DT
much more robust for when we discover new things about the hardware and
reduces the surface of the ABI.

--foFfTHRHUmaAcrJ3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmWyg98ACgkQJNaLcl1U
h9DPcgf/cXFXW2mU/ooxWd/EwkvRCkAW4vwoseFFv6E9z59LkE4ds8tHPZDgZOBE
/3U/AIgAG9tQQFOWmxSNFHnh1E2NCMte/VUoXTisfRnhLdYZj2wlaFdcvGt/JFe+
E5WTpnGFsKLOEC1JB5XIQLpJVHniXRiPEsc4zDJlro7m6+r/5aLqbIh6ORuwVdVg
2uzj2iL2c2Ik8I6PreqCA5T6Ow53h/o5OELqui8W7AhDiN1c2cRL8ukRGteN6q0r
HUWuLVYbuYxifr5BjOS+n7mLDMY2Jg/EhysV+T7ZB23mUSuNZPE9drX1lLb+CZa0
P4cbB+TJ3sk4DkKU2k5l2l3uIxyAkw==
=0MC+
-----END PGP SIGNATURE-----

--foFfTHRHUmaAcrJ3--