Received-SPF: pass (google.com: domain of linux-kernel+bounces-38858-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <05156615-8dcc-41ec-aa6a-aa41c515d25b@amd.com>
Date: Thu, 25 Jan 2024 07:56:22 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [EXT] Re: [PATCH net] octeontx2-af: Initialize bitmap arrays.
Content-Language: en-US
To: Ratheesh Kannoth <rkannoth@marvell.com>,
 "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Sunil Kovvuri Goutham <sgoutham@marvell.com>,
 "davem@davemloft.net" <davem@davemloft.net>,
 "edumazet@google.com" <edumazet@google.com>,
 "kuba@kernel.org" <kuba@kernel.org>, "pabeni@redhat.com"
 <pabeni@redhat.com>, Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
 Geethasowjanya Akula <gakula@marvell.com>,
 Hariprasad Kelam <hkelam@marvell.com>
References: <20240123051245.3801246-1-rkannoth@marvell.com>
 <cf035125-d7fb-4423-8f64-a5be7505243d@amd.com>
 <MWHPR1801MB1918035FC2D71BD916DE716ED37A2@MWHPR1801MB1918.namprd18.prod.outlook.com>
From: Brett Creeley <bcreeley@amd.com>
In-Reply-To: <MWHPR1801MB1918035FC2D71BD916DE716ED37A2@MWHPR1801MB1918.namprd18.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?OE9LNUQvUCtVNngxMzB0bTUrMVdrODZ1dVIxRFU1eXJRNzhZUjZLT3pZdWJr?=
 =?utf-8?B?WjRvRlpDN0F1MGhlcWsrYkVZY1B3TnpOYzdxWnNQa0VCZG5KQmxMcDhqK3Nm?=
 =?utf-8?B?SWMvM3hDek9kRkJqQmx4NzI1OWh0ZlNCenVzaEd0SWdVcUdUWG8yM29FNUJ2?=
 =?utf-8?B?b0RvcmdUOXJJK3ZsY2hwZ3JYS0Y1QWFIY1pMYTNpcDBGV24wcEtDQWJwUlZE?=
 =?utf-8?B?OGxsOXdkb0tjbVd2SlZOZXR3NTdJclhrU1NuNmJNcndGUlE5d0JDQ0gxem5B?=
 =?utf-8?B?TFRHTGJnbnRvT1lsSld0LzVCV3BnN0xDNWZhQlFVd0RhSHhiQmJwS0p4Qy93?=
 =?utf-8?B?VVRCVjFXVStCd0UzVUROUkx0eHZLT3ljQmJuZmlsNVNxbGdscDdUcitZRElP?=
 =?utf-8?B?Q2kvRVl3SXBYbGJlWHdYTThMNE1tUUtUNHU1bmZ4QmJiTkF4dlJYUkpnRFZt?=
 =?utf-8?B?MlNLZW1UR0F6T2lZeVBQaUJQeFBVY09USS9INkozdENpMlAwZFlFcHhSRzRS?=
 =?utf-8?B?YUhYSHpwZk5zcmpYNmNmcU9rY3p5ekJ6Zzl4UThQT01jYlJsTDRPNG1Eenhh?=
 =?utf-8?B?UHptelVSem5xVEljckRCMnp3YkIxSnczK0h6d3hORDNQb3J6anUwQnZHMVNs?=
 =?utf-8?B?ZHl4aFNVVi9vUnczTzFYWkZUb2l5MTd6MzBPeEZSY3h2NTJ2Vk5YUmRzUkkr?=
 =?utf-8?B?dG10MVhTdWNVR0dBYjlYaXJXQ25SQzg4bEhvdVUxTUs0d203ZkorcGlHMzEy?=
 =?utf-8?B?QUxQYWFzaDhHa1VoR055NXRtdTkxMEZCbEFBdW5qVVoxTS9oekZtY2dvV081?=
 =?utf-8?B?b2pOM3MyTERydndGWU5DSE9kWWllbkZyUjZXeXJ5OWdyc0Z3NW5lR1lLTlBN?=
 =?utf-8?B?QVBwU0I5OXdiZ3lmQnY2dm5zSWs5OUdMSVFDbkZrSmc3K211bTYvRW1YZTd5?=
 =?utf-8?B?MlZ2bWx6dFFPR1hoMFlXR0lJN3FNWU9KUTBEdDRTekoyVCszYTNRZFBDMHNX?=
 =?utf-8?B?NzU4SVplOWlPRlNxM25jd1B6UlV3dWFaRzltV2RLZXZ1UnppMGRUQjd3M2RJ?=
 =?utf-8?B?eHp0Q3R0K1o2WVRXVXJNTDlacHZuNU5NaEptbE11ZXo4MnBtQXNPSUxQVzNm?=
 =?utf-8?B?T2FZaHBaaXd3UEg4Z3dia0JsVER2SmVSUjk1eHl1QXNaTDdNRzBwQnJVS05N?=
 =?utf-8?B?QnpId0Q0RVNNandGTUNpYU9VVW1qZStrNUU1eUVKcU1IMVJHSWQ5TDZ3dzcz?=
 =?utf-8?B?ODNGSEJ4M1FZOEJDNWY4UzI2L01QSTM4ZWVySVdDWU1hQjRUUWwxWC9FTmJz?=
 =?utf-8?B?RGhpOHhLQ1ZvVkpsWm5rR0o1MThoeUgrTVl6NE9SYjJ0KzFxVVJGUWh0Wmhv?=
 =?utf-8?B?Y2RMZEtteDhIVXV6T1FvMGN3RkxWZmt1clp2Mm8rMGV4dnQ4bHpROHFyb2hy?=
 =?utf-8?B?YzhySjJrOFdRVm9KTjBZVVl1WFR2ektsYkxCYzd0aWxkaWRnVUFadjVMZW9u?=
 =?utf-8?B?OW9ISVNQQU1UdXdSNFBjVSs2NkFTL2RWQ0ZCSXNWOEZsbVE1YytST3FVVGE4?=
 =?utf-8?B?V2FUY0cvbkZYMDRYZTVNNXZYc3FpRE9hSmJuZlhpNThvckRjWHBsM1N6a3Rz?=
 =?utf-8?B?a1JYcnhtSmZ6OXFPTWRxc3I4MWN5WGpCQ0VtUnMrYVJPdmozYzFpQlFrdExB?=
 =?utf-8?B?SUNHNm9FQisvK1ZkMEdPSHJRZnZLU3VyQmZGR0JmWSs5d3l1UlU3OUVYR0JX?=
 =?utf-8?B?cWRZV3RFdXd0N08rcFRJRzdpaU56UjR4NWZadGozK21hWnBLVDNZLzhmNEtF?=
 =?utf-8?B?TGJ3akw0ZUcxeHFBNWhmRkZROHRNbGlHYVN3RS9TOHpYZlVvSUtHQnNtOVdF?=
 =?utf-8?B?Z3lmNHN4Umo1VVlQZ0JlclI1bGlzdVI0Y1JFN1VxcDZNeHJwemhkbUlnemFw?=
 =?utf-8?B?QlZEZHhubjJqaU9uS2czQzVCS2c0UlNCclBpcTJrenpndGlNWGRDSGFTYnkw?=
 =?utf-8?B?SkJxUnB1TzhWalNiMFpISWEvWTlqejcyemdNTXdjL3U3SFZmeVloZ29aMktK?=
 =?utf-8?B?dVkyQVUrdnNHemFINW44bzJsS0E1YVlnb1ozTTEyZWJkR1NlV1hsZHFaUnZ4?=
 =?utf-8?Q?tvPQP2puNomovFsTlWkAaNzmZ?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b9a7830-2471-41b1-bdeb-08dc1dbe2eb6
X-MS-Exchange-CrossTenant-AuthSource: PH0PR12MB7982.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2024 15:56:24.5722
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8ufgpCQGHVQvUq92RV49PYV2sMvRrJ0q/H8jq4HyIzjxg2PliPzf8dIn9ktfqIr1XlyJNfkbgpddR0xutmSrcQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB7213


On 1/24/2024 9:06 PM, Ratheesh Kannoth wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
>> From: Brett Creeley <bcreeley@amd.com>
>> Subject: [EXT] Re: [PATCH net] octeontx2-af: Initialize bitmap arrays.
>> Is there any reason to not use:
>>
>> bitmap_zalloc() and bitmap_free()?
> Will follow simon's suggestion to keep patch diff minimal. As bitmap_zalloc() does not give any advantage over the other.

It does make some sense because in multiple places you are open coding 
bitmap_zalloc()->bitmap_alloc() in multiple places.

For example:

         mcam->bmap = kmalloc_array(BITS_TO_LONGS(mcam->bmap_entries),
+                                  sizeof(long), GFP_KERNEL | __GFP_ZERO);

This is exactly what bitmap_zalloc()->bitmap_alloc() are doing.

> 
>>
>> This is pretty much bitmap_zalloc(), except with devm. As Simon is asking, is
>> devm really necessary?
> Will use kcalloc.