Received: by 2002:a05:7412:3290:b0:fa:6e18:a558 with SMTP id ev16csp62210rdb; Thu, 25 Jan 2024 08:16:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IHqGgdcCQCVAps8HO+nsgFt+90wS28efKrR4jB0EuJry8MGaKS9qUJB4AjKQ/9PPepbjxu/ X-Received: by 2002:ac8:5a93:0:b0:42a:57dc:4db7 with SMTP id c19-20020ac85a93000000b0042a57dc4db7mr1509157qtc.1.1706199360178; Thu, 25 Jan 2024 08:16:00 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706199360; cv=pass; d=google.com; s=arc-20160816; b=yhObPSRkpqVUCCf1U9jlUgCqIUBLpuFPoHZUGvrEQBsClYlGJzNIS4EloLSGqKAwAZ tpKZxMFxrpXvRVtrEK+mtlbjWZbnSelo4N1ENSbQio4HLUQfWQ5SLMMRurQEtWez8Iec E3abgMrK3Nqs2wDWZKhvggoVDRnTfCoEY82EgeUW+p+MioAn9TCj3exKdiXPZe3SppUe y1xUjpQ3Vtvjxdun+U9Y87A+/LmbkrcNX9owZe9dTXX5oc3SixvxH/gVwtoWNip0Sidh vyMcmErExfde9H9grzKnwqrkZ+eL1QAdRgZglud/TQI74ku5xGk4s9zZJJeDJEAGZYex 3Uhw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=h0jv+o9A+wYCzDu98VpZP/cBQ9vOtBitYiceIg2K51c=; fh=fegGUZqtCRkG4Cn9Q0+HqLybFqbcoIGhOm5KUBxif6c=; b=G/6yAlHuE1EsMr1J/6idgGFIzt5PhoYTGnyhqY2uixv8YvcwlOfvpIdp0q2LTi9MAT ewfA/9pUoL8ICy3gVe7HP7eYUMTVYii9/dKrX3hD2/qkosMtXlQNWxPWiDU0SmBLpHbV EySlZJgsBVN7lMvuD7ccrLMsiGHKxfcxliwf2FIsEjAbqpmuJ/lEXyZ14kKvh4rTXWg6 4ShERCy54oGb/ZyM+GjJi/M2XZUUaYpdqZv5n3FL+1Ppes93uuWD6rohZWwNFv502704 g2JT9ATK5/XKaktSHHOPyN1XVpdhh8OR43LLjemJX8zf8B0scb7g9MNxiZkZSpMEfsbx 76pQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DP2Ytr5X; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-38876-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38876-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id w3-20020ac857c3000000b0042a43b5c906si8428779qta.58.2024.01.25.08.16.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 08:16:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-38876-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DP2Ytr5X; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-38876-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38876-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id C66701C2304F for ; Thu, 25 Jan 2024 16:15:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 09421129A7D; Thu, 25 Jan 2024 16:15:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DP2Ytr5X" Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 885281292F4 for ; Thu, 25 Jan 2024 16:14:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706199299; cv=none; b=K7EZmUCheapr/tqTkjVTqLxAg394nbdg7lO2m7H1eUyYbfwMhcCzzoJI5WnPdc2lyb/YPVkZ/Qh80CDm4Cq/m3gGi6uXG7ONbxdFPJuWHE++ug0pTyokjUPibYoosmGHMAD6wsnDTjdMDZ9fnRUYxMLIcXFG1frgXqP60aM43BE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706199299; c=relaxed/simple; bh=phDWEm7E2RCC4IWzHMQu5zDaitdfQlVSfh1cl5FhwkE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WhPG04ckH+7fXr3VCi8PkVpWnieHVE/aKm4w+32TMOoNvvnUP3oNXg5YY+NhiAgrhFBKQdxjfIm8J+9dXXVzAPWIFG7OA4mpo5X8RZ07SsIij+auwaH3qBuKLppLbpDyk9ElHkYU3kg1yNMz6axD1VMF7VIi6OvRD2pHUBXkUPg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DP2Ytr5X; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-5100cb64e7dso3391974e87.0 for ; Thu, 25 Jan 2024 08:14:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706199295; x=1706804095; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=h0jv+o9A+wYCzDu98VpZP/cBQ9vOtBitYiceIg2K51c=; b=DP2Ytr5XDihUTxMv0OSsCQ1olRSyB7aaSkZYpIdNBN/GhOZLGvQXpfUdlqkk/4YH7R RGMdof/uSBov6J+ZlD7mINb24sf4OmkUmw4LOCOI3YdCCrU/hq+hxh4otMm4UcVwuukK YqiPhdiIlJCanTUFHFpaRj9eWjcl097ULWeJPGrJORQUsv7e4eBNUGl9nhP89XV1ZJx+ c5J4+BZ8e+noovw8LIvPv5Fi8Nifg+cXQk2hyGURaFN25O8C7ephXfHLjr67ZPVH7nxc dhMKcaJe68Ghuo5M/M1fDzfufyOnIY4TZEiWYygfD8PD+1+gzxwX4PWbQSr98leTVVem eWkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706199295; x=1706804095; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=h0jv+o9A+wYCzDu98VpZP/cBQ9vOtBitYiceIg2K51c=; b=fBX53ZO+A2GE7k8QQyzOB8SukQ5jzDJSaXT4UTSz84/N3hdAi4Aw+Sgws1PlIW7jm0 Js/KNq3QjMAxurCps0S0zm+mWV6GWt79ba9kYWldl7/by02uUxZNrTPCtaCz+RPTvI0G WKJSjmoPq5iZ8TUF+0uKGDz2XbN6udeFNDaREXYZnzJaS32tbPXkQX5jiQ5wPYZLu4x0 Rm4qOvjR7TetsWr3bMuUBd/eRDgybR9GRoMGkCAyj/XHWw5xMHwzBTS3eaCxKDSFJO91 vFL/nD8MzLXRAlpQTapRz9O+VDrVpkNklHV9voXZ4edYSDlPOzwXjs8GnlVtHnRq572H LIpw== X-Gm-Message-State: AOJu0YwhSlsSX0PcYUdS4bRC8POixVmj80HyeFjOkGziZZIOyuIF45Fx HHIkwz3ZW7SwRmKsRyBeNq6WYmSQ/G6dWBxH7+/zL6Q1XtmvZSGzK7N1zyBWbmg= X-Received: by 2002:a05:6512:2202:b0:50e:7b34:c18a with SMTP id h2-20020a056512220200b0050e7b34c18amr13800lfu.111.1706199295600; Thu, 25 Jan 2024 08:14:55 -0800 (PST) Received: from [172.30.205.155] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id h22-20020a056512221600b005101ee22b84sm145726lfu.1.2024.01.25.08.14.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jan 2024 08:14:55 -0800 (PST) Message-ID: Date: Thu, 25 Jan 2024 17:14:52 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] arm64: dts: qcom: sm8550-mtp: correct WCD9385 TX port mapping To: neil.armstrong@linaro.org, Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org References: <20240124164505.293202-1-krzysztof.kozlowski@linaro.org> <20240124164505.293202-2-krzysztof.kozlowski@linaro.org> <3f03ebc4-c67a-40cb-8863-d9c800af54fa@linaro.org> <8819b406-34a4-48ba-8d69-25cb4cbcf3e1@linaro.org> <320eeed2-af8c-4a83-b0d6-301ceb74f532@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <320eeed2-af8c-4a83-b0d6-301ceb74f532@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/25/24 14:02, neil.armstrong@linaro.org wrote: > On 25/01/2024 11:47, Konrad Dybcio wrote: >> >> >> On 1/25/24 11:43, Krzysztof Kozlowski wrote: >>> On 25/01/2024 10:59, Konrad Dybcio wrote: >>>> >>>> >>>> On 1/24/24 17:45, Krzysztof Kozlowski wrote: >>>>> WCD9385 audio codec TX port mapping was copied form HDK8450, but in fact >>>>> it is offset by one.  Correct it to fix recording via analogue >>>>> microphones. >>>>> >>>>> The change is based on QRD8550 and should be correct here as well, but >>>>> was not tested on MTP8550. >>>> >>>> Would this not be codec-and-not-board-specific, anyway? >>> >>> Yes, indeed, it should be. >> >> Should we move this to the driver and drop the then-uselesss >> dt property? > > Actually it's codec-and-soc specific, so I'm against dropping this. Aaaah snap :( Let's leave it as-is then. Konrad