Received-SPF: pass (google.com: domain of linux-kernel+bounces-39023-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 25 Jan 2024 17:18:01 +0000
From: Mark Brown <broonie@kernel.org>
To: Tudor Ambarus <tudor.ambarus@linaro.org>
Cc: andi.shyti@kernel.org, arnd@arndb.de, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
	alim.akhtar@samsung.com, linux-spi@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-arch@vger.kernel.org, andre.draszik@linaro.org,
	peter.griffin@linaro.org, semen.protsenko@linaro.org,
	kernel-team@android.com, willmcvicker@google.com
Subject: Re: [PATCH v2 21/28] spi: s3c64xx: infer fifosize from the compatible
Message-ID: <2086b88e-45fc-4224-b00f-0840d446d042@sirena.org.uk>
References: <20240125145007.748295-1-tudor.ambarus@linaro.org>
 <20240125145007.748295-22-tudor.ambarus@linaro.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="HgRtS/XEVb/749Yx"
Content-Disposition: inline
In-Reply-To: <20240125145007.748295-22-tudor.ambarus@linaro.org>


--HgRtS/XEVb/749Yx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Jan 25, 2024 at 02:49:59PM +0000, Tudor Ambarus wrote:

> Infer the FIFO size from the compatible, where all the instances of the
> SPI IP have the same FIFO size. This way we no longer depend on the SPI
> alias from the device tree to select the FIFO size, thus we remove the
> dependency of the driver on the SPI alias.

>  static const struct s3c64xx_spi_port_config s3c2443_spi_port_config = {
> -	.fifo_lvl_mask	= { 0x7f },
> +	.fifosize	= 64,
>  	.rx_lvl_offset	= 13,
>  	.tx_st_done	= 21,
>  	.clk_div	= 2,

I'm having real trouble associating the changelog with the change here.
This appears to be changing from specifying the mask for the FIFO level
register to specifying the size of the FIFO and unrelated to anything to
do with looking things up from the compatible?

--HgRtS/XEVb/749Yx
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmWyl8gACgkQJNaLcl1U
h9DTfwf9EPYILffoosYlL9u/einpypgWGHhqhCvASqvmgmec/OFieX6W9rE9756V
qRQKkCsaD16mHJUSvJSqEf4qwoAXGf/57d03e5ShnK7nF8eUh+gsG2nz8b2mDmIr
2M6foetkCRim5eV4rNmsqxW8Ce+6EWrJX4y9BqxJNbxaACxa9fO9fIHAF+jnUOdU
/Bw/4aK99kPkW8PHMsg3vpuHxzbzak0aiYvMTHVZcp8Paan0hz3KYvI6xHLllNL0
ukoQMrnHrpOKy3ftVmNDXeefDuE0sOHQinzQsIEuIXqiRE2XKyJ+yXII+RaZ2o1b
v87fTDNtaYqs9bH0jweNhcv62vHu1A==
=qAfe
-----END PGP SIGNATURE-----

--HgRtS/XEVb/749Yx--