Received: by 2002:a05:7412:3290:b0:fa:6e18:a558 with SMTP id ev16csp103576rdb; Thu, 25 Jan 2024 09:23:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IGf1rAYInBoLZGXXqnzT5J2dc8F9cEwnxDJph3Z5vLQqh60eU2Mi6n8s8J70l0ycFBRsY/c X-Received: by 2002:a05:6a00:a8f:b0:6db:be6f:664f with SMTP id b15-20020a056a000a8f00b006dbbe6f664fmr50763pfl.5.1706203392804; Thu, 25 Jan 2024 09:23:12 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706203392; cv=pass; d=google.com; s=arc-20160816; b=RNlYQWALQtMzQQB4p9lkZvflb/9x4RV6WF2FNaspleJI7mWbt8MLsP94sQubiWYdE+ +nFX4YmCZQLAGjL3c3DpLinHixVQsbUdpDd9bxIys66br7nNyyMTYS4q5Vuh5Qp1HpPh tqaW3gvN0PkkfLjfOsRTyu4+bcGBdL5c3U6gvPFvp/fBdRmOvt6hdOpjHMwxiFgwGWNl Lf30/VYG5Sc+bdS+uv8DnfcDva22yGs5pkI51iycCYe9GYg/obcwrUuG0kVpFRWKQs2B YZCaaJ15vZL77bZ5vkfTHDpBSpvTi5UegdAvxNYw3N1Ye2Rk6tTRIpgH+bLEs5ZARZxs /04Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=6XmL08t5nvQeDJ0ijBle9RmMpOjyA1qD7j3fdFOhR6k=; fh=ZKXJP9nZ9+vzzrmAlwqt3si6ukgU5wIFL5ZG6wx3oGc=; b=U5zUpg6AH0uLNvjtEtOvBL5rI6ABP71IE8sJrTuFJNlG0LNM1CU372psRbEVxzMjYQ Hlkf8YSIrfrw92gjVRTGM9GljxFYRGfdoQlVY0yh0duKzksgBr5o9PAz7U0hJp0LHyKi p8A7tCckgtbFlf/p2St+MJWYoYWP8IHW5XMTqnIpoRDFA2Ey+iHMHzW9omsYanAKTJcH yZBrZrVfAavQRjjlJvEbZ5Z8ev1XJ28BRnM19/TCqRJghNnCSBYulu3S0DeY9d+qPJ+D oWrC+PbVy5asxoSxTnIjhoNrW9tIsRpyaX8aUxYh5j5lUMt12ukbfbo1Qy0/kmu6AGwR /J2g== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=jOo3a7ho; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-38498-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38498-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id x20-20020a056a00189400b006dde04e1839si213042pfh.63.2024.01.25.09.23.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jan 2024 09:23:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-38498-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=jOo3a7ho; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-38498-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-38498-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 6F20C28F646 for ; Thu, 25 Jan 2024 11:22:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7288423764; Thu, 25 Jan 2024 11:22:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="jOo3a7ho" Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23DA032C8C; Thu, 25 Jan 2024 11:22:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=134.134.136.31 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706181727; cv=none; b=H2DAHWYBiRCwF38clfbbGLCE1DRNJCychOhx1CcLt1r6toMiccIqzK72fDVICvPSgQukConCgfeqT3nnhHrUHFrqSHBy1+aX5HOESRCzA/JQOyk/ryPolk+N4UttmV070Df3ibRJ+6+ybbeRgBFS3JAqVKTRLAPjXUgx9JTdIno= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706181727; c=relaxed/simple; bh=6XmL08t5nvQeDJ0ijBle9RmMpOjyA1qD7j3fdFOhR6k=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=Yc7yagjQnkyHiZu/oEjNZxcX3tppU2VwcKTnt2MjT3TAflFwmdlkuzCtLPvmqw3RkqtqmKOwi5AlXw/IfgJf7bGFYXi7WhTYNqP0PbUgGlHDQz9l0oFedTEet5aSn+lGbhZ7seiKIaFDvUreTOb06km08rnQuvIqMU0YyHvN8Lw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=jOo3a7ho; arc=none smtp.client-ip=134.134.136.31 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706181726; x=1737717726; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=6XmL08t5nvQeDJ0ijBle9RmMpOjyA1qD7j3fdFOhR6k=; b=jOo3a7ho0KLSENJLvBa1snW2YXQWlazrtZzh1p7TosAHhjFJE5lvxbRi iiuux1BCwVnxuPr8C3diiEYfzwKKko7Gf286dTF4Svr2F0J8xs7HxiKZO P3oqbj/lj8Tay4o9Rjg8gTd5FOzvAbmdAaZeerQlVfjdHaUjHyu+1zsNv u7Acn//kEinEpV3oOBa36RRMmSwmKorp2TLeUeXYWjsHdDHD4lDrt8o1n kz3e+D6OHYrKI/D+AmYFKJH0gWveEdL56iuGs8hgTgLNXE9YphQdPSfYo qtDqgVRwth10wgt5cGaQty++VfpYZ6kkd0F60qSNM31mMRFqq49ntgrr1 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10962"; a="466414530" X-IronPort-AV: E=Sophos;i="6.05,216,1701158400"; d="scan'208";a="466414530" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2024 03:22:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10962"; a="1117919561" X-IronPort-AV: E=Sophos;i="6.05,216,1701158400"; d="scan'208";a="1117919561" Received: from blu2-mobl.ccr.corp.intel.com (HELO [10.254.209.226]) ([10.254.209.226]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jan 2024 03:21:55 -0800 Message-ID: <95ff904c-4731-46e2-ad3b-313811a3c2f2@linux.intel.com> Date: Thu, 25 Jan 2024 19:21:53 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: baolu.lu@linux.intel.com, Joerg Roedel , Will Deacon , Robin Murphy , Jason Gunthorpe , Kevin Tian , Jean-Philippe Brucker , Nicolin Chen , Yi Liu , Jacob Pan , Longfang Liu , Yan Zhao , iommu@lists.linux.dev, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Jason Gunthorpe Subject: Re: [PATCH v10 01/16] iommu: Move iommu fault data to linux/iommu.h Content-Language: en-US To: Joel Granados References: <20240122054308.23901-1-baolu.lu@linux.intel.com> <20240122054308.23901-2-baolu.lu@linux.intel.com> <20240125091734.chekvxgof2d5zpcg@localhost> From: Baolu Lu In-Reply-To: <20240125091734.chekvxgof2d5zpcg@localhost> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024/1/25 17:17, Joel Granados wrote: > On Mon, Jan 22, 2024 at 01:42:53PM +0800, Lu Baolu wrote: >> The iommu fault data is currently defined in uapi/linux/iommu.h, but is >> only used inside the iommu subsystem. Move it to linux/iommu.h, where it >> will be more accessible to kernel drivers. >> >> With this done, uapi/linux/iommu.h becomes empty and can be removed from >> the tree. > The reason for removing this [1] is that it is only being used by > internal code in the kernel. What happens with usespace code that have > used these definitions? Should we deprecate instead of just removing? The interfaces to deliver I/O page faults to user space have never been implemented in the Linux kernel before. Therefore, from a uAPI point of view, this definition is actually dead code. Best regards, baolu