Received-SPF: pass (google.com: domain of linux-kernel+bounces-39028-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 25 Jan 2024 17:19:25 +0000
From: Conor Dooley <conor@kernel.org>
To: Michal Simek <michal.simek@amd.com>
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu, michal.simek@xilinx.com,
	git@xilinx.com, Conor Dooley <conor+dt@kernel.org>,
	Krishna Potthuri <sai.krishna.potthuri@amd.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>,
	"moderated list:ARM/ZYNQ ARCHITECTURE" <linux-arm-kernel@lists.infradead.org>,
	"open list:PIN CONTROL SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: pinctr: pinctrl-zynq: Fix compatible string
Message-ID: <20240125-kindness-remnant-1a43ff5c2ba7@spud>
References: <c1307a4dd5e30290acacc786cb2170deb9eaa539.1706087258.git.michal.simek@amd.com>
 <20240124-frolic-onyx-56bd63791aca@spud>
 <5f2e3917-4767-48ca-9217-fc51fb181daa@amd.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="q2byNkOV5uJxiLYd"
Content-Disposition: inline
In-Reply-To: <5f2e3917-4767-48ca-9217-fc51fb181daa@amd.com>


--q2byNkOV5uJxiLYd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jan 25, 2024 at 08:06:35AM +0100, Michal Simek wrote:
>=20
>=20
> On 1/24/24 17:16, Conor Dooley wrote:
> > On Wed, Jan 24, 2024 at 10:07:46AM +0100, Michal Simek wrote:
> > > Compatible string doesn't really match with compatible string listed =
in the
> > > driver itself. While binding was converted from txt to yaml
> > > xlnx,zynq-pinctrl was listed as compatible string but example was usi=
ng
> > > xlnx,pinctrl-zynq and also this string is used in all DTSes.
> > > xlnx,zynq-pinctrl is used only in dt binding and not present in any DT
> > > which is stable for quite a long time that's why use old compatible s=
tring
> > > and update binding document instead of starting to use unused compati=
ble
> > > string.
> > >=20
> > > Fixes: 153df45acda0 ("dt-bindings: pinctrl: pinctrl-zynq: Convert to =
yaml")
> > > Signed-off-by: Michal Simek <michal.simek@amd.com>
> >=20
> > I assume that U-Boot etc all use the "incorrect" compatible as was in
> > the example? If they do, then the patch seems good to me.
>=20
> Yes. U-Boot is using "incorrect" compatible string from 2015.

Okay. Assuming U-Boot is the only other user, it eems reasonable to
document the defacto compatible then.
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

--q2byNkOV5uJxiLYd
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZbKYHAAKCRB4tDGHoIJi
0j0MAP0XsUr8CoWVUhz+pTTC7zam+Hl9dZJ2qcjeo393jzdwCwEAuFCgBJsVelr6
pw7syCZ9WraRq5bzVsbr7KBgDtkR1QE=
=J64w
-----END PGP SIGNATURE-----

--q2byNkOV5uJxiLYd--