Received-SPF: pass (google.com: domain of linux-kernel+bounces-39155-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 25 Jan 2024 19:54:22 +0100
From: Borislav Petkov <bp@alien8.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "Naik, Avadhut" <avadnaik@amd.com>, Tony Luck <tony.luck@intel.com>,
	Avadhut Naik <avadhut.naik@amd.com>,
	linux-trace-kernel@vger.kernel.org, linux-edac@vger.kernel.org,
	x86@kernel.org, linux-kernel@vger.kernel.org, yazen.ghannam@amd.com
Subject: Re: [PATCH] tracing: Include PPIN in mce_record tracepoint
Message-ID: <20240125185422.GCZbKuXpLUaOzV8IlO@fat_crate.local>
References: <20240123235150.3744089-1-avadhut.naik@amd.com>
 <ZbBV4EGrZw6hJ5IE@agluck-desk3>
 <be870e14-eeb9-4dcf-ba43-a72ef66a3d87@amd.com>
 <20240123203853.66655e95@rorschach.local.home>
 <20240124095708.GAZbDe9Hks0tL2Aj94@fat_crate.local>
 <20240124090908.1c4daea8@rorschach.local.home>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20240124090908.1c4daea8@rorschach.local.home>

On Wed, Jan 24, 2024 at 09:09:08AM -0500, Steven Rostedt wrote:
> I don't think that's a worry anymore. The offsets can change based on
> kernel config. PowerTop needed to have the library ported to it because
> it use to hardcode the offsets but then it broke when running the 32bit
> version on a 64bit kernel.
> 
> > 
> > I guess no until we break some use case and then we will have to revert.
> > At least this is what we've done in the past...
> > 
> 
> But that revert was reverted when we converted PowerTop to use libtraceevent.

Ok, sounds like a good plan.

/me makes a mental note for the future.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette