Received-SPF: pass (google.com: domain of linux-kernel+bounces-39159-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240125102555.2621736-1-ckeepax@opensource.cirrus.com>
 <20240125102555.2621736-2-ckeepax@opensource.cirrus.com> <20240125135509.GL74950@google.com>
In-Reply-To: <20240125135509.GL74950@google.com>
From: Andy Shevchenko <andy.shevchenko@gmail.com>
Date: Thu, 25 Jan 2024 20:54:57 +0200
Message-ID: <CAHp75Vc4jiz3Wjg_1DKs=X=Q8oxMmEASx2VB-BZsawSDa2cwRQ@mail.gmail.com>
Subject: Re: [PATCH v3 2/6] mfd: cs42l43: Tidy up header includes
To: Lee Jones <lee@kernel.org>
Cc: Charles Keepax <ckeepax@opensource.cirrus.com>, broonie@kernel.org, 
	patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, 
	linux-spi@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Jan 25, 2024 at 3:55=E2=80=AFPM Lee Jones <lee@kernel.org> wrote:
> On Thu, 25 Jan 2024, Charles Keepax wrote:
>
> > Use more forward declarations, move header guards to cover other
> > includes, and rely less on including headers through other headers.
> >
> > Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> Patches look okay to me, but seeing as Andy suggested the changes, it
> would be good to get a R-by from him.

I'm worried now only about missing a commit message in one patch and
(with less severity) the v2 of this one which appears not to be
necessary (i.e. v1 is fully okay). If you consider the commit message
absence is okay, feel free to apply v2, otherwise with that addressed
v3 can go in my opinion.

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>


--=20
With Best Regards,
Andy Shevchenko