Received-SPF: pass (google.com: domain of linux-kernel+bounces-39246-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <5de5637f-6572-4817-aab5-af60fc1c81bf@amd.com>
Date: Thu, 25 Jan 2024 14:27:16 -0600
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 0/2] Update mce_record tracepoint
To: "Luck, Tony" <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>
Cc: "linux-trace-kernel@vger.kernel.org"
 <linux-trace-kernel@vger.kernel.org>,
 "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
 "rostedt@goodmis.org" <rostedt@goodmis.org>, "x86@kernel.org"
 <x86@kernel.org>, "linux-kernel@vger.kernel.org"
 <linux-kernel@vger.kernel.org>, "yazen.ghannam@amd.com"
 <yazen.ghannam@amd.com>, Avadhut Naik <avadhut.naik@amd.com>
References: <20240125184857.851355-1-avadhut.naik@amd.com>
 <20240125185821.GDZbKvTW93APAiY1LP@fat_crate.local>
 <SJ1PR11MB6083DAA7A6EDBBDAF5987A80FC7A2@SJ1PR11MB6083.namprd11.prod.outlook.com>
Content-Language: en-US
From: "Naik, Avadhut" <avadnaik@amd.com>
In-Reply-To: <SJ1PR11MB6083DAA7A6EDBBDAF5987A80FC7A2@SJ1PR11MB6083.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?S0crTi95TUtQRTJlZWhXbngvRFZOZWppdjUyMGp3LzFQYXBFVWN2Tkg2blpU?=
 =?utf-8?B?YlZkMW1zcHhwbzRpNFNqc1hKTXhlRmhCNkc0czJQYktKeDdQS0s0OFI0dSsr?=
 =?utf-8?B?QzUyWlRWYmZheUk3dEFGN1hoUkwzcW9POWh4MEJ6NXFFTWlMTXErU3dLVEVZ?=
 =?utf-8?B?dHJwVG1ZRjFjNHJINmQzVFdndGFyeERQYnVuU09PTCtCSFFNYU5Cd0pUbks2?=
 =?utf-8?B?YWFwUGNRMkR2Vm50NUVKdEpxZFZlOExiRks0NGNWV0NGL0piaHEwdXk2WW94?=
 =?utf-8?B?MGlyRytKaURsQVBEc3V6YW1vSmppV2dXS2IrcWhGRENyVitaa09BREI1Z013?=
 =?utf-8?B?aFlBYkpPTEFUcGs3Smc4S1RmQXd1K0s2YSt5ajdZdm5WcFJGdDIvcjdCVllQ?=
 =?utf-8?B?VGV0ckNCUVU0Qnl2VUpFTnNPZW1HZmw0TzVhck5ZSktjdHBRbXlBWGMzSGtk?=
 =?utf-8?B?aDN5Z0FEVHpUWkZDVDFabDd5dGJYdHBtRE9GTHdzM202NHdFR3VLdUExSEFQ?=
 =?utf-8?B?WXFGVkp1c1dvL1pSS2xVSUszcUcrV2s3RFIrK3Z6NXVzbGVScjE4SXQ0dWZF?=
 =?utf-8?B?dmVGOEpYQ0hMQ0tseWtRT285bVhzY2JBcmR2a1BiS0drNDZGNTR6cFhFT3lX?=
 =?utf-8?B?VVRpdXE0UURPdVdqeVMySnN3aEVoMVNueVdQVGRhWGZ3QStVVjhVcWtwWnJY?=
 =?utf-8?B?UlExRGZrVnIrYjdKRld2WTBWRmpxNXNvb2ZONWhTODEySmgxTTNqUmNYNGRW?=
 =?utf-8?B?UTdET05sZWdaTDlUQkJYOU4wQ2JEZ0J6VnFqL3ZMbUdUS0J4OWpaampmTVpY?=
 =?utf-8?B?K2U3TDc0YXRUK3N5VUtYdUlRZUlWdndnbzN6OHhyaDdtSmZhbmpFMWRJZlNB?=
 =?utf-8?B?VmR1ekZmOTMvaDJzVkpXZzh1Njc3RUR0bUMvUnRvKzZYaEE3cGEzVGVla2Zh?=
 =?utf-8?B?RXVnS3hPcFJxOGozbFJIZGdWTEJuczZEOVZwYnZjeDNYdmlicTNxdWptcXUy?=
 =?utf-8?B?bHowMWMxVHdkUnJzRS9mVTl3aXJTS0w5ak54WUVjekRSYXQrUVgxc0NNY3Ju?=
 =?utf-8?B?bWtZMm44ZHFZai9ZYTJxNy9oRDRsakQ1NTJtREVnSFRVSkE2NVdvSmlGNWVu?=
 =?utf-8?B?bnZmWHNXSjVJUXFMTUoxU2VxVnkxcDd6Tk82Z0k3cDFZU21sZDVpWFpCNldq?=
 =?utf-8?B?dW5NZ3AxZ3FLZDgzb0p3MitZb2RraXQ1QmtVNnF0ckI4SmllYWNKOTNuUzl2?=
 =?utf-8?B?T0pjLzdFY0gzUzVpUzQvNHpoWUk4VFV1anFad0dKNE56VDZ4RkxGRGRVOUVI?=
 =?utf-8?B?cnU4ZW9IbEJJVDNwNEkyWnYwUjkyODJpYjlucWNMZEV1dFkzQjdpUHdLKytt?=
 =?utf-8?B?bkx3dDZKQXFTNzdLcWUyWi9yU0YyUWpQd0dYT0VmaURHTjdJOXgxNUdMNUdX?=
 =?utf-8?B?Q1pNc2VBV3RKOXd6QlBTQjlmSWkrVHdpWS81T1N6OFFOcE54QU16QkZMdXlI?=
 =?utf-8?B?US9mVFJGbWdkWmdsTGdxalBuTGR3cVN1MU5kQ0daQVhpK09DYjhtRmxXUXNB?=
 =?utf-8?B?OThtZk5VS0tBcU9naW5ZK1pqWG50SmVRTTZ1Z3poSjZQd2dRQUhwSlRhdldp?=
 =?utf-8?B?ZUxGanU0bkh3VjdtVk1GYUdGVjAvVFVrSWswc0pMV0poQmJwL1M4S2licjRV?=
 =?utf-8?B?TzVUb2MrcVJ6Vm5abk5VYU02ejFTeHRrdW4zTGNZQkxWMTZKVFdrT0E0eFgr?=
 =?utf-8?B?blZ5clZ1RzBwb2l3MGdkcHU5eFJER3cxRENQWGtDNTVyRGFYRGJML3phcGMz?=
 =?utf-8?B?TVlESzBsVmgrYnY3dHNLaDRFWkVmVkxYaGJGeXVyU1hlV09NMklJTFp6SnhZ?=
 =?utf-8?B?L0Q0ZTNHc1R3MUJEcVFvWjUzU1dXYk9kRlE3bmQwSEdhTXdpYm9JYU1vYnhi?=
 =?utf-8?B?bG5RbFp2Ry9ieFE5RVNobjhOT3kreDViQW1SU1MySmN3azFqUU1KYUlHZEpC?=
 =?utf-8?B?Mk95OFk1ZFM2dytjMlI3V25YaHJvUnZlMllRajBTbkRLVCtYUTRndTNvVTI2?=
 =?utf-8?B?NW84RXV0V3hwOVBpVE1IWk5NN1ByV0haWDEveXVMelVyTjd2Ly9aTWtZU09k?=
 =?utf-8?Q?jdzTzdDeOhCzWE2jyqphoThXf?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 39c74bf4-0508-484e-9a7f-08dc1de4076b
X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8403.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2024 20:27:19.5772
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EIphPM1O7ZiB1x6asqyTWRAeFFvOlqOVAX7iyOPEjBBkBntc3SIWjBIygxrrfgIPFM/47f9p/roYgMK+LkLybA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7785

Hi,

On 1/25/2024 1:19 PM, Luck, Tony wrote:
>>> The first patch adds PPIN (Protected Processor Inventory Number) field to
>>> the tracepoint.
>>>
>>> The second patch adds the microcode field (Microcode Revision) to the
>>> tracepoint.
>>
>> This is a lot of static information to add to *every* MCE.
> 
> 8 bytes for PPIN, 4 more for microcode.
> 
> Number of recoverable machine checks per system .... I hope the monthly rate should
> be countable on my fingers. If a system is getting more than that, then people should
> be looking at fixing the underlying problem.
> 
> Corrected errors are much more common. Though Linux takes action to limit the
> rate when storms occur. So maybe hundreds or small numbers of thousands of
> error trace records? Increase in trace buffer consumption still measured in Kbytes
> not Mbytes. Server systems that do machine check reporting now start at tens of
> GBytes memory.
> 
>> And where does it end? Stick full dmesg in the tracepoint too?
> 
> Seems like overkill.
> 
>> What is the real-life use case here?
> 
> Systems using rasdaemon to track errors will be able to track both of these
> (I assume that Naik has plans to update rasdaemon to capture and save these
> new fields).
> 
Yes, I do intend to submit a pull request to the rasdaemon to parse and log these
new fields.

> PPIN is useful when talking to the CPU vendor about patterns of similar errors
> seen across a cluster.
> 
> MICROCODE - gives a fast path to root cause problems that have already
> been fixed in a microcode update.
> 
> -Tony

-- 
Thanks,
Avadhut Naik